paweld/fpc
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/fpc/source.git synced 2025-04-05 18:47:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

Darwin: disable new assembler fill*word variants

Browse Source 
They use interprocedural gotos at the assembler level, which is incompatible
with auto-generated CFI
This commit is contained in:
Jonas Maebe 2024-11-20 21:39:19 +01:00
parent 1230e5a623
commit 28e9ebc7da
1 changed files with 23 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
rtl/i386/i386.inc
View File

@ -161,14 +161,23 @@ end;
{$endif FPC_SYSTEM_HAS_MOVE} {$endif FPC_SYSTEM_HAS_MOVE}
{$if not defined(FPC_SYSTEM_HAS_FILLCHAR) { Darwin uses Clang to assemble. Recent Clang versions (rightly) give an error when you add global labels in
or not defined(FPC_SYSTEM_HAS_FILLWORD) the middle of .cfi_startproc / .cfi_endproc pairs, since this means you could jump into it from other code
or not defined(FPC_SYSTEM_HAS_FILLDWORD) whose CFI state is completely different without the compiler even having the theoretical ability to analyse
or not defined(FPC_SYSTEM_HAS_FILLQWORD)} all code and generate balanced information.
Since FPC does not attempt it even for local labels, this kind of code is inherently unsafe.
}
{$if not defined(darwin) and
(not defined(FPC_SYSTEM_HAS_FILLCHAR)
or not defined(FPC_SYSTEM_HAS_FILLWORD)
or not defined(FPC_SYSTEM_HAS_FILLDWORD)
or not defined(FPC_SYSTEM_HAS_FILLQWORD)
)}
{$if not defined(FPC_SYSTEM_HAS_FILLCHAR) {$if not defined(FPC_SYSTEM_HAS_FILLCHAR)
or not defined(FPC_SYSTEM_HAS_FILLWORD) or not defined(FPC_SYSTEM_HAS_FILLWORD)
or not defined(FPC_SYSTEM_HAS_FILLDWORD)} or not defined(FPC_SYSTEM_HAS_FILLDWORD)}
const const
FillXxxx_RepStosThreshold_ERMS = 1024; FillXxxx_RepStosThreshold_ERMS = 1024;
FillXxxx_RepStosThreshold_NoERMS = 512 * 1024; FillXxxx_RepStosThreshold_NoERMS = 512 * 1024;
@ -330,7 +339,8 @@ end;
{$endif FillChar/Word/DWord/QWord required.} {$endif FillChar/Word/DWord/QWord required.}
{$ifndef FPC_SYSTEM_HAS_FILLCHAR} {$if not defined(darwin) and
not defined(FPC_SYSTEM_HAS_FILLCHAR)}
{$define FPC_SYSTEM_HAS_FILLCHAR} {$define FPC_SYSTEM_HAS_FILLCHAR}
procedure FillChar_3OrLess; assembler; nostackframe; procedure FillChar_3OrLess; assembler; nostackframe;
{ cl — x, edx — byte count, Low(int32) <= edx <= 3. } { cl — x, edx — byte count, Low(int32) <= edx <= 3. }
@ -428,7 +438,8 @@ end;
{$endif FPC_SYSTEM_HAS_FILLCHAR} {$endif FPC_SYSTEM_HAS_FILLCHAR}
{$ifndef FPC_SYSTEM_HAS_FILLWORD} {$if not defined(darwin) and
not defined(FPC_SYSTEM_HAS_FILLWORD)}
{$define FPC_SYSTEM_HAS_FILLWORD} {$define FPC_SYSTEM_HAS_FILLWORD}
procedure FillWord_3OrLess; assembler; nostackframe; procedure FillWord_3OrLess; assembler; nostackframe;
asm asm
@ -516,7 +527,8 @@ end;
{$endif FPC_SYSTEM_HAS_FILLWORD} {$endif FPC_SYSTEM_HAS_FILLWORD}
{$ifndef FPC_SYSTEM_HAS_FILLDWORD} {$if not defined(darwin) and
not defined(FPC_SYSTEM_HAS_FILLDWORD)}
{$define FPC_SYSTEM_HAS_FILLDWORD} {$define FPC_SYSTEM_HAS_FILLDWORD}
procedure FillDWord_4OrLess; assembler; nostackframe; procedure FillDWord_4OrLess; assembler; nostackframe;
asm asm
@ -590,7 +602,8 @@ end;
{$endif FPC_SYSTEM_HAS_FILLDWORD} {$endif FPC_SYSTEM_HAS_FILLDWORD}
{$ifndef FPC_SYSTEM_HAS_FILLQWORD} {$if not defined(darwin) and
not defined(FPC_SYSTEM_HAS_FILLQWORD)}
{$define FPC_SYSTEM_HAS_FILLQWORD} {$define FPC_SYSTEM_HAS_FILLQWORD}
{$ifndef CPUX86_HAS_SSE2} {$ifndef CPUX86_HAS_SSE2}
procedure FillQWord_Plain(var x;count:SizeInt;value:QWord);assembler;nostackframe; procedure FillQWord_Plain(var x;count:SizeInt;value:QWord);assembler;nostackframe;