paweld/fpc
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/fpc/source.git synced 2025-08-17 02:39:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

* when checking for stack tainting parameters, verify all locations of every

Browse Source 
parameter instead of only the first location (mantis #17590)

git-svn-id: trunk@16121 -
This commit is contained in:
Jonas Maebe 2010-10-10 12:36:59 +00:00
parent 1844ff4c01
commit 31dab28eca
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
compiler/symdef.pas
View File

@ -3066,6 +3066,7 @@ implementation
function tabstractprocdef.stack_tainting_parameter(side: tcallercallee): boolean; function tabstractprocdef.stack_tainting_parameter(side: tcallercallee): boolean;
var var
p: tparavarsym; p: tparavarsym;
ploc: PCGParalocation;
i: longint; i: longint;
begin begin
result:=false; result:=false;
@ -3077,10 +3078,20 @@ implementation
{ check if no parameter is located on the stack } { check if no parameter is located on the stack }
if is_open_array(p.vardef) or if is_open_array(p.vardef) or
is_array_of_const(p.vardef) then is_array_of_const(p.vardef) then
result:=true; begin
if assigned(p.paraloc[side].location) and result:=true;
(p.paraloc[side].location^.loc=LOC_REFERENCE) then exit;
result:=true; end;
ploc:=p.paraloc[side].location;
while assigned(ploc) do
begin
if (ploc^.loc=LOC_REFERENCE) then
begin
result:=true;
exit
end;
ploc:=ploc^.next;
end;
end; end;
end; end;