diff --git a/packages/fcl-db/tests/sqldbtoolsunit.pas b/packages/fcl-db/tests/sqldbtoolsunit.pas index 6ff5f9df8a..aae1f9b52e 100644 --- a/packages/fcl-db/tests/sqldbtoolsunit.pas +++ b/packages/fcl-db/tests/sqldbtoolsunit.pas @@ -147,11 +147,6 @@ begin UserName := dbuser; Password := dbpassword; HostName := dbhostname; - if length(dbQuoteChars)>1 then - begin - FieldNameQuoteChars[0] := dbQuoteChars[1]; - FieldNameQuoteChars[1] := dbQuoteChars[2]; - end; open; end; end; diff --git a/packages/fcl-db/tests/testfieldtypes.pas b/packages/fcl-db/tests/testfieldtypes.pas index 7538fddc44..e0c1f91187 100644 --- a/packages/fcl-db/tests/testfieldtypes.pas +++ b/packages/fcl-db/tests/testfieldtypes.pas @@ -770,10 +770,6 @@ begin ShortDateFormat := 'yyyy-mm-dd'; - // There is no Param.AsFixedChar, so the datatype has to be set manually - if ADatatype=ftFixedChar then - Params.ParamByName('field1').DataType := ftFixedChar; - for i := 0 to testValuesCount -1 do begin Params.ParamByName('id').AsInteger := i; @@ -805,7 +801,13 @@ begin ftInteger: AssertEquals(testIntValues[i],FieldByName('FIELD1').AsInteger); ftFloat : AssertEquals(testFloatValues[i],FieldByName('FIELD1').AsFloat); ftBCD : AssertEquals(testBCDValues[i],FieldByName('FIELD1').AsCurrency); - ftFixedChar : AssertEquals(PadRight(testStringValues[i],10),FieldByName('FIELD1').AsString); + ftFixedChar : + begin + if FieldByName('FIELD1').isnull then + AssertEquals(testStringValues[i],FieldByName('FIELD1').AsString) + else + AssertEquals(PadRight(testStringValues[i],10),FieldByName('FIELD1').AsString); + end; ftString : AssertEquals(testStringValues[i],FieldByName('FIELD1').AsString); ftdate : AssertEquals(testDateValues[i],FormatDateTime('yyyy/mm/dd',FieldByName('FIELD1').AsDateTime)); else @@ -1318,11 +1320,18 @@ procedure TTestFieldTypes.TestNumericNames; begin with TSQLDBConnector(DBConnector) do begin - Connection.ExecuteDirect('create table FPDEV2 ( ' + - ' '+connection.FieldNameQuoteChars[0]+'2ID'+connection.FieldNameQuoteChars[1]+' INT NOT NULL, ' + - ' '+connection.FieldNameQuoteChars[0]+'3TEST'+connection.FieldNameQuoteChars[1]+' VARCHAR(10), ' + - ' PRIMARY KEY ('+connection.FieldNameQuoteChars[0]+'2ID'+connection.FieldNameQuoteChars[0]+') ' + - ') '); + if not (SQLDbType in MySQLdbTypes) then + Connection.ExecuteDirect('create table FPDEV2 ( ' + + ' "2ID" INT NOT NULL , ' + + ' "3TEST" VARCHAR(10), ' + + ' PRIMARY KEY ("2ID") ' + + ') ') + else + Connection.ExecuteDirect('create table FPDEV2 ( ' + + ' 2ID INT NOT NULL , ' + + ' 3TEST VARCHAR(10), ' + + ' PRIMARY KEY (2ID) ' + + ') '); // Firebird/Interbase need a commit after a DDL statement. Not necessary for the other connections TSQLDBConnector(DBConnector).Transaction.CommitRetaining; with query do diff --git a/packages/fcl-db/tests/toolsunit.pas b/packages/fcl-db/tests/toolsunit.pas index a236eb6c87..13eb6c0b74 100644 --- a/packages/fcl-db/tests/toolsunit.pas +++ b/packages/fcl-db/tests/toolsunit.pas @@ -162,8 +162,7 @@ var dbtype, dbname, dbuser, dbhostname, - dbpassword, - dbQuoteChars : string; + dbpassword : string; DataEvents : string; DBConnector : TDBConnector; testValues : Array [TFieldType,0..testvaluescount -1] of string; @@ -243,7 +242,6 @@ begin dbhostname := IniFile.ReadString(dbtype,'Hostname',''); dbpassword := IniFile.ReadString(dbtype,'Password',''); dbconnectorparams := IniFile.ReadString(dbtype,'ConnectorParams',''); - dbquotechars := IniFile.ReadString(dbtype,'QuoteChars',''); IniFile.Free; end; @@ -255,7 +253,6 @@ begin if DBConnectorRefCount>0 then exit; testValues[ftString] := testStringValues; testValues[ftFixedChar] := testStringValues; - testValues[ftDate] := testDateValues; for i := 0 to testValuesCount-1 do begin testValues[ftFloat,i] := FloatToStr(testFloatValues[i]); @@ -269,6 +266,7 @@ begin testValues[ftCurrency,i] := CurrToStr(testCurrencyValues[i]); // DecimalSeparator:='.'; testValues[ftBCD,i] := CurrToStr(testCurrencyValues[i]); + testValues[ftDate,i] := DateToStr(StrToDate(testDateValues[i], 'yyyy/mm/dd', '-')); end; if dbconnectorname = '' then raise Exception.Create('There is no db-connector specified');