paweld/fpc
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/fpc/source.git synced 2025-06-03 21:38:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

* fixed compile error when assigning to a widestring property which

Browse Source 
directly writes to a field for tf_winlikewidestring targets (caused
    by the stricter property checks)

git-svn-id: trunk@7259 -
This commit is contained in:
Jonas Maebe 2007-05-04 13:15:11 +00:00
parent 0f73d54ac8
commit 3a4508b1bb
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
compiler/nld.pas
View File

@ -695,6 +695,22 @@ implementation
{ call helpers for windows widestrings, they aren't ref. counted }
if (tf_winlikewidestring in target_info.flags) and is_widestring(left.resultdef) then
begin
{ The first argument of fpc_widestr_assign is a var parameter. Properties cannot }
{ be passed to var or out parameters, because in that case setters/getters are not }
{ used. Further, if we would allow it in case there are no getters or setters, you }
{ would need source changes in case these are introduced later on, thus defeating }
{ part of the transparency advantages of properties. In this particular case, }
{ however: }
{ a) if there is a setter, this code will not be used since then the assignment }
{ will be converted to a procedure call }
{ b) the getter is irrelevant, because fpc_widestr_assign must always decrease }
{ the refcount of the field to which we are writing }
{ c) source code changes are not required if a setter is added/removed, because }
{ this transformation is handled at compile time }
{ -> we can remove the nf_isproperty flag (if any) from left, so that in case it }
{ is a property which refers to a field without a setter call, we will not get }
{ an error about trying to pass a property as a var parameter }
exclude(left.flags,nf_isproperty);
hp:=ccallparanode.create(ctypeconvnode.create_internal(right,voidpointertype),
ccallparanode.create(ctypeconvnode.create_internal(left,voidpointertype),
nil));