paweld/fpc
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/fpc/source.git synced 2025-08-19 02:50:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

* tinterlockedmt: Fix race conditions in the InterLockedCompareExchange test.

Browse Source 
git-svn-id: trunk@32089 -
This commit is contained in:
yury 2015-10-18 11:07:29 +00:00
parent 1a285a7d24
commit 3fcbb7d2d4
1 changed files with 18 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
tests/test/tinterlockedmt.pp
View File

@ -60,6 +60,8 @@ begin
FOption:=AOption; FOption:=AOption;
inherited Create(True); inherited Create(True);
FreeOnTerminate:=True; FreeOnTerminate:=True;
if FOp = opCompareExchange then
Priority:=tpHighest;
end; end;
procedure TWorker.Execute; procedure TWorker.Execute;
@ -118,24 +120,29 @@ begin
t:=Now; t:=Now;
j:=0; j:=0;
while InterLockedCompareExchange(Counter3, FOption + 1, FOption) <> FOption do begin while InterLockedCompareExchange(Counter3, FOption + 1, FOption) <> FOption do begin
if AbortThread then
break;
Inc(j); Inc(j);
if (j > 1000) and (Now - t >= 5/SecsPerDay) then begin if j >= 10000 then begin
if Now - t >= 5/SecsPerDay then begin
writeln('InterLockedCompareExchange seems to be broken.'); writeln('InterLockedCompareExchange seems to be broken.');
Halt(10); Halt(10);
end; end;
Sleep(1);
end;
{$ifdef FPC} {$ifdef FPC}
ThreadSwitch; ThreadSwitch;
{$else} {$else}
Sleep(0); Sleep(0);
{$endif FPC} {$endif FPC}
end; end;
if AbortThread then
break;
if FOption + 2 <> LastCompareVal then if FOption + 2 <> LastCompareVal then
InterLockedIncrement(Counter3) InterLockedIncrement(Counter3)
else else
InterLockedExchange(Counter3, 0); InterLockedExchange(Counter3, 0);
InterLockedIncrement(Counter2); InterLockedIncrement(Counter2);
if AbortThread then
break;
end; end;
end; end;
end; end;
@ -146,7 +153,7 @@ end;
procedure Run; procedure Run;
var var
i, j, k, CmpCount: longint; i, j, k, CmpCount: longint;
t: TDateTime; t, tt: TDateTime;
workers: array[0..TotalThreadCount - 1] of TWorker; workers: array[0..TotalThreadCount - 1] of TWorker;
begin begin
Counter:=0; Counter:=0;
@ -196,7 +203,7 @@ begin
end end
else begin else begin
AbortThread:=True; AbortThread:=True;
writeln('Timeout has expired.'); writeln('Timeout has expired. Active threads left: ', WorkingCount);
t:=Now; t:=Now;
end; end;
end; end;
@ -204,15 +211,18 @@ begin
end; end;
if AbortThread then begin if AbortThread then begin
writeln('The execution is too slow.'); writeln('The execution is too slow (', Counter2, ').');
Halt(2); Halt(2);
end; end;
tt:=Now;
CheckResult(Counter, 0, 1, 'Counter error:'); CheckResult(Counter, 0, 1, 'Counter error:');
CheckResult(Counter2, (k div 2)*CmpCount, 4, 'Counter2 error:'); CheckResult(Counter2, (k div 2)*CmpCount, 4, 'Counter2 error:');
writeln('Test OK.'); writeln('Test OK.');
writeln('InterLockedCompareExchange: ', Round(Counter2/((tt-t)*SecsPerDay)), ' ops/sec.');
end; end;
begin begin