paweld/fpc
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/fpc/source.git synced 2025-09-01 23:50:23 +02:00
Code Issues Packages Projects Releases Wiki Activity

* x86: Fixed bug in TEST/JNE/TEST/JNE optimisation that caused bad code to be generated under -O3

Browse Source
This commit is contained in:
J. Gareth "Curious Kit" Moreton 2023-07-27 18:54:59 +01:00 committed by J. Gareth "Kit" Moreton
parent 11957d9a60
commit 699db16fe4
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
compiler/x86/aoptx86.pas
View File

@ -5313,7 +5313,6 @@ unit aoptx86;
{ Search for: { Search for:
test $x,(reg/ref) test $x,(reg/ref)
jne @lbl1 jne @lbl1
...
test $y,(reg/ref) (same register or reference) test $y,(reg/ref) (same register or reference)
jne @lbl1 jne @lbl1
@ -5481,6 +5480,16 @@ unit aoptx86;
(FirstValue = -1) or (FirstValue = -1) or
(SecondValue = -1) or (SecondValue = -1) or
MatchOperand(taicpu(hp1_dist).oper[0]^, taicpu(hp1).oper[0]^) MatchOperand(taicpu(hp1_dist).oper[0]^, taicpu(hp1).oper[0]^)
) and
(
{ In this situation, the TEST/JNE pairs must be adjacent (fixes #40366) }
{ Always adjacent under -O2 and under }
not(cs_opt_level3 in current_settings.optimizerswitches) or
(
GetNextInstruction(hp1, hp1_last) and
(hp1_last = p_dist)
)
) then ) then
begin begin
{ Same jump location... can be a register since nothing's changed } { Same jump location... can be a register since nothing's changed }