paweld/fpc
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/fpc/source.git synced 2025-08-07 00:46:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

* avoid unneeded the generation of un-needed shift instructions thlcgobj.in a_load_subsetreg_reg

Browse Source 
git-svn-id: trunk@37374 -
This commit is contained in:
florian 2017-10-01 16:13:22 +00:00
parent 6f338bb4b5
commit 75e03a7e62
1 changed files with 23 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
compiler/hlcgobj.pas
View File

@ -1281,25 +1281,32 @@ implementation
begin begin
subsetregdef:=cgsize_orddef(sreg.subsetregsize); subsetregdef:=cgsize_orddef(sreg.subsetregsize);
tmpreg:=getintregister(list,subsetregdef); tmpreg:=getintregister(list,subsetregdef);
if is_signed(subsetsize) then { insert shifts only if it changes bits being accessed later on }
if (sreg.startbit<>0) or
(tosize.size*8>sreg.bitlen) then
begin begin
{ sign extend in case the value has a bitsize mod 8 <> 0 } if is_signed(subsetsize) then
{ both instructions will be optimized away if not } begin
a_op_const_reg_reg(list,OP_SHL,subsetregdef,(tcgsize2size[sreg.subsetregsize]*8)-sreg.startbit-sreg.bitlen,sreg.subsetreg,tmpreg); { sign extend in case the value has a bitsize mod 8 <> 0 }
a_op_const_reg(list,OP_SAR,subsetregdef,(tcgsize2size[sreg.subsetregsize]*8)-sreg.bitlen,tmpreg); { both instructions will be optimized away if not }
a_op_const_reg_reg(list,OP_SHL,subsetregdef,(tcgsize2size[sreg.subsetregsize]*8)-sreg.startbit-sreg.bitlen,sreg.subsetreg,tmpreg);
a_op_const_reg(list,OP_SAR,subsetregdef,(tcgsize2size[sreg.subsetregsize]*8)-sreg.bitlen,tmpreg);
end
else
begin
a_op_const_reg_reg(list,OP_SHR,subsetregdef,sreg.startbit,sreg.subsetreg,tmpreg);
stopbit:=sreg.startbit+sreg.bitlen;
// on x86(64), 1 shl 32(64) = 1 instead of 0
// use aword to prevent overflow with 1 shl 31
if (stopbit-sreg.startbit<>AIntBits) then
bitmask:=(aword(1) shl (stopbit-sreg.startbit))-1
else
bitmask:=high(aword);
a_op_const_reg(list,OP_AND,subsetregdef,tcgint(bitmask),tmpreg);
end;
end end
else else
begin a_load_reg_reg(list,subsetregdef,subsetregdef,sreg.subsetreg,tmpreg);
a_op_const_reg_reg(list,OP_SHR,subsetregdef,sreg.startbit,sreg.subsetreg,tmpreg);
stopbit:=sreg.startbit+sreg.bitlen;
// on x86(64), 1 shl 32(64) = 1 instead of 0
// use aword to prevent overflow with 1 shl 31
if (stopbit-sreg.startbit<>AIntBits) then
bitmask:=(aword(1) shl (stopbit-sreg.startbit))-1
else
bitmask:=high(aword);
a_op_const_reg(list,OP_AND,subsetregdef,tcgint(bitmask),tmpreg);
end;
subsetsizereg:=getintregister(list,subsetsize); subsetsizereg:=getintregister(list,subsetsize);
a_load_reg_reg(list,subsetregdef,subsetsize,tmpreg,subsetsizereg); a_load_reg_reg(list,subsetregdef,subsetsize,tmpreg,subsetsizereg);
a_load_reg_reg(list,subsetsize,tosize,subsetsizereg,destreg); a_load_reg_reg(list,subsetsize,tosize,subsetsizereg,destreg);