paweld/fpc
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/fpc/source.git synced 2025-08-17 11:45:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

Revert " * patch by Rika: SwapEndian([u]int16) has unnecessary “and $FFFF”, resolves #39814"

Browse Source 
This reverts commit f92102a5f2.

The and $ffff is needed to avoid range check warnings when the function is inlined with a constant parameter
This commit is contained in:
florian 2022-07-15 18:54:49 +02:00
parent 8d90cd3e64
commit 799c22d553
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
rtl/inc/generic.inc
View File

@ -2667,13 +2667,13 @@ function SwapEndian(const AValue: SmallInt): SmallInt;{$ifdef SYSTEMINLINE}inlin
{ is turned into "longint(AValue) shr 8", so if AValue < 0 then } { is turned into "longint(AValue) shr 8", so if AValue < 0 then }
{ the sign bits from the upper 16 bits are shifted in rather than } { the sign bits from the upper 16 bits are shifted in rather than }
{ zeroes. } { zeroes. }
Result := SmallInt((Word(AValue) shr 8) or (Word(AValue) shl 8)); Result := SmallInt(((Word(AValue) shr 8) or (Word(AValue) shl 8)) and $ffff);
end; end;
{$ifndef cpujvm} {$ifndef cpujvm}
function SwapEndian(const AValue: Word): Word;{$ifdef SYSTEMINLINE}inline;{$endif} function SwapEndian(const AValue: Word): Word;{$ifdef SYSTEMINLINE}inline;{$endif}
begin begin
Result := (AValue shr 8) or (AValue shl 8); Result := ((AValue shr 8) or (AValue shl 8)) and $ffff;
end; end;
{$endif} {$endif}