paweld/fpc
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/fpc/source.git synced 2025-12-09 09:28:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

* reject "absolute" variables referencing locations with implicit

Browse Source 
dereferences (the tests from the previous commit were actually
    for this change)

git-svn-id: trunk@12878 -
This commit is contained in:
Jonas Maebe 2009-03-13 21:17:39 +00:00
parent 4f51aef122
commit 7bf643746e
1 changed files with 31 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
compiler/pdecvar.pas
View File

@ -1059,7 +1059,37 @@ implementation
{ remove subscriptn before checking for loadn } { remove subscriptn before checking for loadn }
hp:=pt; hp:=pt;
while (hp.nodetype in [subscriptn,typeconvn,vecn]) do while (hp.nodetype in [subscriptn,typeconvn,vecn]) do
hp:=tunarynode(hp).left; begin
{ check for implicit dereferencing and reject it }
if (hp.nodetype in [subscriptn,vecn]) then
begin
if (tunarynode(hp).left.resultdef.typ in [pointerdef,classrefdef]) then
break;
{ catch, e.g., 'var b: char absolute pchar_var[5];"
(pchar_var[5] is a pchar_2_string typeconv ->
the vecn only sees an array of char)
I don't know if all of these type conversions are
possible, but they're definitely all bad.
}
if (tunarynode(hp).left.nodetype=typeconvn) and
(ttypeconvnode(tunarynode(hp).left).convtype in
[tc_pchar_2_string,tc_pointer_2_array,
tc_intf_2_string,tc_intf_2_guid,
tc_dynarray_2_variant,tc_interface_2_variant,
tc_array_2_dynarray]) then
break;
if (tunarynode(hp).left.resultdef.typ=stringdef) and
not(tstringdef(tunarynode(hp).left.resultdef).stringtype in [st_shortstring,st_longstring]) then
break;
if (tunarynode(hp).left.resultdef.typ=objectdef) and
(tobjectdef(tunarynode(hp).left.resultdef).objecttype<>odt_object) then
break;
if is_dynamic_array(tunarynode(hp).left.resultdef) then
break;
end;
hp:=tunarynode(hp).left;
end;
if (hp.nodetype=loadn) then if (hp.nodetype=loadn) then
begin begin
{ we should check the result type of loadn } { we should check the result type of loadn }