paweld/fpc
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/fpc/source.git synced 2025-04-05 06:38:00 +02:00
Code Issues Packages Projects Releases Wiki Activity

Unbias 32-bit random.

Browse Source
This commit is contained in:
Rika Ichinose 2025-03-06 21:25:22 +03:00 committed by FPK
parent c07da2a654
commit 8093b1ba0c
1 changed files with 37 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
rtl/inc/system.inc
View File

@ -737,34 +737,54 @@ var
// so I doubt an additional check like "if (RandSeed <> OldRandSeed) or not RngInitialized" is justified. // so I doubt an additional check like "if (RandSeed <> OldRandSeed) or not RngInitialized" is justified.
function random(l:longint): longint; function random(l:longint): longint;
var
t: uint32;
m: uint64;
begin begin
{ otherwise we can return values = l (JM) } result:=l;
if (l < 0) then if l<0 then
inc(l); result:=-result-1; { from now on, uint32(result) is a bound. }
random := longint((int64(xsr128_32_u32rand)*l) shr 32);
{ https://lemire.me/blog/2019/06/06/nearly-divisionless-random-integer-generation-on-various-systems/ }
m:=uint64(xsr128_32_u32rand)*uint32(result);
if Lo(m)<uint32(result) then
begin
t:=uint32(-result) mod uint32(result);
while Lo(m)<t do
m:=uint64(xsr128_32_u32rand)*uint32(result);
end;
result:=Hi(m);
if l<-1 then
result:=-result-1;
end; end;
function random(l:int64): int64; function random(l:int64): int64;
var var
t, ul, mLo: uint64;
a: uint32; a: uint32;
neg: boolean;
begin begin
if (l>=Low(int32)) and (l<=High(int32)) then if l=int32(l) then
begin { This makes random(NativeType) on 64-bit platforms match 32-bit when possible. }
{ random(longint(l)), inlined. This makes random(NativeType) on 64-bit platforms match 32-bit when possible. } exit(random(longint(l)));
if (l < 0) then
inc(l);
exit(longint(int64(xsr128_32_u32rand)*l shr 32));
end;
neg:=l<0; ul:=l;
if neg then if l<0 then
l:=-l-1; ul:=-ul-1;
a:=xsr128_32_u32rand; a:=xsr128_32_u32rand;
UMul64x64_128(uint64(a) shl 32 or xsr128_32_u32rand, uint64(l), uint64(result)); mLo:=UMul64x64_128(uint64(a) shl 32 or xsr128_32_u32rand,ul,uint64(result));
if mLo<ul then
begin
t:=uint64(-ul) mod ul;
while mLo<t do
begin
a:=xsr128_32_u32rand;
mLo:=UMul64x64_128(uint64(a) shl 32 or xsr128_32_u32rand,ul,uint64(result));
end;
end;
if neg then if l<-1 then
result:=-result-1; result:=-result-1;
end; end;