paweld/fpc
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/fpc/source.git synced 2025-08-18 04:49:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

* x86: Fixed oversight in LeaLea2LeaLea optimisations where bad code is

Browse Source 
generated if the intermediate register appears in the first reference
This commit is contained in:
J. Gareth "Curious Kit" Moreton 2025-02-27 01:18:57 +00:00 committed by FPK
parent d86e726e87
commit 83c9b17ec5
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
compiler/x86/aoptx86.pas
View File

@ -6425,7 +6425,12 @@ unit aoptx86;
( (
{ Don't optimise if size is a concern and the intermediate register remains in use } { Don't optimise if size is a concern and the intermediate register remains in use }
IntermediateRegDiscarded or IntermediateRegDiscarded or
not (cs_opt_size in current_settings.optimizerswitches) (
not (cs_opt_size in current_settings.optimizerswitches) and
{ If the intermediate register is not discarded, it must not
appear in the first LEA's reference. (Fixes #41166) }
not RegInRef(taicpu(p).oper[1]^.reg, taicpu(p).oper[0]^.ref^)
)
) and ) and
(taicpu(hp1).oper[0]^.ref^.index = taicpu(p).oper[1]^.reg) and (taicpu(hp1).oper[0]^.ref^.index = taicpu(p).oper[1]^.reg) and
( (
@ -6522,7 +6527,12 @@ unit aoptx86;
if ( if (
{ Don't optimise if size is a concern and the intermediate register remains in use } { Don't optimise if size is a concern and the intermediate register remains in use }
IntermediateRegDiscarded or IntermediateRegDiscarded or
not (cs_opt_size in current_settings.optimizerswitches) (
not (cs_opt_size in current_settings.optimizerswitches) and
{ If the intermediate register is not discarded, it must not
appear in the first LEA's reference. (Fixes #41166) }
not RegInRef(taicpu(p).oper[1]^.reg, taicpu(p).oper[0]^.ref^)
)
) and ) and
( (
( (