paweld/fpc
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/fpc/source.git synced 2025-08-17 03:59:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Contra intuitive: TEditor.SetBufSize should not change BufSize at all

Browse Source
This commit is contained in:
Margers 2024-09-24 10:30:58 +00:00 committed by Michael Van Canneyt
parent 4b4f910289
commit 86486f9c46
1 changed files with 1 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
packages/fv/src/editors.pas
View File

@ -3020,26 +3020,7 @@ end; { TEditor.SetBufLen }
function TEditor.SetBufSize (NewSize : Sw_Word) : Boolean; function TEditor.SetBufSize (NewSize : Sw_Word) : Boolean;
begin begin
{ This function is called on every new key typed on keyboard if BufSize>=NewSize then SetBufSize:=true else SetBufSize:=false;
and NewSize is BufLen+1. That is bad idea.
Fix: do not allow downsize Buffer,
make incremental grow at last by 4k.
}
if NewSize > BufSize then
begin
if (NewSize+4096-1) and (not Sw_Word(4095)) > BufSize then
begin
{Buffer increment to 4k boundary}
ReAllocMem(Buffer, (NewSize+4096-1) and (not Sw_Word(4095)) );
BufSize := (NewSize+4096-1) and (not Sw_Word(4095));
end else
begin
{branch is taken only if NewSize+4096 wrap around sw_word }
ReAllocMem(Buffer, NewSize);
BufSize := NewSize;
end;
end;
SetBufSize := True;
end; { TEditor.SetBufSize } end; { TEditor.SetBufSize }