From 99b01f66343d9d28c1231953d186a4e5f34b3210 Mon Sep 17 00:00:00 2001 From: florian Date: Mon, 6 Mar 2023 23:19:34 +0100 Subject: [PATCH] * second mul might get called with a zero operand if the other has a side effect, handle this correctly in ti386addnode.second_mul64bit, resolves #40182 --- compiler/i386/n386add.pas | 12 ++++++++++++ tests/webtbs/tw40182.pp | 15 +++++++++++++++ 2 files changed, 27 insertions(+) create mode 100644 tests/webtbs/tw40182.pp diff --git a/compiler/i386/n386add.pas b/compiler/i386/n386add.pas index 78ea6d1223..3142623557 100644 --- a/compiler/i386/n386add.pas +++ b/compiler/i386/n386add.pas @@ -573,6 +573,18 @@ interface { calculate 32-bit terms lo(right)*hi(left) and hi(left)*lo(right) } if (right.location.loc=LOC_CONSTANT) then begin + { if left has side effects, it could be that this code is called with right.location.value64=0, + see also #40182 } + if right.location.value64=0 then + begin + location_reset(location,LOC_REGISTER,def_cgsize(resultdef)); + location.register64.reglo := cg.getintregister(current_asmdata.CurrAsmList,OS_INT); + emit_const_reg(A_MOV,S_L,0,location.register64.reglo); + location.register64.reghi := cg.getintregister(current_asmdata.CurrAsmList,OS_INT); + emit_const_reg(A_MOV,S_L,0,location.register64.reghi); + exit; + end; + { Omit zero terms, if any } hreg1:=NR_NO; hreg2:=NR_NO; diff --git a/tests/webtbs/tw40182.pp b/tests/webtbs/tw40182.pp new file mode 100644 index 0000000000..404d2be7da --- /dev/null +++ b/tests/webtbs/tw40182.pp @@ -0,0 +1,15 @@ +{ %opt=-CO } + +program test; +function somenumber: int64; +begin + exit(2); +end; + +function foo: int64; +begin + exit (0*somenumber); //Internal error 2014011604 +end; + +begin +end. \ No newline at end of file