From 9f72de4276195671ec102c3b33ec148dd3b5e985 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Van=20Canneyt?= Date: Wed, 10 Apr 2024 10:31:18 +0200 Subject: [PATCH] * Remove some useless warnings --- packages/webidl/src/webidltopas.pp | 16 ++++++++++++++-- packages/webidl/src/webidltowasmjob.pp | 5 +++-- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/packages/webidl/src/webidltopas.pp b/packages/webidl/src/webidltopas.pp index 5cbb37274b..2bbabc882a 100644 --- a/packages/webidl/src/webidltopas.pp +++ b/packages/webidl/src/webidltopas.pp @@ -650,6 +650,18 @@ procedure TBaseWebIDLToPas.EnsureUniqueNames(ML: TIDLDefinitionList); Var L: TFPObjectHashTable; + Function CanRename(Def: TIDLDefinition) : Boolean; + + var + isStringifier : Boolean; + IsIterable : Boolean; + + begin + IsStringifier:=(Def.Name='') and (Def is TIDLAttributeDefinition) and (aoStringifier in TIDLAttributeDefinition(Def).Options); + isIterable:=(Def is TIDLIterableDefinition); + Result:=not (IsStringifier or isIterable); + end; + Procedure CheckRename(Def: TIDLDefinition); var @@ -701,10 +713,10 @@ begin L:=TFPObjectHashTable.Create(False); try For D in ML Do - if not (D is TIDLConstDefinition) then + if CanRename(D) and not (D is TIDLConstDefinition) then CheckRename(D); For D in ML Do - if (D is TIDLConstDefinition) then + if CanRename(D) and(D is TIDLConstDefinition) then CheckRename(D); finally L.Free; diff --git a/packages/webidl/src/webidltowasmjob.pp b/packages/webidl/src/webidltowasmjob.pp index 4969e0c446..9b746d5b60 100644 --- a/packages/webidl/src/webidltowasmjob.pp +++ b/packages/webidl/src/webidltowasmjob.pp @@ -1254,9 +1254,10 @@ var AttrType: TIDLDefinition; begin if aParent=nil then ; - if Attr.AttributeType=nil then + if (Attr.AttributeType=nil) then begin - writeln('Note: skipping field "'+Attr.Name+'" without type at '+GetDefPos(Attr)); + if not (aoStringifier in Attr.Options) then + writeln('Note: skipping field "'+Attr.Name+'" without type at '+GetDefPos(Attr)); exit; end; PropName:=GetName(Attr);