paweld/fpc
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/fpc/source.git synced 2025-04-19 23:19:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

* fcl-db: limit blob memory usage when using unidirectional datasets. Patch by Laco. Issue #24509

Browse Source 
git-svn-id: trunk@27830 -
This commit is contained in:
reiniero 2014-05-30 11:07:53 +00:00
parent 19c310f5d3
commit e8a3715afd
1 changed files with 15 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
packages/fcl-db/src/base/bufdataset.pas
View File

@ -2066,7 +2066,7 @@ end;
function TCustomBufDataset.LoadBuffer(Buffer : TRecordBuffer): TGetResult;
var NullMask : pbyte;
x : longint;
i : longint;
CreateBlobField : boolean;
BufBlob : PBufBlobField;
@ -2081,21 +2081,30 @@ begin
Exit;
end;
if IsUniDirectional then
begin
// release blob buffers before new record is loaded
// in order to save memory
for i := 0 to high(FBlobBuffers) do
FreeBlobBuffer(FBlobBuffers[i]);
SetLength(FBlobBuffers, 0);
end;
NullMask := pointer(buffer);
fillchar(Nullmask^,FNullmaskSize,0);
inc(buffer,FNullmaskSize);
for x := 0 to FieldDefs.Count-1 do
for i := 0 to FieldDefs.Count-1 do
begin
if not LoadField(FieldDefs[x],buffer,CreateBlobField) then
SetFieldIsNull(NullMask,x)
if not LoadField(FieldDefs[i], buffer, CreateBlobField) then
SetFieldIsNull(NullMask,i)
else if CreateBlobField then
begin
BufBlob := PBufBlobField(Buffer);
BufBlob^.BlobBuffer := GetNewBlobBuffer;
LoadBlobIntoBuffer(FieldDefs[x],BufBlob);
LoadBlobIntoBuffer(FieldDefs[i], BufBlob);
end;
inc(buffer,GetFieldSize(FieldDefs[x]));
inc(buffer, GetFieldSize(FieldDefs[i]));
end;
Result := grOK;
end;