paweld/fpc
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/fpc/source.git synced 2025-04-20 07:39:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

* fix overflow checking for inc(cardinal,x) and inc(pointer,x)

Browse Source 
git-svn-id: trunk@593 -
This commit is contained in:
peter 2005-07-06 08:01:39 +00:00
parent 1c03cc0dc2
commit f2f968f48a
3 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.gitattributes vendored
View File

@ -6133,6 +6133,7 @@ tests/webtbs/tw4119.pp svneol=native#text/plain
tests/webtbs/tw4140.pp svneol=native#text/plain
tests/webtbs/tw4150.pp svneol=native#text/plain
tests/webtbs/tw4151.pp svneol=native#text/plain
tests/webtbs/tw4152.pp svneol=native#text/plain
tests/webtbs/ub1873.pp svneol=native#text/plain
tests/webtbs/ub1883.pp svneol=native#text/plain
tests/webtbs/uw0555.pp svneol=native#text/plain

11
compiler/ninl.pas
View File

@ -2175,8 +2175,17 @@ implementation
{ no, create constant 1 }
hpp := cordconstnode.create(1,tcallparanode(left).left.resulttype,false);
end;
if (tcallparanode(left).left.resulttype.def.deftype=pointerdef) then
resulttypepass(hpp);
{$ifndef cpu64bit}
if not((hpp.resulttype.def.deftype=orddef) and
(torddef(hpp.resulttype.def).typ<>u32bit)) then
{$endif cpu64bit}
inserttypeconv_internal(hpp,sinttype);
{ No overflow check for pointer operations, because inc(pointer,-1) will always
trigger an overflow. For uint32 it works because then the operation is done
in 64bit }
if (tcallparanode(left).left.resulttype.def.deftype=pointerdef) then
exclude(aktlocalswitches,cs_check_overflow);
{ make sure we don't call functions part of the left node twice (and generally }
{ optimize the code generation) }
if node_complexity(tcallparanode(left).left) > 1 then

18
tests/webtbs/tw4152.pp Executable file
View File

@ -0,0 +1,18 @@
{ Source provided for Free Pascal Bug Report 4152 }
{ Submitted by "C Western" on 2005-07-03 }
{ e-mail: mftq75@dsl.pipex.com }
{$R+}{$Q+}
var
p:^Byte;
c:Byte;
d:Integer;
v : cardinal;
begin
v:=100;
inc(v,-1);
p:=@c;
Inc(p,-1); // Gives compile time error: range check error while evaluating constants
d:=2;
Inc(d,-1);
Inc(p,d); // This fails at run time
end.