paweld/fpc
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/fpc/source.git synced 2025-09-14 01:29:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

* Raise an exception when a query is executed with a parameter set to null when this is not allowed + test

Browse Source 
git-svn-id: trunk@13969 -
This commit is contained in:
joost 2009-10-29 21:18:54 +00:00
parent 6264145aa6
commit f546247481
2 changed files with 23 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/fcl-db/src/sqldb/interbase/ibconnection.pp
View File

@ -779,8 +779,9 @@ begin
VSQLVar := @in_sqlda^.SQLvar[SQLVarNr];
if AParams[ParNr].IsNull then
begin
If Assigned(VSQLVar^.SQLInd) then
VSQLVar^.SQLInd^ := -1;
If not Assigned(VSQLVar^.SQLInd) then
DatabaseErrorFmt(SNullParamNotAllowed,[AParams[ParNr].Name],Self);
VSQLVar^.SQLInd^ := -1;
end
else
begin

20
packages/fcl-db/tests/testfieldtypes.pas
View File

@ -48,6 +48,7 @@ type
procedure TestSetBlobAsMemoParam;
procedure TestSetBlobAsBlobParam;
procedure TestSetBlobAsStringParam;
procedure TestNonNullableParams;
procedure TestGetIndexDefs;
procedure TestDblQuoteEscComments;
procedure TestpfInUpdateFlag; // bug 7565
@ -929,6 +930,25 @@ begin
TSQLDBConnector(DBConnector).Connection.ExecuteDirect('update FPDEV set name=''nothing'' where (1=0)');
end;
procedure TTestFieldTypes.TestNonNullableParams;
var ASQLQuery : TSQLQuery;
begin
// Check for an exception when a null value is stored into a non-nullable
// field using a parameter
// There was a bug in IBConnection so that in this case the last used value
// for the parameter was used.
// To make sure that any changes are cancelled in the case the test fails
TSQLDBConnector(DBConnector).GetNDataset(true,5);
ASQLQuery := TSQLDBConnector(DBConnector).Query;
ASQLQuery.SQL.text := 'update fpdev set ID=:ID1 where id = :ID2';
ASQLQuery.Params[0].Clear;
ASQLQuery.Params[1].AsInteger := 1;
AssertTrue(ASQLQuery.Params[0].IsNull);
AssertException(EDatabaseError, @ASQLQuery.ExecSQL);
end;
procedure TTestFieldTypes.TestStringLargerThen8192;
var