paweld/fpc
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/fpc/source.git synced 2025-08-12 13:49:39 +02:00
Code Issues Packages Projects Releases Wiki Activity

* x86: Reference count fix in CMP/Jcc and TEST/Jcc redirect optimisations

Browse Source
This commit is contained in:
J. Gareth "Curious Kit" Moreton 2022-07-30 18:18:10 +01:00 committed by FPK
parent 8ba76f7d0a
commit f5d76c5593
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
compiler/x86/aoptx86.pas
View File

@ -4949,14 +4949,11 @@ unit aoptx86;
if condition_in(taicpu(hp1).condition, taicpu(hp1_dist).condition) then if condition_in(taicpu(hp1).condition, taicpu(hp1_dist).condition) then
begin begin
{ Any registers used here will already be allocated } { Any registers used here will already be allocated }
if Assigned(JumpLabel_dist) then
JumpLabel_dist.IncRefs;
if Assigned(JumpLabel) then if Assigned(JumpLabel) then
JumpLabel.DecRefs; JumpLabel.DecRefs;
DebugMsg(SPeepholeOptimization + 'TEST/Jcc/@Lbl/TEST/Jcc -> TEST/Jcc, redirecting first jump', hp1); DebugMsg(SPeepholeOptimization + 'TEST/Jcc/@Lbl/TEST/Jcc -> TEST/Jcc, redirecting first jump', hp1);
taicpu(hp1).loadref(0, taicpu(hp1_dist).oper[0]^.ref^); taicpu(hp1).loadref(0, taicpu(hp1_dist).oper[0]^.ref^); { This also increases the reference count }
Result := True; Result := True;
Exit; Exit;
end; end;
@ -6709,14 +6706,11 @@ unit aoptx86;
if IsCmpSubset(taicpu(p_jump).condition, taicpu(hp1_dist).condition) then if IsCmpSubset(taicpu(p_jump).condition, taicpu(hp1_dist).condition) then
begin begin
{ Any registers used here will already be allocated } { Any registers used here will already be allocated }
if Assigned(JumpLabel_dist) then
JumpLabel_dist.IncRefs;
if Assigned(JumpLabel) then if Assigned(JumpLabel) then
JumpLabel.DecRefs; JumpLabel.DecRefs;
DebugMsg(SPeepholeOptimization + 'CMP/Jcc/@Lbl/CMP/Jcc -> CMP/Jcc, redirecting first jump', p_jump); DebugMsg(SPeepholeOptimization + 'CMP/Jcc/@Lbl/CMP/Jcc -> CMP/Jcc, redirecting first jump', p_jump);
taicpu(p_jump).loadref(0, taicpu(hp1_dist).oper[0]^.ref^); taicpu(p_jump).loadref(0, taicpu(hp1_dist).oper[0]^.ref^); { This also increases the reference count }
Result := True; Result := True;
{ Don't exit yet. Since p and p_jump haven't actually been { Don't exit yet. Since p and p_jump haven't actually been
removed, we can check for more on this iteration } removed, we can check for more on this iteration }