mirror of
https://gitlab.com/freepascal.org/fpc/source.git
synced 2025-04-06 18:47:56 +02:00
945fd4fcf5
parameter instead of immediately doing it in the constructor of the call node, and then only create it if we actually need it. It was previously created in the call node constructor because it needs to be done before pass_1 (which is where it is actually used) due to pass_1 possibly being performed in the context of inlining (and then a wrong self parameter may be found, or none at all), and it was done unconditionally because at that point we don't know yet whether or not a self parameter will be necessary (as we haven't resolved the overloads/procdef yet). The problem with this is that if we use the parentfpstruct way of handling accesses to outer scope locals/parameters, we need to know all locals/ parameters that will be accessed from nested routines after typecheckpass, otherwise we get crashes. The problem was that if a call to an RTL routine was generated by the compiler in a routine nested inside a method during pass_1, and this nested routine itself did not access self of the method (so self was not added to its parentfpstruct during the typecheckpass), then the unconditional reference to self when creating the call caused a compiler crash (introduced in r30908) git-svn-id: trunk@31197 -
32 lines
331 B
ObjectPascal
32 lines
331 B
ObjectPascal
{$mode delphi}
|
|
|
|
program tnestcallpass1;
|
|
|
|
type
|
|
tncp1_c = class
|
|
procedure test;
|
|
end;
|
|
|
|
|
|
procedure tncp1_c.test;
|
|
|
|
var
|
|
l: longint;
|
|
|
|
function nest(const s: unicodestring): longint;
|
|
begin
|
|
l:=5;
|
|
if length(s)=5 then
|
|
nest:=l
|
|
else
|
|
nest:=3;
|
|
end;
|
|
|
|
begin
|
|
nest('abcdef');
|
|
end;
|
|
|
|
|
|
begin
|
|
end.
|