mirror of
https://gitlab.com/freepascal.org/fpc/source.git
synced 2025-04-05 10:38:14 +02:00
d1acb76df8
if expr1 has sideeffects. This can't be done safely even in case of
short boolean evaluation, because expr1 may return the inverse the
second time its called (and "0 or 1" is not the same as "0", and
neither is "1 and 0"), based on comment by Michael Karcher
* perform a full string compare when comparing stringconstnodes
before the string constant labels have been generated (patch by
Michael Karcher, mantis #21255)
git-svn-id: trunk@20485 -
113 lines
2.3 KiB
ObjectPascal
113 lines
2.3 KiB
ObjectPascal
Program fpcbugcheck;
|
|
|
|
{$mode macpas} { for | }
|
|
|
|
Var
|
|
FrobCounter : Integer;
|
|
|
|
const
|
|
ok: boolean = true;
|
|
|
|
Function Frob : Boolean;
|
|
begin
|
|
Inc(FrobCounter);
|
|
Frob := False;
|
|
end;
|
|
|
|
{
|
|
This program tests whether "Frob or Frob" is contracted to a single
|
|
"Frob" call, in different contexts:
|
|
- without shortcut evaluation (no contraction allowed)
|
|
- with shortcut evaluation enabled
|
|
- using the MacPas "|" instead of "or"
|
|
It prints the number of Frob calls for each variant.
|
|
}
|
|
|
|
{
|
|
The second test this program does is related to the first one,
|
|
it exercises a bug in fpc deeming all compares with string constants
|
|
to be equal at the stage of compilation the elision of duplicate expression
|
|
in bools is performed.
|
|
|
|
This bug has been active since the introduction of the boolean shortcut
|
|
optimization (r14714), but as that optimization only applies to the
|
|
explicit shortcut form (in form of the MacPas operators), that bug
|
|
didn't show.
|
|
}
|
|
|
|
{$B+}
|
|
Procedure CountFrobsBoolFull;
|
|
begin
|
|
FrobCounter := 0;
|
|
if Frob or Frob then
|
|
begin
|
|
WriteLn('Complete: Huh');
|
|
ok:=false;
|
|
end
|
|
else
|
|
begin
|
|
WriteLn('Complete: Frobbed ', FrobCounter, ' times');
|
|
if FrobCounter<>2 then
|
|
ok:=false;
|
|
end;
|
|
end;
|
|
|
|
{$B-}
|
|
Procedure CountFrobsBoolShort;
|
|
begin
|
|
FrobCounter := 0;
|
|
if Frob or Frob then
|
|
begin
|
|
WriteLn('Short: Huh');
|
|
ok:=false;
|
|
end
|
|
else
|
|
begin
|
|
WriteLn('Short: Frobbed ', FrobCounter, ' times');
|
|
if FrobCounter<>2 then
|
|
ok:=false;
|
|
end;
|
|
end;
|
|
|
|
Procedure CountFrobsMac;
|
|
begin
|
|
FrobCounter := 0;
|
|
if Frob | Frob then
|
|
begin
|
|
WriteLn('Mac: Huh');
|
|
ok:=false;
|
|
end
|
|
else
|
|
begin
|
|
WriteLn('Mac: Frobbed ', FrobCounter, ' times');
|
|
if FrobCounter<>2 then
|
|
ok:=false;
|
|
end;
|
|
end;
|
|
|
|
var
|
|
test: String;
|
|
{$B-}
|
|
begin
|
|
ok:=true;
|
|
{ test conditions for application of boolean contraction }
|
|
CountFrobsBoolFull;
|
|
CountFrobsBoolShort;
|
|
CountFrobsMac;
|
|
{ test for faulty boolean contraction }
|
|
test:='b';
|
|
if (test='a') | (test='b') then
|
|
test := 'OK'
|
|
else
|
|
ok:=false;
|
|
if test <> 'OK' then WriteLn('Mac: fpc failed!');
|
|
test:='b';
|
|
if (test='a') or (test='b') then
|
|
test := 'OK'
|
|
else
|
|
ok:=false;
|
|
if test <> 'OK' then WriteLn('Short: fpc failed!');
|
|
if not ok then
|
|
halt(1);
|
|
end.
|