Misc packages: Adjust to changes in Laz/main (deprecated OffsetRect), less hints and warnings

git-svn-id: https://svn.code.sf.net/p/lazarus-ccr/svn@8838 8e941d3f-bd1b-0410-a28a-d453659cc2b4
2023-06-15 23:33:46 +00:00 · 2023-06-15 23:33:46 +00:00 · 7940c5f9df
commit 7940c5f9df
parent d060e53a49
36 changed files with 65 additions and 51 deletions
--- a/components/callite/source/calendarlite.pas
+++ b/components/callite/source/calendarlite.pas
@ -1363,7 +1363,6 @@ var
  cell: TSize;
  Rm, Ry: TRect;
  sm: TCalSelMode;
-  newDate: TDate;
 begin
  sm := FOwner.SelMode(Shift);
  cell := GetCellAt(APoint);
--- a/components/exctrls/source/excheckctrls.pas
+++ b/components/exctrls/source/excheckctrls.pas
@ -389,7 +389,6 @@ type
    property ButtonCount: Integer read GetButtonCount;
    property Buttons[AIndex: Integer]: TRadioButtonEx read GetButtons;
    property ItemEnabled;
-  published
    constructor Create(AOwner: TComponent); override;
    destructor Destroy; override;
  end;
--- a/components/exctrls/source/exshape.pas
+++ b/components/exctrls/source/exshape.pas
@ -5,7 +5,7 @@ unit ExShape;
 interface

 uses
-  LCLVersion, Types, Graphics, Classes, SysUtils, ExtCtrls;
+  LCLIntf, LCLType, LCLVersion, Types, Graphics, Classes, SysUtils, ExtCtrls;

 type
  {$IF LCL_FullVersion < 2020000}
@ -73,9 +73,6 @@ type

 implementation

-uses
-  LCLIntf, LCLType;
-
 { TShapeText }

 constructor TShapeText.Create(AShape: TShape);
--- a/components/fpspreadsheet/source/visual/fpspreadsheetgrid.pas
+++ b/components/fpspreadsheet/source/visual/fpspreadsheetgrid.pas
@ -27,7 +27,7 @@ unit fpspreadsheetgrid;
 interface

 uses
-  Classes, SysUtils, LMessages, LResources, LCLVersion, Variants,
+  LCLType, LCLIntf, LCLVersion, Classes, SysUtils, LMessages, LResources, Variants,
  Forms, Controls, Graphics, Dialogs, Grids, StdCtrls, ExtCtrls,
  fpstypes, fpspreadsheet, fpspreadsheetctrls;

@ -911,7 +911,7 @@ var
 implementation

 uses
-  Types, LCLType, LCLIntf, LCLProc, LazUTF8, Math, StrUtils,
+  Types, LazUTF8, Math, StrUtils,
  fpCanvas, {%H-}fpsPatches, fpsStrings, fpsUtils, fpsVisualUtils, fpsHTMLUtils,
  fpsImages, fpsNumFormat, fpsExprParser;

--- a/components/industrialstuff/industrial.lpk
+++ b/components/industrialstuff/industrial.lpk
@ -24,6 +24,11 @@
          <GenerateDebugInfo Value="False"/>
        </Debugging>
      </Linking>
+      <Other>
+        <CompilerMessages>
+          <IgnoredMessages idx6058="True"/>
+        </CompilerMessages>
+      </Other>
    </CompilerOptions>
    <Description Value="Industrial-themed components and gauges:
 - LED indicators
@ -102,7 +107,7 @@
      </Item15>
      <Item16>
        <Filename Value="source\indlcddisplay_editor.pas"/>
-        <UnitName Value="indlcddisplay_editor"/>
+        <UnitName Value="indLCDDisplay_Editor"/>
      </Item16>
      <Item17>
        <Filename Value="source\indlcddisplay_editorform.pas"/>
--- a/components/industrialstuff/source/indlcddisplay.pas
+++ b/components/industrialstuff/source/indlcddisplay.pas
@ -622,7 +622,7 @@ begin
  Writer.WriteListEnd;
 end;

-
+(*
 { TLCDDisplayStrings }

 type
@ -632,7 +632,7 @@ type
  public
    property OnChange: TNotifyEvent read FOnChange write FOnChange;
  end;
-
+*)

 { TLCDDisplay}

--- a/components/industrialstuff/source/indlcddisplay_editorform.pas
+++ b/components/industrialstuff/source/indlcddisplay_editorform.pas
@ -5,8 +5,8 @@ unit indLCDDisplay_EditorForm;
 interface

 uses
-  Classes, SysUtils, Forms, Controls, Graphics, Dialogs, StdCtrls,
-  Grids, ExtCtrls, Buttons, indLCDDisplay, Types;
+  LCLIntf, Classes, SysUtils, Forms, Controls, Graphics, Dialogs, StdCtrls,
+  Grids, ExtCtrls, Buttons, indLCDDisplay;

 type

--- a/components/industrialstuff/source/switches.pas
+++ b/components/industrialstuff/source/switches.pas
@ -18,7 +18,7 @@ unit switches;
 interface

 uses
-  Graphics, Classes, SysUtils, Types, Controls, ExtCtrls;
+  LCLIntf, LCLType, Graphics, Classes, SysUtils, Types, Controls, ExtCtrls;

 type
  TSwitchBorderStyle = (bsNone, bsThin, bsThick, bsThin3D, bsThick3D);
@ -148,7 +148,7 @@ type
 implementation

 uses
-  LCLIntf, LCLType, Math;
+  Math;

 function TintedColor(AColor: TColor; ADelta: Integer): TColor;
 var
--- a/components/jvcllaz/packages/jvcustomlazr.lpk
+++ b/components/jvcllaz/packages/jvcustomlazr.lpk
@ -11,6 +11,11 @@
        <OtherUnitFiles Value="..\run\JvCustomControls"/>
        <UnitOutputDirectory Value="..\lib\$(TargetCPU)-$(TargetOS)\run\JvCustom"/>
      </SearchPaths>
+      <Other>
+        <CompilerMessages>
+          <IgnoredMessages idx6058="True"/>
+        </CompilerMessages>
+      </Other>
    </CompilerOptions>
    <Description Value="Custom components of the JVCL library (https://sourceforge.net/projects/jvcl/) (runtime code):
 TimeLine, OutlookBar, Thumbnail viewer, ImageViewer, ImageListViewer, OwnerDrawViewer"/>
@ -63,7 +68,7 @@ TimeLine, OutlookBar, Thumbnail viewer, ImageViewer, ImageListViewer, OwnerDrawV
      </Item11>
      <Item12>
        <Filename Value="..\run\JvCustomControls\jvvalidateedit.pas"/>
-        <UnitName Value="jvvalidateedit"/>
+        <UnitName Value="JvValidateEdit"/>
      </Item12>
      <Item13>
        <Filename Value="..\run\JvCustomControls\jvgammapanel.pas"/>
--- a/components/jvcllaz/packages/jvdblazr.lpk
+++ b/components/jvcllaz/packages/jvdblazr.lpk
@ -11,6 +11,11 @@
        <OtherUnitFiles Value="..\run\JvDB"/>
        <UnitOutputDirectory Value="..\lib\$(TargetCPU)-$(TargetOS)\run\JvDB"/>
      </SearchPaths>
+      <Other>
+        <CompilerMessages>
+          <IgnoredMessages idx6058="True"/>
+        </CompilerMessages>
+      </Other>
    </CompilerOptions>
    <Description Value="Database controls of the JVCL library (https://sourceforge.net/projects/jvcl/) (runtime code):
 - Search edit, Calc edit
--- a/components/jvcllaz/packages/jvpascalinterpreterr.lpk
+++ b/components/jvcllaz/packages/jvpascalinterpreterr.lpk
@ -11,6 +11,11 @@
        <OtherUnitFiles Value="..\run\JvPascalInterpreter"/>
        <UnitOutputDirectory Value="..\lib\$(TargetCPU)-$(TargetOS)\run\JvPascalInterpreter"/>
      </SearchPaths>
+      <Other>
+        <CompilerMessages>
+          <IgnoredMessages idx6058="True"/>
+        </CompilerMessages>
+      </Other>
    </CompilerOptions>
    <Description Value="Pascal scripting engine of the JVCL library (https://sourceforge.net/projects/jvcl/) (runtime code)
 "/>
--- a/components/jvcllaz/run/JvCmp/jvprofilerform.pas
+++ b/components/jvcllaz/run/JvCmp/jvprofilerform.pas
@ -204,6 +204,7 @@ function GetComputerName : string;
 var
  len : cardinal;
 begin
+  Result := '';
  len := MAX_COMPUTERNAME_LENGTH + 1;
  SetLength(result, len);
  if Windows.GetComputerName(PChar(result), len) then begin
--- a/components/jvcllaz/run/JvCore/jvjvclutils.pas
+++ b/components/jvcllaz/run/JvCore/jvjvclutils.pas
@ -37,8 +37,8 @@ uses
 {$IFDEF WINDOWS}
  Windows,          // before Types!
 {$ENDIF}
+  LCLType, LCLVersion, LMessages,
  Classes, Graphics, Controls, ImgList, Menus, Forms, Types,
-  LCLType, LCLProc, LCLVersion, LMessages,
  JvTypes;

 (******************** NOT CONVERTED
--- a/components/jvcllaz/run/JvCtrls/jvhtcontrols.pas
+++ b/components/jvcllaz/run/JvCtrls/jvhtcontrols.pas
@ -107,8 +107,8 @@ unit JvHtControls;
 interface

 uses
-  LCLType, {LMessages,} Types,
-  SysUtils, Classes, Graphics, {Contnrs,} Controls, StdCtrls, Dialogs,
+  LCLIntf, LCLType, {LMessages,} Types,
+  SysUtils, Classes, Graphics, {Contnrs,} Controls, StdCtrls, Dialogs, Forms,
  JvJVCLUtils {JvDataSourceIntf, JvExStdCtrls} ;

 const
@ -429,9 +429,6 @@ function PrepareText(const A: string): string; deprecated;

 implementation

-uses
-  LCLProc, LCLIntf, Forms;
-
 const
  cMAILTO = 'MAILTO:';
  cURLTYPE = '://';
--- a/components/jvcllaz/run/JvCustomControls/jvcustomitemviewer.pas
+++ b/components/jvcllaz/run/JvCustomControls/jvcustomitemviewer.pas
@ -37,7 +37,7 @@ unit JvCustomItemViewer;
 interface

 uses
-  LMessages, LCLVersion,
+  LCLIntf, LCLVersion, LMessages,
  Classes, Graphics, Contnrs, Controls, Forms, ComCtrls,
  ExtCtrls, JvConsts, Types, LCLType;

@ -369,7 +369,7 @@ function CenterRect(InnerRect, OuterRect: TRect): TRect;
 implementation

 uses
-  SysUtils, Math, Themes, LCLIntf,
+  SysUtils, Math, Themes,
  JvJCLUtils;
 //  JvJVCLUtils, ;

--- a/components/jvcllaz/run/JvCustomControls/jvimagelistviewer.pas
+++ b/components/jvcllaz/run/JvCustomControls/jvimagelistviewer.pas
@ -29,7 +29,7 @@ interface
 {$MODE OBJFPC}{$H+}

 uses
-  LCLVersion,
+  LCLType, LCLIntf, LCLVersion,
  SysUtils, Types, Classes, Controls, Graphics, ComCtrls, ImgList,
  JvCustomItemViewer;

@ -158,7 +158,6 @@ type
 implementation

 uses
-  LCLType, LCLProc, LCLIntf,
  Math,
  JvJCLUtils, JvJVCLUtils;

--- a/components/jvcllaz/run/JvCustomControls/jvtmtimeline.pas
+++ b/components/jvcllaz/run/JvCustomControls/jvtmtimeline.pas
@ -1294,6 +1294,7 @@ var
  I: Integer;
  UTF8Value: UTF8String = '';
 begin
+  Result := '';
  I := ReadInt(Stream);
  SetLength(Result, I);
  if I > 0 then
--- a/components/jvcllaz/run/JvCustomControls/jvvalidateedit.pas
+++ b/components/jvcllaz/run/JvCustomControls/jvvalidateedit.pas
@ -1025,6 +1025,7 @@ var
  I: Integer;
  L: Integer;
 begin
+  Result := '';
  SetLength(Result, Length(ParseString));
  L := 0;
  for I := 1 to Length(ParseString) do
--- a/components/jvcllaz/run/JvDB/jvdblookup.pas
+++ b/components/jvcllaz/run/JvDB/jvdblookup.pas
@ -39,7 +39,7 @@ unit JvDBLookup;
 interface

 uses
-  LCLType, LCLIntf, LCLProc, LMessages, LCLVersion,
+  LCLType, LCLIntf, LMessages, LCLVersion,
  Variants, Classes, Graphics, Controls, Forms, DB, DBCtrls, Themes,
  JvThemes, JvDBUtils;

--- a/components/jvcllaz/run/JvDB/jvdbtreeview.pas
+++ b/components/jvcllaz/run/JvDB/jvdbtreeview.pas
@ -1551,7 +1551,7 @@ end;
 procedure TJvCustomDBTreeView.CreateWnd;
 var
  Node: TTreeNode;
-  temp: string;
+  temp: string = '';
  strLength: Integer = 0;
  HasChildren: Byte = 0;
 begin
--- a/components/jvcllaz/run/JvMM/jvid3v2base.pas
+++ b/components/jvcllaz/run/JvMM/jvid3v2base.pas
@ -1822,7 +1822,7 @@ var
  //P, ContentPtr: PWideChar;
  //S: WideString;
  P, ContentPtr: PChar;
-  S: String;
+  S: String = '';
 begin
  //ContentPtr := PWideChar(Content);
  ContentPtr := PChar(Content);
@ -1869,7 +1869,7 @@ procedure ExtractStrings(Separator: WideChar; const Content: String;
 var
  EOS: Boolean;
  Tail: PChar;
-  S: String;
+  S: String = '';
  ContentPtr: PChar;
 {
  Tail: PWideChar;
@ -5922,7 +5922,7 @@ const
  CMinimalHeaderSize: array [Boolean] of Byte = (6, 10);
 var
  Frame: TJvID3Frame;
-  FrameIDStr: AnsiString;
+  FrameIDStr: AnsiString = '';
  FrameID: TJvID3FrameID;

  LFrameIDLength: Byte;
@ -8280,6 +8280,8 @@ var
  P: PChar;
  S: string;
 begin
+  Result := '';
+
  LCount := GetCount;
  Size := 0;
  SepLen := Length(Separator);
--- a/components/jvcllaz/run/JvMM/jvid3v2types.pas
+++ b/components/jvcllaz/run/JvMM/jvid3v2types.pas
@ -27,7 +27,7 @@ Known Issues:

 unit JvId3v2Types;

-
+{$WARN 6058 off : Call to subroutine "$1" marked as inline is not inlined}
 interface

 uses
--- a/components/jvcllaz/run/JvNet/jvstrtohtml.pas
+++ b/components/jvcllaz/run/JvNet/jvstrtohtml.pas
@ -488,7 +488,7 @@ begin
  SetLength(Result, CurrPos-1);
 end;

-{<<<<<<<<<<<<<< NOT CONVERTED
+(*<<<<<<<<<<<<<< NOT CONVERTED
 function CharToHtml(Ch: Char): string;
 var
  I: Integer;
@ -513,7 +513,7 @@ begin
  end;
  Result := Ch;
 end;
->>>>>>>>>>>>>>>>>>> }
+>>>>>>>>>>>>>>>>>>> *)

 end.

--- a/components/jvcllaz/run/JvPascalInterpreter/JvInterpreter.pas
+++ b/components/jvcllaz/run/JvPascalInterpreter/JvInterpreter.pas
@ -193,7 +193,7 @@ end.
 interface

 uses
-  LCLType, LCLIntf, LCLProc, dynlibs,
+  LCLType, LCLIntf, dynlibs,
  SysUtils, Classes, Variants,
  JvJCLUtils, JvInterpreterParser;

--- a/components/jvcllaz/run/JvRuntimeDesign/jvdesignclip.pas
+++ b/components/jvcllaz/run/JvRuntimeDesign/jvdesignclip.pas
@ -5,7 +5,7 @@ unit JvDesignClip;
 interface

 uses
-  LCLProc, LCLType, LResources, LCLIntf, Classes;
+  LCLType, LResources, LCLIntf, Classes;

 type
  TJvDesignComponentClipboard = class(TObject)
--- a/components/jvcllaz/run/JvRuntimeDesign/jvdesignimp.pas
+++ b/components/jvcllaz/run/JvRuntimeDesign/jvdesignimp.pas
@ -5,7 +5,7 @@ unit JvDesignImp;
 interface

 uses
-  LCLProc, LCLType, LResources, LCLIntf, LMessages,
+  LCLType, LCLIntf, LMessages, LResources,
  SysUtils, Types, Classes, Controls, Graphics, Forms, ExtCtrls, Contnrs,
  JvDesignUtils, JvDesignSurface;

--- a/components/jvcllaz/run/JvRuntimeDesign/jvdesignsurface.pas
+++ b/components/jvcllaz/run/JvRuntimeDesign/jvdesignsurface.pas
@ -40,7 +40,7 @@ interface

 uses
  Classes, SysUtils,
-  LCLProc, LCLType, LResources, LCLIntf, LMessages,
+  LCLType, LResources, LCLIntf, LMessages,
  Forms, Controls, Graphics, Dialogs, ExtCtrls;

 type
@ -543,6 +543,7 @@ function TJvDesignSurface.GetSelected: TJvDesignObjectArray;
 var
  I: Integer;
 begin
+  Result := nil;
  SetLength(Result, Count);
  for I := 0 to Count - 1 do
    Result[I] := Selector.Selection[I];
--- a/components/jvcllaz/run/JvRuntimeDesign/jvdesignutils.pas
+++ b/components/jvcllaz/run/JvRuntimeDesign/jvdesignutils.pas
@ -6,7 +6,7 @@ unit JvDesignUtils;

 interface
 uses
-  SysUtils, LCLProc, LCLType, LResources, LCLIntf, LMessages,
+  SysUtils, LCLType, LResources, LCLIntf, LMessages,
  Classes, Controls, Graphics, Forms, dialogs;

 type
--- a/components/jvcllaz/run/JvStdCtrls/jvbutton.pas
+++ b/components/jvcllaz/run/JvStdCtrls/jvbutton.pas
@ -34,8 +34,7 @@ unit JvButton;
 interface

 uses
-  LMessages,
-  Classes, Types, Controls, Graphics, Menus,
+  LCLIntf, LCLType, LMessages, SysUtils, Classes, Types, Controls, Graphics, Menus,
  JvComponent, JvConsts, JvTypes;

 type
@ -176,7 +175,7 @@ type
 implementation

 uses
-  Forms, JvJVCLUtils, LCLIntf, LCLType, SysUtils;
+  Forms, JvJVCLUtils;

 (******************** NOT CONVERTED
 const
--- a/components/jvcllaz/run/JvValidators/jverrorindicator.pas
+++ b/components/jvcllaz/run/JvValidators/jverrorindicator.pas
@ -217,7 +217,6 @@ implementation

 uses
  //CommCtrl,
-  LCLProc,
  SysUtils,
  JvResources, JvJVCLUtils;

--- a/components/jvcllaz/run/JvWizard/jvwizard.pas
+++ b/components/jvcllaz/run/JvWizard/jvwizard.pas
@ -336,9 +336,8 @@ unit JvWizard;
 interface

 uses
-  SysUtils, Classes,
-  Controls, Forms, Graphics, Buttons, ImgList, Types,
-  LMessages, LCLType, LCLIntf, LCLVersion,
+  LCLType, LCLIntf, LCLVersion, LMessages,
+  SysUtils, Classes, Controls, Forms, Graphics, Buttons, ImgList, Types,
  JvWizardCommon, JvComponent;

 type
--- a/components/jvcllaz/run/JvWizard/jvwizardcommon.pas
+++ b/components/jvcllaz/run/JvWizard/jvwizardcommon.pas
@ -43,7 +43,7 @@ unit JvWizardCommon;
 interface

 uses
-  Controls, Graphics, Types, Classes, SysUtils, LCLIntf, LCLType,
+  LCLIntf, LCLType, SysUtils, Controls, Graphics, Types, Classes,
  JvResources;

 type
--- a/components/jvcllaz/run/JvXPCtrls/jvxpbar.pas
+++ b/components/jvcllaz/run/JvXPCtrls/jvxpbar.pas
@ -51,7 +51,7 @@ unit JvXPBar;
 interface

 uses
-  LCLIntf, LCLProc, LCLType, LMessages, LResources,
+  LCLIntf, LCLType, LCLProc, LMessages, LResources,
  SysUtils, Classes, Controls, Graphics, ExtCtrls, Forms, ImgList, ActnList,
  JvXPCore, JvXPCoreUtils;

--- a/components/jvcllaz/run/JvXPCtrls/jvxpbuttons.pas
+++ b/components/jvcllaz/run/JvXPCtrls/jvxpbuttons.pas
@ -31,7 +31,7 @@ unit JvXPButtons;
 interface

 uses
-  Classes, TypInfo, LCLIntf, LCLType, LCLProc, LMessages, Types, Graphics,
+  Classes, TypInfo, LCLIntf, LCLType, LMessages, Types, Graphics,
  Controls, Forms, ActnList, ImgList, Menus,
  JvXPCore, JvXPCoreUtils;

--- a/components/jvcllaz/run/JvXPCtrls/jvxpcheckctrls.pas
+++ b/components/jvcllaz/run/JvXPCtrls/jvxpcheckctrls.pas
@ -33,7 +33,7 @@ unit JvXPCheckCtrls;
 interface

 uses
-  Classes, LCLIntf, LCLProc, LCLType, LResources, Graphics, Controls, StdCtrls,
+  Classes, LCLIntf, LCLType, LResources, Graphics, Controls, StdCtrls,
  JvXPCore, JvXPCoreUtils;

 type
--- a/components/jvcllaz/run/JvXPCtrls/jvxpcontainer.pas
+++ b/components/jvcllaz/run/JvXPCtrls/jvxpcontainer.pas
@ -33,7 +33,7 @@ unit JvXPContainer;
 interface

 uses
-  LCLIntf, LCLProc, LCLType,
+  LCLIntf, LCLType,
  Types, TypInfo, Classes, Controls, Graphics, ExtCtrls,
  JvXPCore, JvXPCoreUtils;