paweld/lazarus-ccr
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fpspreadsheet: Validate defined names.

Browse Source 
git-svn-id: https://svn.code.sf.net/p/lazarus-ccr/svn@9405 8e941d3f-bd1b-0410-a28a-d453659cc2b4
This commit is contained in:
wp_xxyyzz 2024-07-26 17:17:56 +00:00
parent 5d03b1ca0e
commit 7980b028b0
1 changed files with 37 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
components/fpspreadsheet/source/common/fpsclasses.pas
View File

@ -231,6 +231,7 @@ type
procedure CopyFrom(AItem: TsDefinedName);
function RangeAsString(AWorkbook: TsBasicWorkbook): String;
function RangeAsString_ODS(AWorkbook: TsBasicWorkbook): String;
class function ValidName(AName: String): Boolean;
property Name: String read FName;
property Range: TsCellRange3D read FRange write FRange;
end;
@ -1880,17 +1881,50 @@ begin
end;
end;
// https://www.ablebits.com/office-addins-blog/excel-named-range/
class function TsDefinedName.ValidName(AName: string): Boolean;
const
FORBIDDEN = ' .,;:';
var
i: Integer;
r, c: Cardinal;
begin
Result := false;
if AName = '' then
exit;
// Length max 255 characters
if Length(AName) > 255 then exit;
// Space and punctuation characters are forbidden
for i := 1 to Length(FORBIDDEN) do
if pos(FORBIDDEN[i], AName) > 0 then exit;
// Must begin with letter, underscore or backslash
if not (AName[1] in ['a'..'z', 'A'..'Z', '_', '\']) then exit;
// No cell reference
if ParseCellString(AName, r, c) then exit;
// Single letters 'r', 'R', 'c', 'C' forbidden
if (Length(AName) = 1) and (AName[1] in ['r', 'R', 'c', 'C']) then exit;
Result := true;
end;
{==============================================================================}
{ TsDefinedNames }
{==============================================================================}
{ Adds the named cell to the list and returns the list index. AName must be
unique; if not, the return value is -1. }
unique and valid; if not, the return value is -1. }
function TsDefinedNames.Add(AName: String; ASheetIndex: Integer; ARow, ACol: Cardinal): Integer;
var
item: TsDefinedName;
begin
if DuplicateName(AName) then
if DuplicateName(AName) or not TsDefinedName.ValidName(AName) then
Result := -1
else
begin
@ -1906,7 +1940,7 @@ function TsDefinedNames.Add(AName: String; ASheetIndex1, ASheetIndex2: Integer;
var
item: TsDefinedName;
begin
if DuplicateName(AName) then
if DuplicateName(AName) or not TsDefinedName.ValidName(AName) then
Result := -1
else
begin