Optimise string manipulation. Reduce calls to Copy().

git-svn-id: trunk@64527 -

components/chmhelp/lhelp/chmdataprovider.pas

@@ -84,7 +84,7 @@ begin
   Result := AURL;
   i := Pos('#', Result);
   if i > 0 then
-    Result := Copy(Result, 1, i-1);
+    SetLength(Result, i-1);
 end;
 
 function TIpChmDataProvider.GetChms: TChmFileList;

components/chmhelp/packages/idehelp/chmlangref.pas

@@ -7,7 +7,7 @@ interface
 uses
   Classes, SysUtils,
   Dialogs, LazHelpIntf, HelpIntfs,
-  FileUtil, LazFileUtils, LazUTF8,
+  FileUtil, LazFileUtils, LazStringUtils, LazUTF8,
   IDEHelpIntf, MacroIntf;
 
 const
@@ -199,7 +199,7 @@ begin
       for i := 0 to FRTLIndex.Count - 1 do
       begin
         s := FRTLIndex.Names[i];
-        if SameText(KeyWord, Copy(s, 1, Length(KeyWord))) and
+        if LazStartsText(KeyWord, s) and
           ((Length(s) = Length(KeyWord)) or (s[Length(KeyWord) + 1] = ' ')) then
         begin
           KeywordNode := THelpNode.CreateURL(Self,KeyWord,'rtl.chm://' + FRTLIndex.ValueFromIndex[i]);

components/filebrowser/frmfilebrowser.pas

@@ -346,7 +346,7 @@ begin
   if FRootDir = '' then
     FRootDir := PathDelim;
   if (FRootDir <> PathDelim) and (FRootDir[length(FRootDir)] = PathDelim) then
-    FRootDir := copy(FRootDir, 1, length(FRootDir) - 1);
+    SetLength(FRootDir, length(FRootDir)-1);
   { Find or Create the root node and add it to the Tree View. }
   RootNode := TV.Items.FindTopLvlNode(FRootDir + PathDelim);
   if RootNode = nil then

components/freetype/easylazfreetype.pas

@@ -549,7 +549,7 @@ var
   procedure WordBreak(ADropCount: Integer = 0);
   begin
     ARemains:= copy(AText, length(AText) - left + 1 + ADropCount, left);
-    AText := copy(AText, 1, length(AText) - left);
+    SetLength(AText, length(AText) - left);
   end;
 
 begin

components/freetype/lazfreetypefontcollection.pas

@@ -13,9 +13,9 @@ unit LazFreeTypeFontCollection;
 interface
 
 uses
-  Classes, SysUtils, Laz_AVL_Tree,
+  Classes, SysUtils, StrUtils, Laz_AVL_Tree,
   // LazUtils
-  LazUTF8,
+  LazStringUtils, LazUTF8,
   // FreeType
   EasyLazFreeType, LazFreeType, TTTypes;
 
@@ -946,7 +946,7 @@ begin
   begin
     with TCustomFontCollectionItem(enumerator.Current.Data) do
     begin
-      if copy(Filename, 1, length(AFolder)) = AFolder then
+      if StartsStr(AFolder, Filename) then
         toBeDeleted.Add(Filename);
     end;
   end;

components/ideintf/idewindowintf.pas

@@ -17,11 +17,11 @@ unit IDEWindowIntf;
 interface
 
 uses
-  Math, Classes, SysUtils,
+  Math, Classes, SysUtils, StrUtils,
   // LCL
   LCLIntf, LCLType, Forms, Controls,
   // LazUtils
-  LazConfigStorage, LazUTF8, LazMethodList, LazLoggerBase,
+  LazConfigStorage, LazUTF8, LazMethodList, LazLoggerBase, LazStringUtils,
   // BuildIntf
   IDEOptionsIntf;
 
@@ -580,11 +580,8 @@ var
   I: Integer;
 begin
   for I := 0 to FOptList.Count-1 do
-  if Copy(aFormID, 1, Length(FOptList[I])) = FOptList[I] then
-  begin
-    Result := TIDEWindowGlobalOption(FOptList.Objects[I]).CanSetVisibility;
-    Exit;
-  end;
+  if StartsStr(FOptList[I], aFormID) then
+    Exit(TIDEWindowGlobalOption(FOptList.Objects[I]).CanSetVisibility);
   Result := True;//default is true
 end;
 
@@ -1311,7 +1308,7 @@ begin
   if (i < 1) or (i = length(Result)) then
     exit;
   SubIndex := StrToInt(copy(Result, i+1, length(Result)));
-  Result := copy(Result, 1, i);
+  SetLength(Result, i);
 end;
 
 procedure TSimpleWindowLayout.SetForm(const AForm: TCustomForm);

components/ideintf/objectinspector.pp

@@ -30,7 +30,7 @@ uses
   // IMPORTANT: the object inspector is a tool and can be used in other programs
   //            too. Don't put Lazarus IDE specific things here.
   // RTL / FCL
-  Classes, SysUtils, Types, TypInfo, math,
+  Classes, SysUtils, Types, TypInfo, StrUtils, math,
   // LCL
   LCLPlatformDef, InterfaceBase, LCLType, LCLIntf, Forms, Buttons, Graphics,
   StdCtrls, Controls, ComCtrls, ExtCtrls, Menus, Dialogs, Themes, LMessages, ImgList,
@@ -38,7 +38,7 @@ uses
   {$IFnDEF UseOINormalCheckBox} CheckBoxThemed, {$ENDIF}
   TreeFilterEdit, ListFilterEdit,
   // LazUtils
-  GraphType, LazConfigStorage, LazLoggerBase, LazUTF8,
+  GraphType, LazConfigStorage, LazLoggerBase, LazStringUtils, LazUTF8,
   // IdeIntf
   IDEImagesIntf, IDEHelpIntf, ObjInspStrConsts,
   PropEdits, PropEditUtils, ComponentTreeView, OIFavoriteProperties,
@@ -2127,7 +2127,7 @@ begin
   a := 0;
   while a < FExpandedProperties.Count do
   begin
-    if copy(FExpandedProperties[a], 1, length(CurPath)) = CurPath then
+    if StartsStr(CurPath, FExpandedProperties[a]) then
       FExpandedProperties.Delete(a)
     else
       inc(a);

components/lazdebuggergdbmi/gdbmidebugger.pp

@@ -4547,8 +4547,10 @@ function TGDBMIDebuggerCommandDisassemble.DoExecute: Boolean;
         {$PUSH}{$IFnDEF DBGMI_WITH_DISASS_OVERFLOW}{$Q-}{$R-}{$ENDIF} // Overflow is allowed to occur
         j := (ItmPtr^.Addr - ItmPtr2^.Addr) * 2;
         {$POP}
-        if length(ItmPtr2^.Dump) > j then debugln(DBG_DISASSEMBLER, ['NOTICE, CopyToRange: Shortening Dump at the end of Range. AFromIndex=',AFromIndex, ' ACount=', ACount, ' Range=',dbgs(ADestRange)]);
-        if length(ItmPtr2^.Dump) > j then ItmPtr2^.Dump := copy(ItmPtr2^.Dump, 1, j);
+        if length(ItmPtr2^.Dump) > j then
+          debugln(DBG_DISASSEMBLER, ['NOTICE, CopyToRange: Shortening Dump at the end of Range. AFromIndex=',AFromIndex, ' ACount=', ACount, ' Range=',dbgs(ADestRange)]);
+        if length(ItmPtr2^.Dump) > j then
+          SetLength(ItmPtr2^.Dump, j);
       end;
     end;
 

components/lazdebuggergdbmi/gdbmidebuginstructions.pp

@@ -5,9 +5,9 @@ unit GDBMIDebugInstructions;
 interface
 
 uses
-  Classes, SysUtils, math,
+  Classes, SysUtils, StrUtils, math,
   // LazUtils
-  LazLoggerBase, LazClasses,
+  LazLoggerBase, LazClasses, LazStringUtils,
   // LazDebuggerGdbmi
   CmdLineDebugger, GDBMIMiscClasses;
 
@@ -578,7 +578,7 @@ type
       Result := ldGdb;
       exit;
     end;
-    if (copy(AData, 1, 6) = '^done,') or (AData = '^done') then begin
+    if StartsStr('^done,', AData) {or (AData = '^done')} then begin
       if FList = nil then
         FList := TGDBMINameValueList.Create(ALineData)
       else
@@ -762,7 +762,7 @@ begin
 //  "(gdb) "
 
   Result := False;
-  if (copy(AData, 1, 6) = '^done,') or (AData = '^done') then begin
+  if StartsStr('^done,', AData) {or (AData = '^done')} then begin
     Result := True;
     if FDone then
       HandleContentError;
@@ -824,7 +824,7 @@ begin
 //OR ^error => keep selected ?
 
   Result := False;
-  if (copy(AData, 1, 6) = '^done,') or (AData = '^done') then begin
+  if StartsStr('^done,', AData) {or (AData = '^done')} then begin
     Result := True;
     if FDone then
       HandleContentError;

components/onlinepackagemanager/opkman_common.pas

@@ -326,8 +326,8 @@ var
             if Trim(PackageData.FPackageRelativePath) <> '' then
             begin
               if PackageData.FPackageRelativePath[Length(PackageData.FPackageRelativePath)] = PathDelim then
-                PackageData.FPackageRelativePath := Copy(PackageData.FPackageRelativePath, 1, Length(PackageData.FPackageRelativePath) - 1);
-              PackageData.FPackageRelativePath := PackageData.FPackageRelativePath;
+                SetLength(PackageData.FPackageRelativePath, Length(PackageData.FPackageRelativePath)-1);
+              //PackageData.FPackageRelativePath := PackageData.FPackageRelativePath; ???
             end;
             PackageData.FFullPath := Path + SR.Name;
             APackageList.AddObject(PackageData.FName, PackageData);

components/onlinepackagemanager/opkman_zipper.pas

@@ -266,7 +266,7 @@ begin
   if not AIsDirZipped then
     ABaseDir := ''
   else
-    ABaseDir := Copy(ABaseDir, 1, Length(ABaseDir) - 1);
+    SetLength(ABaseDir, Length(ABaseDir)-1);
 end;
 
 

components/synedit/synbeautifier.pas

@@ -40,7 +40,9 @@ unit SynBeautifier;
 interface
 
 uses
-  Classes, SysUtils, LCLProc,
+  Classes, SysUtils, StrUtils,
+  LCLProc,
+  LazStringUtils,
   SynEditMiscClasses, SynEditMiscProcs, LazSynEditText, SynEditPointClasses,
   SynEditKeyCmds, SynEditTypes;
 
@@ -602,9 +604,9 @@ begin
     dec(BackCounter);
     Temp := GetLine(BackCounter);
     if Temp <> '' then begin
-      Temp := copy(Temp, 1, GetIndentForLine(FCurrentEditor, Temp, False));
+      SetLength(Temp, GetIndentForLine(FCurrentEditor, Temp, False));
       PhysLen := GetIndentForLine(FCurrentEditor, Temp, True);
-      if (PhysLen > KnownPhysLen) and (copy(temp, 1, length(BasedMix)) = BasedMix) then
+      if (PhysLen > KnownPhysLen) and StartsStr(BasedMix, Temp) then
       begin
         KnownMix := Temp;
         KnownPhysLen := PhysLen;
@@ -712,7 +714,7 @@ begin
   //  Temp := Lines[FoundLine-1]
   //else
   //  FoundLine := BackCounter + 1;
-  Temp := copy(Temp, 1, GetIndentForLine(Editor, Temp, False));
+  SetLength(Temp, GetIndentForLine(Editor, Temp, False));
 
   case FIndentType of
     sbitCopySpaceTab:

components/synedit/syneditautocomplete.pp

@@ -44,9 +44,10 @@ unit SynEditAutoComplete;
 interface
 
 uses
-  LCLIntf, LCLType, LCLProc, SysUtils, Menus,
-  Classes, SynEdit, SynEditKeyCmds, SynEditPlugins,
-  Controls;
+  Classes, StrUtils,
+  LCLIntf, LCLType, LCLProc, Controls, SysUtils, Menus,
+  LazStringUtils, LazUTF8,
+  SynEdit, SynEditKeyCmds, SynEditPlugins;
 
 const
   CodeTemplateMacroMagic = '$(EnableMakros)';
@@ -264,9 +265,9 @@ begin
     if fCaseSensitive then begin
       while i > -1 do begin
         s := fCompletions[i];
-        if AnsiCompareStr(s, AToken) = 0 then
+        if s = AToken then
           break
-        else if AnsiCompareStr(Copy(s, 1, Len), AToken) = 0 then begin
+        else if StartsStr(AToken, s) then begin
           Inc(NumMaybe);
           IdxMaybe := i;
         end;
@@ -275,9 +276,9 @@ begin
     end else begin
       while i > -1 do begin
         s := fCompletions[i];
-        if AnsiCompareText(s, AToken) = 0 then
+        if UTF8CompareLatinTextFast(s, AToken) = 0 then
           break
-        else if AnsiCompareText(Copy(s, 1, Len), AToken) = 0 then begin
+        else if UTF8CompareLatinTextFast(Copy(s, 1, Len), AToken) = 0 then begin
           Inc(NumMaybe);
           IdxMaybe := i;
         end;

components/synedit/syneditmarkuphighall.pp

@@ -26,11 +26,11 @@ unit SynEditMarkupHighAll;
 interface
 
 uses
-  Classes, SysUtils,
+  Classes, SysUtils, StrUtils,
   // LCL
   LCLProc, Controls, ExtCtrls,
   // LazUtils
-  LazClasses, LazUTF8, LazMethodList,
+  LazClasses, LazUTF8, LazMethodList, LazStringUtils,
   // SynEdit
   SynEditMarkup, SynEditTypes, SynEditSearch, SynEditMiscClasses,
   SynEditHighlighter, SynEditPointClasses, SynEditMiscProcs,
@@ -1384,7 +1384,7 @@ begin
     Len := length(o.SearchTerm);
     MatchBegin := MatchEnd - Len - FFindLineTextLower + FFindLineText;
 
-    if o.MatchCase and not(copy(MatchBegin, 1, Len) = o.SearchTerm) then begin
+    if o.MatchCase and not StartsStr(o.SearchTerm, MatchBegin) then begin
       MatchIdx := FTermDict.GetIndexForNextWordOccurrence(MatchIdx);
       continue;
     end;
@@ -2713,7 +2713,7 @@ function TSynEditMarkupHighlightAllCaret.GetCurrentText: String;
     Result := copy(s, i, MaxInt);
     i := length(Result);
     while (i > 0) and (Result[i] in [#1..#32]) do dec(i);
-    Result := copy(Result, 1, i);
+    SetLength(Result, i);
   end;
 var
   LowBnd, UpBnd: TPoint;

components/synedit/synedittexttrimmer.pas

@@ -596,7 +596,7 @@ begin
       j := i - length(s) - 1;
     s := copy(FSpaces, j + 1, MaxInt);
     {$IFDEF SynTrimDebug}debugln(['--- Trimmer -- CaretChanged - Trimming,part to ',length(s),' ', ' fLineIndex=', fLineIndex, ' fSpaces=',length(fSpaces), 'newCaretYPos=',TSynEditCaret(Sender).LinePos]);{$ENDIF}
-    FSpaces := copy(FSpaces, 1, j);
+    SetLength(FSpaces, j);
     i := length(s);
     MaybeAddUndoForget(FLineIndex+1, s);
     SendNotification(senrLineChange, self, fLineIndex, 1);
@@ -1000,7 +1000,7 @@ begin
   {$IFDEF SynTrimDebug}debugln(['--- Trimmer -- EditMoveToTrim()', ' fLineIndex=', fLineIndex, ' fSpaces=',length(fSpaces), ' Y=',LogY, '  len=',Len]);{$ENDIF}
   t := NextLines[LogY - 1];
   s := copy(t, 1 + length(t) - Len, Len) + Spaces(LogY - 1);
-  t := copy(t, 1, length(t) - Len);
+  SetLength(t, length(t) - Len);
   StoreSpacesForLine(LogY - 1, s, t);
   NextLines[LogY - 1] := t;
   CurUndoList.AddChange(TSynEditUndoTrimMoveTo.Create(LogY, Len));
@@ -1118,7 +1118,7 @@ begin
       LenNS := LastNoneSpacePos(AText);
       if LenNS < Len then begin
         EditInsertTrim(1, LogY, copy(AText, 1 + LenNS, Len));
-        AText := copy(AText, 1, LenNS);
+        SetLength(AText, LenNS);
       end;
     end;
   end;
@@ -1276,7 +1276,7 @@ begin
       LenNS := LastNoneSpacePos(AText);
       if LenNS < Len then begin
         EditInsertTrim(1, LogY, copy(AText, 1 + LenNS, Len));
-        AText := copy(AText, 1, LenNS);
+        SetLength(AText, LenNS);
       end;
     end;
   end;

components/todolist/todolistcore.pas

@@ -370,9 +370,8 @@ begin
     Exit; // Not a Todo/Done item, leave
 
   // Remove the ending comment chars from input string
-  if (aEndComment <> '')
-    and (RightStr(lParsingString, Length(aEndComment)) = aEndComment) then
-      lParsingString := Copy(lParsingString, 1, Length(lParsingString)-Length(aEndComment));
+  if (aEndComment <> '') and StartsStr(aEndComment, lParsingString) then
+    SetLength(lParsingString, Length(lParsingString)-Length(aEndComment));
 
   // Remove the Token
   Delete(lParsingString, 1, Length(TODO_TOKENS[lFoundTokenStyle, lTodoType]));

components/turbopower_ipro/ipcss.inc

@@ -513,7 +513,7 @@ end;
 
 function SizePxFromString(S: String): Integer;
 begin
-  S := Copy(S, 1, PosI('px',S)-1);
+  SetLength(S, PosI('px',S)-1);
   Result := StrToIntDef(S, 0);
 end;
 

components/turbopower_ipro/iphtml.pas

@@ -11329,7 +11329,7 @@ var
   begin
     FormData := TIpFormDataEntity.Create(nil);
     for i := 0 to Pred(FList.Count) do
-      if copy(VList[i], 1, 7) = 'file://' then
+      if StartsStr('file://', VList[i]) then
         FormData.AddFile(copy(VList[i], 8, length(VList[i])),
           Accept, 'plain', embinary)
       else

components/turbopower_ipro/ipstrms.pas

@@ -1568,10 +1568,9 @@ end;
 procedure TIpDownloadFileStream.dfsMakeTempFile(const aPath : string);
 begin
   { Make sure the path has no backslash. }
-  if aPath[length(aPath)] = '\' then
-    FPath := Copy(aPath, 1, pred(length(aPath)))
-  else
-    FPath := aPath;
+  FPath := aPath;
+  if FPath[length(FPath)] = '\' then
+    SetLength(FPath, pred(length(FPath)))
 
   { Check that it really exists. }
   if not DirExists(aPath) then

debugger/pseudoterminaldlg.pp

@@ -701,8 +701,8 @@ var
   begin
     if lineNumberLength = 0 then begin
       lineNumberAsText := '';
-      dataAsByteArray := BytesOf(Copy(stringList[currentLine], 1,
-                                Length(stringList[currentLine])))
+      // Was: Copy(stringList[currentLine], 1, Length(stringList[currentLine]))
+      dataAsByteArray := BytesOf(stringList[currentLine])
     end else begin                      (* Remember one extra space after number *)
       lineNumberAsText := Copy(stringList[currentLine], 1, lineNumberLength + 1);
       dataAsByteArray := BytesOf(Copy(stringList[currentLine], lineNumberLength + 2,

ide/editormacrolistviewer.pas

@@ -5,7 +5,7 @@ unit EditorMacroListViewer;
 interface
 
 uses
-  Classes, SysUtils,
+  Classes, SysUtils, StrUtils,
   // LCL
   LCLType, Forms, Controls, Dialogs, StdCtrls, ButtonPanel, ComCtrls, ExtCtrls,
   Spin, Menus, Buttons,
@@ -1444,7 +1444,7 @@ var
   i: Integer;
 begin
   Result := nil;
-  If (copy(AName, 1, length(EditorMacroVirtualDrive)) <> EditorMacroVirtualDrive) or
+  If not StartsStr(EditorMacroVirtualDrive, AName) or
      (copy(AName, NameStart-1, 1) <> '|')
   then exit;
   Alist := NameToMacroList(copy(AName, FolderStart, 3));

ide/environmentopts.pp

@@ -1695,24 +1695,25 @@ var
   lChldNode, lChCh: TDOMNode;
   lsNodeName: DOMString;
   lParentNode: TDOMNode;
+  PathM1, PreD, LastD: String;
 begin
   if Assigned(FRetainXMLData)  then
   begin
+    PathM1 := copy(Path, 1, length(Path) - 1);
+    PreD := ExtractFilePath(PathM1);
+    LastD := ExtractFileNameOnly(PathM1);
     lParentNode:= FXMLCfg.FindNode(path, False);
     lChldNode := FRetainXMLData.FirstChild.CloneNode(True, FXMLCfg.Document);
     lsNodeName := lChldNode.NodeName;
-    if ExtractFileNameOnly(copy(path, 1, length(path) - 1)) = lsNodeName then
-      FXMLCfg.FindNode(ExtractFilePath(copy(path, 1, length(path) - 1)), False)
-        .ReplaceChild(lChldNode, FXMLCfg.FindNode(path, False))
+    if LastD = lsNodeName then
+      FXMLCfg.FindNode(PreD,False).ReplaceChild(lChldNode,FXMLCfg.FindNode(Path,False))
     else
     begin
       try
         if not assigned(lParentNode) then
         begin
-          lParentNode:=FXMLCfg.Document.CreateElement(
-            ExtractFileNameOnly(copy(path, 1, length(path) - 1)));
-          FXMLCfg.FindNode(ExtractFilePath(copy(path, 1, length(path) - 1)), False).
-            AppendChild(lParentNode);
+          lParentNode:=FXMLCfg.Document.CreateElement(LastD);
+          FXMLCfg.FindNode(PreD, False).AppendChild(lParentNode);
         end;
         while lChldNode.HasChildNodes do
         begin

ide/frames/editor_color_options.pas

@@ -422,7 +422,7 @@ begin
     NewName := ExtractFileName(ExportSaveDialog.FileName);
     l := length(ExtractFileExt(NewName));
     if (l > 0) and (l+1 < Length(NewName)) then
-      NewName := Copy(NewName, 1, Length(NewName) - l);
+      SetLength(NewName, Length(NewName) - l);
     l := UTF8CodepointSize(PChar(NewName));
     if l > 0 then
       NewName := UTF8UpperCase(copy(NewName, 1, l)) + copy(NewName, 1+l, length(NewName));

ide/frames/editor_mouseaction_options_advanced.pas

@@ -556,7 +556,7 @@ begin
     NewName := ExtractFileName(SaveDialog1.FileName);
     l := length(ExtractFileExt(NewName));
     if (l > 0) and (l+1 < Length(NewName)) then
-      NewName := Copy(NewName, 1, Length(NewName) - l);
+      SetLength(NewName, Length(NewName) - l);
     l := UTF8CodepointSize(PChar(NewName));
     if l > 0 then
       NewName := UTF8UpperCase(copy(NewName, 1, l)) + copy(NewName, 1+l, length(NewName));

ide/frames/project_forms_options.pas

@@ -220,18 +220,19 @@ var
   function IndexOfAutoCreateForm(FormName: string): integer;
   var
     p: integer;
+    S: String;
   begin
     p := Pos(':', FormName);
     if p > 0 then
-      FormName := Copy(FormName, 1, p - 1);
+      SetLength(FormName, p-1);
     Result := FormsAutoCreatedListBox.Items.Count - 1;
     while (Result >= 0) do
     begin
-      p := Pos(':', FormsAutoCreatedListBox.Items[Result]);
-      if p < 1 then
-        p := Length(FormsAutoCreatedListBox.Items[Result]) + 1;
-      if CompareText(copy(FormsAutoCreatedListBox.Items[Result], 1, p - 1),
-        FormName) = 0 then
+      S := FormsAutoCreatedListBox.Items[Result];
+      p := Pos(':', S);
+      if p > 0 then
+        SetLength(S, p-1);
+      if CompareText(S, FormName) = 0 then
         Exit;
       Dec(Result);
     end;

ide/main.pp

@@ -9940,7 +9940,7 @@ function TMainIDE.DoJumpToCodePosition(ActiveSrcEdit: TSourceEditorInterface;
 var
   SrcEdit, NewSrcEdit: TSourceEditor;
   AnEditorInfo: TUnitEditorInfo;
-  s: String;
+  STB, FNStart: String;
 begin
   Result:=mrCancel;
   if NewSource=nil then begin
@@ -9974,10 +9974,12 @@ begin
       ActiveUnitInfo := Project1.UnitInfoWithFilename(NewSource.Filename);
       if (ActiveUnitInfo = nil) and (Project1.IsVirtual) and (jfSearchVirtualFullPath in Flags)
       then begin
-        s := AppendPathDelim(GetTestBuildDirectory);
-        if UTF8LowerCase(copy(NewSource.Filename, 1, length(s))) = UTF8LowerCase(s)
-        then ActiveUnitInfo := Project1.UnitInfoWithFilename(copy(NewSource.Filename,
-                1+length(s), length(NewSource.Filename)), [pfsfOnlyVirtualFiles]);
+        STB := AppendPathDelim(GetTestBuildDirectory);
+        FNStart := copy(NewSource.Filename, 1, length(STB));
+        if UTF8CompareLatinTextFast(FNStart, STB) = 0 then
+          ActiveUnitInfo := Project1.UnitInfoWithFilename(
+                                  copy(NewSource.Filename, 1+length(STB), MaxInt),
+                                  [pfsfOnlyVirtualFiles]);
       end;
 
       AnEditorInfo := nil;

ide/procedurelist.pas

@@ -38,7 +38,7 @@ unit ProcedureList;
 interface
 
 uses
-  Classes, SysUtils,
+  Classes, SysUtils, StrUtils,
   // LCL
   LCLType, Forms, Controls, Dialogs, ComCtrls, ExtCtrls, StdCtrls, Clipbrd,
   Graphics, Grids,
@@ -608,24 +608,16 @@ begin
   end
   else
   if not pSearchAll and tbFilterStart.Down then
-  begin
-    Result := ClassMatches and SameText(pSearchStr, Copy(pProcName, 1, Length(pSearchStr)));
-  end
+    Result := ClassMatches and StartsStr(pSearchStr, pProcName)
   else
   if not pSearchAll and tbFilterAny.Down then
-  begin
-    Result := ClassMatches and FilterFits(pSearchStr, pProcName);
-  end
+    Result := ClassMatches and FilterFits(pSearchStr, pProcName)
   else
   if pSearchAll and tbFilterStart.Down then
-  begin
-    Result := SameText(pSearchStr, Copy(pProcName, 1, Length(pSearchStr)));
-  end
+    Result := StartsStr(pSearchStr, pProcName)
   else
   if pSearchAll then
-  begin
     Result := FilterFits(pSearchStr, pProcName);
-  end;
 end;
 
 procedure TProcedureListForm.ClearGrid;

ide/publishmoduledlg.pas

@@ -36,7 +36,7 @@ uses
   // LCL
   LCLType, Forms, StdCtrls, Dialogs, Buttons, ButtonPanel, LCLIntf,
   // LazUtils
-  FileUtil, LazFileUtils, LazLoggerBase, UITypes, LazUTF8,
+  FileUtil, LazFileUtils, LazStringUtils, LazLoggerBase, UITypes, LazUTF8,
   // BuildIntf
   ProjPackIntf, CompOptsIntf, PublishModuleIntf,
   // IdeIntf
@@ -209,7 +209,7 @@ begin
   UpALevel := '..' + DirectorySeparator;
   RelPath := ExtractRelativePath(FTopDir, AFilename);
   Adjusted := False;
-  while Copy(RelPath, 1, 3) = UpALevel do
+  while StartsStr(UpALevel, RelPath) do
   begin
     FTopDir := FTopDir + UpALevel; // This file is in upper dir. Move TopDir up, too.
     Delete(RelPath, 1, 3);

ide/sourcefilemanager.pas

@@ -32,13 +32,13 @@ unit SourceFileManager;
 interface
 
 uses
-  Classes, SysUtils, typinfo, math, fpjson, Laz_AVL_Tree,
+  Classes, SysUtils, StrUtils, typinfo, math, fpjson, Laz_AVL_Tree,
   // LCL
   Controls, Forms, Dialogs, LCLIntf, LCLType, LclStrConsts,
   LResources, LCLMemManager,
   // LazUtils
   LConvEncoding, LazFileCache, FileUtil, LazFileUtils, LazLoggerBase, LazUtilities,
-  LazUTF8, LazTracer, AvgLvlTree,
+  LazStringUtils, LazUTF8, LazTracer, AvgLvlTree,
   // Codetools
   {$IFDEF IDE_MEM_CHECK}
   MemCheck,
@@ -860,8 +860,8 @@ procedure TFileOpener.CheckInternalFile;
 var
   NewBuf: TCodeBuffer;
 begin
-  if (copy(FFileName, 1, length(EditorMacroVirtualDrive)) = EditorMacroVirtualDrive)
-  then begin
+  if StartsStr(EditorMacroVirtualDrive, FFileName) then
+  begin
     FUnitIndex:=Project1.IndexOfFilename(FFilename);
     if (FUnitIndex < 0) then begin
       NewBuf := CodeToolBoss.SourceCache.CreateFile(FFileName);
@@ -2401,8 +2401,8 @@ begin
 
   if (uifInternalFile in AnUnitInfo.Flags) then
   begin
-    if (copy(AnUnitInfo.Filename, 1, length(EditorMacroVirtualDrive)) = EditorMacroVirtualDrive)
-    then begin
+    if StartsStr(EditorMacroVirtualDrive, AnUnitInfo.Filename) then
+    begin
       // save to macros
       EMacro := MacroListViewer.MacroByFullName(AnUnitInfo.Filename);
       if EMacro <> nil then begin

lcl/colorbox.pas

@@ -20,8 +20,9 @@ unit ColorBox;
 interface
 
 uses
-  LResources, SysUtils, Types, Classes,
-  LCLProc, LCLType, LCLStrConsts, Graphics, Controls, Forms, Dialogs, StdCtrls;
+  LResources, SysUtils, Types, Classes, StrUtils,
+  LCLProc, LCLType, LCLStrConsts, Graphics, Controls, Forms, Dialogs, StdCtrls,
+  LazStringUtils;
 
 const
   cDefaultColorRectWidth = 14;
@@ -363,7 +364,7 @@ begin
   if not FindInMap(ColorName, Result) then
   begin
     Result := ColorName;
-    if Copy(Result, 1, 2) = 'cl' then
+    if StartsStr('cl', Result) then
       Delete(Result, 1, 2);
   end;
 end;