paweld/lazarus
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/lazarus/lazarus.git synced 2025-08-21 03:21:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

IDE: fixed adding designtime package requirement when dropping component onto form

Browse Source
This commit is contained in:
mattias 2022-01-06 13:04:38 +01:00
parent 384eda71d8
commit 2b5f37730f
1 changed files with 43 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

83
packager/pkgmanager.pas
View File

@ -4486,18 +4486,53 @@ end;
function TPkgManager.GetUnitsAndDepsForComps(ComponentClasses: TClassList; function TPkgManager.GetUnitsAndDepsForComps(ComponentClasses: TClassList;
out PackageList: TPackagePackageArray; out UnitList: TStringList): TModalResult; out PackageList: TPackagePackageArray; out UnitList: TStringList): TModalResult;
// returns a list of packages and units needed to use the Component in the unit // returns a list of packages and units needed to use the Component in the unit
var
CurPackages, AllPackages: TStringList;
procedure AddPkgDep(CurCompReq: TComponentRequirements; PkgFile: TPkgFile);
var
RequiredPackage: TLazPackageID;
Helper: TPackageIterateHelper;
begin
if PkgFile=nil then exit;
RequiredPackage:=PkgFile.LazPackage;
RequiredPackage:=RedirectPackageDependency(TIDEPackage(RequiredPackage));
if RequiredPackage=nil then exit;
if CurPackages=nil then
begin
CurPackages:=TStringListUTF8Fast.Create;
CurPackages.Sorted:=True;
CurPackages.Duplicates:=dupIgnore;
end else
CurPackages.Clear;
if AllPackages=nil then
begin
AllPackages:=TStringListUTF8Fast.Create;
AllPackages.Sorted:=True;
AllPackages.Duplicates:=dupIgnore;
end;
CurPackages.Add(RequiredPackage.Name);
if Assigned(CurCompReq) then
CurCompReq.RequiredPkgs(CurPackages);
Helper:=TPackageIterateHelper.Create;
try
Helper.PackageNames:=CurPackages;
Helper.PackageList:=AllPackages;
PackageGraph.IteratePackages(fpfSearchAllExisting,@Helper.AddDependency);
finally
Helper.Free;
end;
end;
var var
CurClassID: Integer; CurClassID: Integer;
CurUnitIdx, CurPackageIdx: Integer; CurUnitIdx, CurPackageIdx: Integer;
CurCompClass: TClass; CurCompClass: TClass;
CurRegComp: TRegisteredComponent; CurRegComp: TRegisteredComponent;
PkgFile: TPkgFile; PkgFile: TPkgFile;
RequiredPackage: TLazPackageID;
CurUnitName: String; CurUnitName: String;
CurUnitNames: TStrings; CurUnitNames: TStrings;
CurPackages, AllPackages: TStringList;
CurCompReq: TComponentRequirements; CurCompReq: TComponentRequirements;
Helper: TPackageIterateHelper;
begin begin
Result:=mrCancel; Result:=mrCancel;
PackageList:=nil; PackageList:=nil;
@ -4527,7 +4562,7 @@ begin
CurUnitName:=CurRegComp.ComponentClass.UnitName; CurUnitName:=CurRegComp.ComponentClass.UnitName;
CurCompReq:=GetComponentRequirements(CurRegComp.ComponentClass); CurCompReq:=GetComponentRequirements(CurRegComp.ComponentClass);
end; end;
//DebugLn(['TPkgManager.GetUnitsAndDepsForComps: CurUnitName=',CurUnitName]); DebugLn(['TPkgManager.GetUnitsAndDepsForComps: CurCompClass=',DbgSName(CurCompClass),' CurUnitName=',CurUnitName,' CurCompReq=',DbgSName(CurCompReq)]);
if CurUnitName='' then if CurUnitName='' then
CurUnitName:=CurRegComp.GetUnitName; CurUnitName:=CurRegComp.GetUnitName;
//Assert(CurUnitNames.IndexOf(CurUnitName)<0, //Assert(CurUnitNames.IndexOf(CurUnitName)<0,
@ -4540,42 +4575,10 @@ begin
CurUnitName:=CurUnitNames[CurUnitIdx]; CurUnitName:=CurUnitNames[CurUnitIdx];
UnitList.Add(CurUnitName); UnitList.Add(CurUnitName);
PkgFile:=PackageGraph.FindUnitInAllPackages(CurUnitName,true); PkgFile:=PackageGraph.FindUnitInAllPackages(CurUnitName,true);
//DebugLn([' GetUnitsAndDepsForComps: CurUnitName=',CurUnitName, AddPkgDep(CurCompReq,PkgFile);
// ', PkgFile=', PkgFile.Unit_Name]); if TPkgComponent(CurRegComp).PkgFile<>PkgFile then
if PkgFile=nil then // e.g. a designtime package has registered the componentclass
PkgFile:=TPkgComponent(CurRegComp).PkgFile; AddPkgDep(CurCompReq,TPkgComponent(CurRegComp).PkgFile);
if PkgFile<>nil then
begin
RequiredPackage:=PkgFile.LazPackage;
RequiredPackage:=RedirectPackageDependency(TIDEPackage(RequiredPackage));
if RequiredPackage<>nil then
begin
if CurPackages=nil then
begin
CurPackages:=TStringListUTF8Fast.Create;
CurPackages.Sorted:=True;
CurPackages.Duplicates:=dupIgnore;
end else
CurPackages.Clear;
if AllPackages=nil then
begin
AllPackages:=TStringListUTF8Fast.Create;
AllPackages.Sorted:=True;
AllPackages.Duplicates:=dupIgnore;
end;
CurPackages.Add(RequiredPackage.Name);
if Assigned(CurCompReq) then
CurCompReq.RequiredPkgs(CurPackages);
Helper:=TPackageIterateHelper.Create;
try
Helper.PackageNames:=CurPackages;
Helper.PackageList:=AllPackages;
PackageGraph.IteratePackages(fpfSearchAllExisting,@Helper.AddDependency);
finally
Helper.Free;
end;
end;
end;
end; // for CurUnitIdx:= end; // for CurUnitIdx:=
finally finally
CurCompReq.Free; CurCompReq.Free;