paweld/lazarus
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/lazarus/lazarus.git synced 2025-09-07 15:20:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

IDE/lazbuild: build IDE: fixed passing options twice, order: packages, profile, target

Browse Source 
git-svn-id: trunk@48443 -
This commit is contained in:
mattias 2015-03-21 11:57:34 +00:00
parent ba549190fe
commit 2dc3f24423
2 changed files with 43 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

75
ide/buildlazdialog.pas
View File

@ -418,6 +418,7 @@ begin
Result:=mrCancel;
fProfile:=Profile;
if CalcTargets(Flags)<>mrOk then exit;
debugln(['TLazarusBuilder.MakeLazarus AAA1 ',fExtraOptions]);
if LazarusIDE<>nil then
LazarusIDE.MainBarSubTitle:=Profile.Name;
@ -570,22 +571,29 @@ begin
fOutputDirRedirected:=False;
fUpdateRevInc:=fProfile.UpdateRevisionInc;
// create extra options
fExtraOptions:=fProfile.ExtraOptions;
fExtraOptions:='';
// check for special IDE config file
//DebugLn(['CreateIDEMakeOptions blfUseMakeIDECfg=',blfUseMakeIDECfg in FLags,' ExtraOptions="',fExtraOptions,'" ',fPackageOptions]);
if (blfUseMakeIDECfg in Flags) then
SpecialIdeConfig
else if not (blfUseMakeIDECfg in Flags) then
begin
SpecialIdeConfig;
end
else begin
AppendExtraOption(fPackageOptions,false);
{$IFDEF Windows}
if (fProfile.TargetPlatform=lpWin32)
and (Win32MajorVersion <=4)
and (Win32Platform = VER_PLATFORM_WIN32_WINDOWS) then
AppendExtraOption('-dWIN9XPLATFORM');
{$ENDIF}
// write full file names and message ids
AppendExtraOption('-vbq');
{$IFDEF Windows}
if (fProfile.TargetPlatform=lpWin32)
and (Win32MajorVersion <=4)
and (Win32Platform = VER_PLATFORM_WIN32_WINDOWS) then
AppendExtraOption('-dWIN9XPLATFORM');
{$ENDIF}
AppendExtraOption(fProfile.ExtraOptions,false);
end;
// set target filename and target directory:
// 1. the user has set a target directory
@ -614,11 +622,6 @@ begin
if fTargetCPU='' then fTargetCPU:=fCompilerTargetCPU;
LazDir:=EnvironmentOptions.GetParsedLazarusDirectory;
if fTargetOS<>fCompilerTargetOS then
AppendExtraOption('-T'+fTargetOS);
if fTargetCPU<>fCompilerTargetCPU then
AppendExtraOption('-P'+fTargetCPU);
//DebugLn(['CalcTargets NewTargetOS=',fTargetOS,' NewTargetCPU=',fTargetCPU]);
if (fProfile.TargetDirectory<>'') then begin
// Case 1. the user has set a target directory
@ -699,26 +702,32 @@ begin
fOutputDirRedirected:=CompareFilenames(ChompPathDelim(LazDir),
ChompPathDelim(fTargetDir))<>0;
// write full file names and message ids
AppendExtraOption('-vbq');
// append target options
if not (blfUseMakeIDECfg in Flags) then
begin
if fTargetOS<>fCompilerTargetOS then
AppendExtraOption('-T'+fTargetOS);
if fTargetCPU<>fCompilerTargetCPU then
AppendExtraOption('-P'+fTargetCPU);
if fUnitOutDir<>'' then
// FPC interpretes '\ ' as an escape for a space in a path on Windows,
// so make sure the directory doesn't end with the path delimiter.
AppendExtraOption('-FU'+ChompPathDelim(fUnitOutDir));
if fUnitOutDir<>'' then
// FPC interpretes '\ ' as an escape for a space in a path on Windows,
// so make sure the directory doesn't end with the path delimiter.
AppendExtraOption('-FU'+ChompPathDelim(fUnitOutDir));
//debugln(['TLazarusBuilder.CreateIDEMakeOptions fTargetDir=',fTargetDir,' fOutputDirRedirected=',fOutputDirRedirected,' fTargetFilename=',fTargetFilename]);
if fOutputDirRedirected then
// FPC interpretes '\ ' as an escape for a space in a path on Windows,
// so make sure the directory doesn't end with the path delimiter.
AppendExtraOption('-FE'+ChompPathDelim(fTargetDir));
//debugln(['TLazarusBuilder.CreateIDEMakeOptions fTargetDir=',fTargetDir,' fOutputDirRedirected=',fOutputDirRedirected,' fTargetFilename=',fTargetFilename]);
if fOutputDirRedirected then
// FPC interpretes '\ ' as an escape for a space in a path on Windows,
// so make sure the directory doesn't end with the path delimiter.
AppendExtraOption('-FE'+ChompPathDelim(fTargetDir));
// Note: FPC automatically changes the last extension (append or replace)
// For example under linux, where executables don't need any extension
// fpc removes the last extension of the -o option.
DefaultTargetFilename:='lazarus'+GetExecutableExt(fTargetOS);
if CreateRelativePath(fTargetFilename,fTargetDir) <> DefaultTargetFilename then
AppendExtraOption('-o'+fTargetFilename);
// Note: FPC automatically changes the last extension (append or replace)
// For example under linux, where executables don't need any extension
// fpc removes the last extension of the -o option.
DefaultTargetFilename:='lazarus'+GetExecutableExt(fTargetOS);
if CreateRelativePath(fTargetFilename,fTargetDir) <> DefaultTargetFilename then
AppendExtraOption('-o'+fTargetFilename);
end;
//DebugLn(['CreateIDEMakeOptions ',MMDef.Name,' ',fExtraOptions]);
end;
@ -907,7 +916,7 @@ var
begin
Result:=mrCancel;
fProfile:=Profile;
if CalcTargets(Flags)<>mrOk then exit;
if CalcTargets(Flags-[blfUseMakeIDECfg])<>mrOk then exit;
Result:=PrepareTargetDir(Flags);
if Result<>mrOk then exit;

2
ide/main.pp
View File

@ -7395,7 +7395,7 @@ begin
// save extra options
IDEBuildFlags:=Flags;
Result:=fBuilder.SaveIDEMakeOptions(BuildLazProfiles.Current,
IDEBuildFlags-[blfUseMakeIDECfg,blfDontClean]+[blfBackupOldExe]);
IDEBuildFlags-[blfDontClean]+[blfBackupOldExe]);
if Result<>mrOk then begin
DebugLn('TMainIDE.DoBuildLazarus: Save IDEMake options failed.');
exit;