From 360bfc74b1d45d3e8d31fcf625c295a54e0934c3 Mon Sep 17 00:00:00 2001 From: dmitry Date: Fri, 7 Dec 2018 04:04:18 +0000 Subject: [PATCH] cocoa: menus - fix cocoa app mem leak for allocated TcocoaMenuItems git-svn-id: trunk@59754 - --- lcl/interfaces/cocoa/cocoawsmenus.pas | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lcl/interfaces/cocoa/cocoawsmenus.pas b/lcl/interfaces/cocoa/cocoawsmenus.pas index 500941d15c..eba60a8b47 100644 --- a/lcl/interfaces/cocoa/cocoawsmenus.pas +++ b/lcl/interfaces/cocoa/cocoawsmenus.pas @@ -588,10 +588,12 @@ begin if Assigned(menuitem.menu) then menuitem.menu.removeItem(menuitem); AMenuItem.Handle := 0; + menuitem.release; // TCocoaMenuItems are "alloced" - thus should be released; end else if item.isKindOfClass_(NSMenuItem) then begin nsitem := NSMenuItem(item); if nsitem.isSeparatorItem and Assigned(nsitem.menu) then nsitem.menu.removeItem(nsitem); + // separator items are not "alloced", thus should not be released end; end;