paweld/lazarus
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/lazarus/lazarus.git synced 2025-09-07 09:40:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

Debugger: Fix updating CPU Register values. Issue #0038534

Browse Source 
git-svn-id: trunk@64674 -
This commit is contained in:
martin 2021-02-27 01:00:10 +00:00
parent aea537a7ec
commit 433bb3d412
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
components/debuggerintf/dbgintfdebuggerbase.pp
View File

@ -987,6 +987,7 @@ type
destructor Destroy; override;
property Name: String read FName;
property Value: String read GetValue write SetValue;
// TODO: DisplayFormat => does each thread/stackframe need to store a separet setting // InvalidateItems (soleved issue 62591) therefore must keep all of them
property DisplayFormat: TRegisterDisplayFormat read FDisplayFormat write SetDisplayFormat;
property Modified: Boolean read FModified write FModified;
property DataValidity: TDebuggerDataState read FDataValidity write SetDataValidity;
@ -1003,11 +1004,14 @@ type
FDataValidity: TDebuggerDataState;
function GetEntry(AnIndex: Integer): TRegisterValue;
function GetEntryByName(const AName: String): TRegisterValue;
// TODO: setting to requested will not affect TRegisterValue
// TODO: since TRegisterValue are kept, any registers that are no longer avail, must be removed at some point (i.e. when this is set valid, and some TRegisterValue are still unknown/requested)
procedure SetDataValidity(AValue: TDebuggerDataState);
protected
function CreateEntry: TDbgEntityValue; override;
procedure DoDataValidityChanged({%H-}AnOldValidity: TDebuggerDataState); virtual;
public
procedure InvalidateItems;
function Count: Integer; reintroduce; virtual;
property Entries[AnIndex: Integer]: TRegisterValue read GetEntry; default;
property EntriesByName[const AName: String]: TRegisterValue read GetEntryByName; // autocreate
@ -3383,6 +3387,15 @@ begin
//
end;
procedure TRegisters.InvalidateItems;
var
i: Integer;
begin
DataValidity := ddsUnknown;
for i := 0 to (inherited Count) - 1 do // The current count, without triggering request.
Entries[i].DataValidity := ddsUnknown;
end;
function TRegisters.Count: Integer;
begin
if FDataValidity = ddsValid then
@ -3411,7 +3424,7 @@ begin
if Count = 0 then
exit;
for i := 0 to Count-1 do begin
EntriesByIdx[i].DataValidity := ddsUnknown;
EntriesByIdx[i].InvalidateItems;
end;
DoCleared;
end;

3
components/lazdebuggergdbmi/gdbmidebugger.pp
View File

@ -2103,7 +2103,6 @@ begin
// Need all registers
FRegisters.DataValidity := ddsEvaluating;
UpdateFormat(rdDefault);
FRegisters.DataValidity := ddsValid;
if ChangedRegList <> nil then begin
for i := 0 to FRegisters.Count - 1 do
@ -2115,6 +2114,8 @@ begin
end;
FreeAndNil(ChangedRegList);
end;
FRegisters.DataValidity := ddsValid;
end;
// check for individual updates / displayformat