paweld/lazarus
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/lazarus/lazarus.git synced 2025-09-11 13:59:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

ppulistdlg: Removing unnecessary local variables for grids

Browse Source
This commit is contained in:
n7800 2024-07-18 09:24:50 +05:00 committed by Maxim Ganetsky
parent 76ef42ad5b
commit 4a2ce51ec0
1 changed files with 22 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
components/codetools/ide/ppulistdlg.pas
View File

@ -386,13 +386,12 @@ end;
procedure TPPUListDialog.UnitStringGridMouseDown(Sender: TObject; procedure TPPUListDialog.UnitStringGridMouseDown(Sender: TObject;
Button: TMouseButton; Shift: TShiftState; X, Y: Integer); Button: TMouseButton; Shift: TShiftState; X, Y: Integer);
var var
Grid: TStringGrid; Grid: TStringGrid absolute Sender;
Col: Longint; Col: Longint;
Row: Longint; Row: Longint;
AnUnitName: string; AnUnitName: string;
begin begin
if FItems=nil then exit; if FItems=nil then exit;
Grid:=TStringGrid(Sender);
if Shift=[ssLeft,ssDouble] then begin if Shift=[ssLeft,ssDouble] then begin
Col:=0; Col:=0;
Row:=0; Row:=0;
@ -568,7 +567,6 @@ procedure TPPUListDialog.UpdateUnitsGrid;
end; end;
var var
Grid: TStringGrid;
Node: TAvlTreeNode; Node: TAvlTreeNode;
Item: TPPUDlgListItem; Item: TPPUDlgListItem;
Row: Integer; Row: Integer;
@ -576,8 +574,7 @@ var
TotalPPUBytes, TotalOBytes: int64; TotalPPUBytes, TotalOBytes: int64;
SortedItems: TAvlTree; SortedItems: TAvlTree;
begin begin
Grid:=UnitsStringGrid; UnitsStringGrid.BeginUpdate;
Grid.BeginUpdate;
SortedItems:=TAvlTree.CreateObjectCompare(@CompareUnits); SortedItems:=TAvlTree.CreateObjectCompare(@CompareUnits);
try try
@ -594,22 +591,22 @@ begin
Node:=FItems.FindSuccessor(Node); Node:=FItems.FindSuccessor(Node);
end; end;
Grid.RowCount:=Grid.FixedRows+SortedItems.Count; UnitsStringGrid.RowCount:=UnitsStringGrid.FixedRows+SortedItems.Count;
// total // total
Grid.Cells[0,1]:=crsTotal; UnitsStringGrid.Cells[0,1]:=crsTotal;
Grid.Cells[1,1]:=SizeToStr(TotalPPUBytes,1.0); UnitsStringGrid.Cells[1,1]:=SizeToStr(TotalPPUBytes,1.0);
Grid.Cells[2,1]:=SizeToStr(TotalOBytes,1.0); UnitsStringGrid.Cells[2,1]:=SizeToStr(TotalOBytes,1.0);
Grid.Cells[3,1]:=IntToStr(SortedItems.Count); UnitsStringGrid.Cells[3,1]:=IntToStr(SortedItems.Count);
Grid.Cells[4,1]:=''; UnitsStringGrid.Cells[4,1]:='';
Grid.Cells[5,1]:=''; UnitsStringGrid.Cells[5,1]:='';
// fill grid // fill grid
Row:=Grid.FixedRows; Row:=UnitsStringGrid.FixedRows;
Node:=SortedItems.FindLowest; Node:=SortedItems.FindLowest;
while Node<>nil do begin while Node<>nil do begin
Item:=TPPUDlgListItem(Node.Data); Item:=TPPUDlgListItem(Node.Data);
Grid.Cells[0,Row]:=Item.TheUnitName; UnitsStringGrid.Cells[0,Row]:=Item.TheUnitName;
// .ppu size // .ppu size
s:=''; s:='';
@ -619,7 +616,7 @@ begin
s:=crsMissing s:=crsMissing
else else
s:=SizeToStr(Item.PPUFileSize,double(Item.PPUFileSize)/TotalPPUBytes); s:=SizeToStr(Item.PPUFileSize,double(Item.PPUFileSize)/TotalPPUBytes);
Grid.Cells[1,Row]:=s; UnitsStringGrid.Cells[1,Row]:=s;
// .o size // .o size
s:=''; s:='';
@ -629,16 +626,16 @@ begin
s:=crsMissing s:=crsMissing
else else
s:=SizeToStr(Item.OFileSize,double(Item.OFileSize)/TotalOBytes); s:=SizeToStr(Item.OFileSize,double(Item.OFileSize)/TotalOBytes);
Grid.Cells[2,Row]:=s; UnitsStringGrid.Cells[2,Row]:=s;
// uses // uses
Grid.Cells[3,Row]:=IntToStr(Item.UsesCount); UnitsStringGrid.Cells[3,Row]:=IntToStr(Item.UsesCount);
// used by // used by
Grid.Cells[4,Row]:=IntToStr(Item.UsedByCount); UnitsStringGrid.Cells[4,Row]:=IntToStr(Item.UsedByCount);
// used by // used by
Grid.Cells[5,Row]:=Item.PackageName; UnitsStringGrid.Cells[5,Row]:=Item.PackageName;
inc(Row); inc(Row);
Node:=SortedItems.FindSuccessor(Node); Node:=SortedItems.FindSuccessor(Node);
@ -648,7 +645,7 @@ begin
SortedItems.Free; SortedItems.Free;
end; end;
Grid.EndUpdate; UnitsStringGrid.EndUpdate;
end; end;
function TPPUListDialog.DoubleAsPercentage(const d: double): string; function TPPUListDialog.DoubleAsPercentage(const d: double): string;
@ -779,7 +776,6 @@ var
UsedByUnitName: string; UsedByUnitName: string;
UsesPath: TFPList; UsesPath: TFPList;
LinkedFile: TPPULinkedFile; LinkedFile: TPPULinkedFile;
Grid: TStringGrid;
begin begin
Item:=FindUnit(AnUnitName); Item:=FindUnit(AnUnitName);
if Item=nil then begin if Item=nil then begin
@ -825,17 +821,16 @@ begin
end; end;
// linked files // linked files
Grid:=UnitLinkedFilesStringGrid;
if Item.LinkedFiles<>nil then begin if Item.LinkedFiles<>nil then begin
Grid.RowCount:=Grid.FixedRows+Item.LinkedFiles.Count; UnitLinkedFilesStringGrid.RowCount:=UnitLinkedFilesStringGrid.FixedRows+Item.LinkedFiles.Count;
for i:=0 to Item.LinkedFiles.Count-1 do begin for i:=0 to Item.LinkedFiles.Count-1 do begin
LinkedFile:=TPPULinkedFile(Item.LinkedFiles[i]); LinkedFile:=TPPULinkedFile(Item.LinkedFiles[i]);
Grid.Cells[0,Grid.FixedRows+i]:=PPUEntryName(LinkedFile.ID); UnitLinkedFilesStringGrid.Cells[0,UnitLinkedFilesStringGrid.FixedRows+i]:=PPUEntryName(LinkedFile.ID);
Grid.Cells[1,Grid.FixedRows+i]:=LinkedFile.Filename; UnitLinkedFilesStringGrid.Cells[1,UnitLinkedFilesStringGrid.FixedRows+i]:=LinkedFile.Filename;
Grid.Cells[2,Grid.FixedRows+i]:=PPULinkContainerFlagToStr(LinkedFile.Flags); UnitLinkedFilesStringGrid.Cells[2,UnitLinkedFilesStringGrid.FixedRows+i]:=PPULinkContainerFlagToStr(LinkedFile.Flags);
end; end;
end else begin end else begin
Grid.RowCount:=Grid.FixedRows; UnitLinkedFilesStringGrid.RowCount:=UnitLinkedFilesStringGrid.FixedRows;
end; end;
end; end;
end; end;