paweld/lazarus
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/lazarus/lazarus.git synced 2025-04-07 18:58:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

IDE: Inform a user earlier that renaming a unit is not possible through "Rename identifier" feature. Issue #40744.

Browse Source 
(cherry picked from commit 6c9fa22be3)
This commit is contained in:
Juha 2024-02-24 01:11:04 +02:00 committed by Maxim Ganetsky
parent ee4aebfa7d
commit 4c726899a3
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
ide/findrenameidentifier.pas
View File

@ -278,8 +278,17 @@ begin
CodeToolBoss.GetIdentifierAt(DeclCode,DeclarationCaretXY.X,DeclarationCaretXY.Y,Identifier);
CurUnitname:=ExtractFileNameOnly(DeclCode.Filename);
//debugln('TMainIDE.DoFindRenameIdentifier A DeclarationCaretXY=',dbgs(DeclarationCaretXY));
// ToDo: Support renaming and saving a unit also here.
// Now just inform a user that renaming is not possible.
if CompareDottedIdentifiers(PChar(Identifier),PChar(CurUnitName))=0 then
begin
IDEMessageDialog(srkmecRenameIdentifier,
lisTheIdentifierIsAUnitPleaseUseTheFileSaveAsFunction,
mtInformation,[mbCancel],'');
exit(mrCancel);
end;
//debugln('TMainIDE.DoFindRenameIdentifier A DeclarationCaretXY=',dbgs(DeclarationCaretXY));
Files:=nil;
OwnerList:=nil;
PascalReferences:=nil;
@ -395,13 +404,6 @@ begin
// rename identifier
if Options.Rename then begin
if CompareDottedIdentifiers(PChar(Identifier),PChar(CurUnitName))=0 then
begin
IDEMessageDialog(srkmecRenameIdentifier,
lisTheIdentifierIsAUnitPleaseUseTheFileSaveAsFunction,
mtInformation,[mbCancel],'');
exit(mrCancel);
end;
OldChange:=LazarusIDE.OpenEditorsOnCodeToolChange;
LazarusIDE.OpenEditorsOnCodeToolChange:=true;
try
@ -410,8 +412,7 @@ begin
then begin
LazarusIDE.DoJumpToCodeToolBossError;
debugln('Error: (lazarus) DoFindRenameIdentifier unable to commit');
Result:=mrCancel;
exit;
exit(mrCancel);
end;
finally
LazarusIDE.OpenEditorsOnCodeToolChange:=OldChange;