IDE: Implement configurable DropDownCount for more ComboBoxes. Issue #36595, patch from Vojtech Cihak.

git-svn-id: trunk@62571 -

debugger/evaluatedlg.pp

@@ -46,7 +46,7 @@ uses
   DbgIntfDebuggerBase,
   // IDE
   LazarusIDEStrConsts, BaseDebugManager, InputHistory, IDEProcs,
-  Debugger, DebuggerDlg, DebuggerStrConst;
+  Debugger, DebuggerDlg, DebuggerStrConst, EnvironmentOpts;
 
 type
 
@@ -79,6 +79,7 @@ type
     procedure cmbExpressionSelect(Sender: TObject);
     procedure cmbNewValueKeyDown(Sender: TObject; var Key: Word;
       {%H-}Shift: TShiftState);
+    procedure FormActivate(Sender: TObject);
     procedure FormClose(Sender: TObject; var {%H-}CloseAction: TCloseAction);
     procedure FormCreate(Sender: TObject);
     procedure FormKeyDown(Sender: TObject; var Key: Word; Shift: TShiftState);
@@ -161,6 +162,12 @@ begin
   SetFindText(AExpression);
 end;
 
+procedure TEvaluateDlg.FormActivate(Sender: TObject);
+begin
+  cmbExpression.DropDownCount := EnvironmentOptions.DropDownCount;
+  cmbNewValue.DropDownCount := EnvironmentOptions.DropDownCount;
+end;
+
 procedure TEvaluateDlg.UpdateData;
 begin
   Evaluate;

debugger/inspectdlg.lfm

@@ -10,21 +10,22 @@ object IDEInspectDlg: TIDEInspectDlg
   Constraints.MinHeight = 200
   Constraints.MinWidth = 200
   KeyPreview = True
+  OnActivate = FormActivate
   OnClose = FormClose
   OnCreate = FormCreate
   OnKeyDown = FormKeyDown
-  LCLVersion = '1.3'
+  LCLVersion = '2.1.0.0'
   object StatusBar1: TStatusBar
     Left = 0
-    Height = 23
-    Top = 383
+    Height = 19
+    Top = 387
     Width = 295
     Panels = <>
   end
   object PageControl: TPageControl
     Left = 0
-    Height = 336
-    Top = 47
+    Height = 338
+    Top = 49
     Width = 295
     ActivePage = DataPage
     Align = alClient
@@ -44,11 +45,11 @@ object IDEInspectDlg: TIDEInspectDlg
   end
   object EdInspect: TComboBox
     Left = 0
-    Height = 21
+    Height = 23
     Top = 0
     Width = 295
     Align = alTop
-    ItemHeight = 13
+    ItemHeight = 14
     OnEditingDone = EdInspectEditingDone
     OnKeyDown = EdInspectKeyDown
     TabOrder = 2
@@ -58,13 +59,13 @@ object IDEInspectDlg: TIDEInspectDlg
     AnchorSideTop.Control = EdInspect
     Left = 0
     Height = 26
-    Top = 21
+    Top = 23
     Width = 295
     Caption = 'ToolBar1'
     ShowCaptions = True
     TabOrder = 3
     object btnUseInstance: TToolButton
-      Left = 54
+      Left = 52
       Hint = 'Use Instance class'
       Top = 2
       AllowAllUp = True
@@ -75,14 +76,14 @@ object IDEInspectDlg: TIDEInspectDlg
       Style = tbsCheck
     end
     object ToolButton2: TToolButton
-      Left = 104
+      Left = 105
+      Height = 22
       Top = 2
-      Width = 5
       Caption = 'ToolButton2'
       Style = tbsDivider
     end
     object btnColClass: TToolButton
-      Left = 109
+      Left = 110
       Hint = 'Show Class Column'
       Top = 2
       AllowAllUp = True
@@ -94,7 +95,7 @@ object IDEInspectDlg: TIDEInspectDlg
       Style = tbsCheck
     end
     object btnColType: TToolButton
-      Left = 132
+      Left = 133
       Top = 2
       AllowAllUp = True
       Caption = 'T'
@@ -105,7 +106,7 @@ object IDEInspectDlg: TIDEInspectDlg
       Style = tbsCheck
     end
     object btnColVisibility: TToolButton
-      Left = 155
+      Left = 156
       Top = 2
       AllowAllUp = True
       Caption = 'V'
@@ -122,15 +123,15 @@ object IDEInspectDlg: TIDEInspectDlg
       OnClick = btnBackwardClick
     end
     object btnForward: TToolButton
-      Left = 25
+      Left = 24
       Top = 2
       Caption = '>>'
       OnClick = btnForwardClick
     end
     object ToolButton4: TToolButton
-      Left = 49
+      Left = 47
+      Height = 22
       Top = 2
-      Width = 5
       Caption = 'ToolButton4'
       Style = tbsDivider
     end

debugger/inspectdlg.pas

@@ -37,7 +37,7 @@ uses
   DbgIntfDebuggerBase, DbgIntfBaseTypes,
   // IDE
   LazarusIDEStrConsts, BaseDebugManager, InputHistory, IDEProcs,
-  Debugger, DebuggerDlg, DebuggerStrConst;
+  Debugger, DebuggerDlg, DebuggerStrConst, EnvironmentOpts;
 
 type
 
@@ -70,6 +70,7 @@ type
     procedure btnUseInstanceClick(Sender: TObject);
     procedure EdInspectEditingDone(Sender: TObject);
     procedure EdInspectKeyDown(Sender: TObject; var Key: Word; {%H-}Shift: TShiftState);
+    procedure FormActivate(Sender: TObject);
     procedure FormClose(Sender: TObject; var {%H-}CloseAction: TCloseAction);
     procedure FormCreate(Sender: TObject);
     procedure FormKeyDown(Sender: TObject; var Key: Word; {%H-}Shift: TShiftState);
@@ -833,6 +834,11 @@ begin
   InternalExecute(AExpression);
 end;
 
+procedure TIDEInspectDlg.FormActivate(Sender: TObject);
+begin
+  EdInspect.DropDownCount := EnvironmentOptions.DropDownCount;
+end;
+
 procedure TIDEInspectDlg.GotoHistory(AIndex: Integer);
 begin
   FHistoryIndex := AIndex;

designer/changeclassdialog.pas

@@ -43,7 +43,7 @@ uses
   // IdeIntf
   ComponentReg, PropEdits, ComponentEditors, FormEditingIntf, SrcEditorIntf, IDEDialogs,
   // IDE
-  LazarusIDEStrConsts, CheckLFMDlg, Project, MainIntf;
+  LazarusIDEStrConsts, CheckLFMDlg, Project, MainIntf, EnvironmentOpts;
 
 type
 
@@ -303,6 +303,7 @@ procedure TChangeClassDlg.ChangeClassDlgCreate(Sender: TObject);
 begin
   OldGroupBox.Caption:=lisOldClass;
   NewGroupBox.Caption:=lisNewClass;
+  NewClassComboBox.DropDownCount:=EnvironmentOptions.DropDownCount;
 end;
 
 procedure TChangeClassDlg.NewClassComboBoxEditingDone(Sender: TObject);

ide/extractprocdlg.pas

@@ -40,7 +40,7 @@ uses
   // IdeIntf
   IDEHelpIntf, IDEDialogs,
   // IDE
-  LazarusIDEStrConsts, MiscOptions;
+  LazarusIDEStrConsts, MiscOptions, EnvironmentOpts;
 
 type
 
@@ -191,6 +191,7 @@ begin
   FuncVariableLabel.Caption:=lisResult2;
   
   ButtonPanel.OkButton.Caption:=lisExtract;
+  FuncVariableComboBox.DropDownCount:=EnvironmentOptions.DropDownCount;
 end;
 
 procedure TExtractProcDialog.HelpButtonClick(Sender: TObject);

ide/ideoptionsdlg.pas

@@ -149,6 +149,7 @@ begin
   ButtonPanel.HelpButton.Caption:= lisMenuHelp;
   ButtonPanel.HelpButton.OnClick := @HelpButtonClick;
   IDEDialogLayoutList.ApplyLayout(Self);
+  BuildModeComboBox.DropDownCount := EnvironmentOptions.DropDownCount;
 end;
 
 procedure TIDEOptionsDialog.FormShow(Sender: TObject);

ide/mouseactiondialog.pas

@@ -6,7 +6,7 @@ interface
 
 uses
   Classes, Forms, Controls, ExtCtrls, StdCtrls, ButtonPanel, Spin, CheckLst,
-  SynEditMouseCmds, LazarusIDEStrConsts, KeyMapping, IDECommands, types;
+  SynEditMouseCmds, LazarusIDEStrConsts, KeyMapping, IDECommands, types, EnvironmentOpts;
 
 var
   ButtonName: Array [TSynMouseButton] of String;
@@ -180,6 +180,8 @@ begin
   BtnDefault.Caption :=  dlgMouseOptBtnModDef;
   PriorLabel.Caption := dlgMouseOptPriorLabel;
   Opt2Label.Caption := dlgMouseOptOpt2Label;
+  ActionBox.DropDownCount := EnvironmentOptions.DropDownCount;
+  OptBox.DropDownCount := EnvironmentOptions.DropDownCount;
 end;
 
 procedure TMouseaActionDialog.ResetInputs;

ide/syncolorattribeditor.pas

@@ -12,7 +12,7 @@ uses
   // SynEdit
   SynEditTypes, SynTextDrawer,
   // IDE
-  EditorOptions, SourceMarks, LazarusIDEStrConsts;
+  EditorOptions, SourceMarks, LazarusIDEStrConsts, EnvironmentOpts;
 
 type
 
@@ -768,6 +768,13 @@ constructor TSynColorAttrEditor.Create(TheOwner: TComponent);
 begin
   inherited Create(TheOwner);
   FShowPrior := False;
+  ForegroundColorBox.DropDownCount := EnvironmentOptions.DropDownCount;
+  BackGroundColorBox.DropDownCount := EnvironmentOptions.DropDownCount;
+  FrameColorBox.DropDownCount := EnvironmentOptions.DropDownCount;
+  FrameEdgesBox.DropDownCount := EnvironmentOptions.DropDownCount;
+  FrameStyleBox.DropDownCount := EnvironmentOptions.DropDownCount;
+  MarkupFoldColorBox.DropDownCount := EnvironmentOptions.DropDownCount;
+  MarkupFoldStyleBox.DropDownCount := EnvironmentOptions.DropDownCount;
 end;
 
 procedure TSynColorAttrEditor.Setup;

packager/addtopackagedlg.pas

@@ -268,6 +268,8 @@ begin
   fIconNormGUI:=TIconGuiStuff.Create(IconNormBitBtn, IconNormInfoLabel, lisA2PIcon24x24);
   fIcon150GUI:=TIconGuiStuff.Create(Icon150BitBtn, Icon150InfoLabel, lisA2PIcon36x36);
   fIcon200GUI:=TIconGuiStuff.Create(Icon200BitBtn, Icon200InfoLabel, lisA2PIcon48x48);
+  AncestorComboBox.DropDownCount:=EnvironmentOptions.DropDownCount;
+  PalettePageCombobox.DropDownCount:=EnvironmentOptions.DropDownCount;
 end;
 
 procedure TAddToPackageDlg.FormDestroy(Sender: TObject);