paweld/lazarus
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/lazarus/lazarus.git synced 2025-04-17 04:29:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

Codetools: Prevent error in identifier completion while defining a function. Issue #32972, patch by Włodzimierz Bień.

Browse Source
This commit is contained in:
Juha 2025-03-03 22:37:39 +02:00
parent cae8834e91
commit 6f6df5602b
1 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
components/codetools/identcompletiontool.pas
View File

@ -965,14 +965,6 @@ procedure TIdentifierList.Add(NewItem: TIdentifierListItem);
var
AnAVLNode: TAVLTreeNode;
begin
if (ilcfDontAllowProcedures in ContextFlags) and (NewItem.GetDesc = ctnProcedure) and
not (NewItem.IsFunction or NewItem.IsConstructor)
then
begin
NewItem.Free;
Exit;
end;
AnAVLNode:=FIdentView.FindKey(NewItem,@CompareIdentListItemsForIdents);
if AnAVLNode=nil then begin
if History<>nil then
@ -1368,12 +1360,9 @@ var
Node: TCodeTreeNode;
ProtectedForeignClass: Boolean;
Lvl: LongInt;
NamePos: TAtomPosition;
HasLowerVisibility: Boolean;
IsDottedIdent: Boolean;
PlaceForDotted: string;
PlaceForNamespace: string;
i: integer;
begin
// proceed searching ...
Result:=ifrProceedSearch;
@ -1512,9 +1501,16 @@ begin
exit; // there is a previous declaration without 'overload'
end;
end;
end else begin
if (CurrentIdentifierList.StartContext.Node.Parent<>nil) and
(CurrentIdentifierList.StartContext.Node.Parent.Parent=FoundContext.Node)
then begin // skip adding itself at function/procedure parameters definition
debugln(['TIdentCompletionTool.CollectAllIdentifiers ','skipped "',GetIdentifier(Ident),'"']);
exit;
end;
end;
end;
ctnProperty:
begin
Ident:=FoundContext.Tool.GetPropertyNameIdentifier(FoundContext.Node);