IDE: Cleanup.

git-svn-id: trunk@49280 -

components/IndustrialStuff/source/AdvLed.pas

@@ -19,7 +19,7 @@ unit AdvLed;
 interface
 
 uses
-  LCLIntf, LCLType,LResources,Classes, Types, ExtCtrls, Controls, Graphics;
+  LCLType, Classes, ExtCtrls, Controls, Graphics;
 
 type
 

components/IndustrialStuff/source/indcyClasses.pas

@@ -49,7 +49,7 @@ unit indcyClasses;
 interface
 
 uses
-   LCLIntf, LCLType, Classes, Forms, Graphics, Math, Controls, ExtCtrls, SysUtils,
+   LCLIntf, Classes, Graphics, Controls, SysUtils,
    indcyTypes, indcyGraphics;
 
 type

components/codetools/ide/codyregistration.pas

@@ -36,8 +36,7 @@ uses
   CodeToolManager,
   CodyStrConsts, CodyUtils, CodyCtrls, CodyOpts,
   PPUListDlg, AddAssignMethodDlg, AddWithBlockDlg,
-  CodyNodeInfoDlg, CodyFrm, DeclareVarDlg, CodyCopyDeclaration,
+  CodyNodeInfoDlg, CodyFrm, DeclareVarDlg, CodyIdentifiersDlg, CodyMiscOptsFrame;
-  CodyIdentifiersDlg, CodyMiscOptsFrame;
 
 procedure Register;
 

components/customdrawn/customdrawn_wince.pas

@@ -164,7 +164,6 @@ procedure TCDDrawerWinCE.DrawCheckBoxSquare(ADest: TCanvas; ADestPos: TPoint;
   ASize: TSize; AState: TCDControlState; AStateEx: TCDControlStateEx);
 var
   lHalf, lSquareHalf, lSquareHeight: Integer;
-  lColor: TColor;
 begin
   lHalf := ASize.cy div 2;
   lSquareHalf := GetMeasures(TCDCHECKBOX_SQUARE_HALF_HEIGHT);

components/customdrawn/customdrawnextras.pas

@@ -430,8 +430,6 @@ procedure TCDPageControlEditor.ExecuteVerb(Index: integer);
 var
   NewPage: TCDTabSheet;
   Hook: TPropertyEditorHook;
-  PageComponent: TPersistent;
-  OldPage: longint;
   lPageName: String;
 begin
   if not GetHook(Hook) then exit;

components/customform/custforms.pp

@@ -81,7 +81,7 @@ Type
   private
     FFormDescr: TCustomFormDescr;
   Public
-    Constructor Create(ADescr : TCustomFormDescr);
+    Constructor Create(ADescr : TCustomFormDescr); overload;
     Property FormDescr : TCustomFormDescr Read FFormDescr;
     Function GetLocalizedName : String; override;
     Function GetLocalizedDescription : String; override;

components/ideintf/maskpropedit.pas

@@ -18,7 +18,7 @@ unit MaskPropEdit;
 interface
 
 uses
-  Classes, SysUtils, MaskUtils, Forms, Controls, Graphics, Dialogs,
+  Classes, SysUtils, Forms, Controls, Graphics, Dialogs,
   StdCtrls, Buttons, ExtCtrls, FileUtil, MaskEdit, LazIDEIntf,
   PropEdits, ComponentEditors, ObjInspStrConsts, ButtonPanel;
 

components/jcf2/Process/Transform/AddBeginEnd.pas

@@ -129,7 +129,7 @@ function SafeToRemoveBeginEnd(const pcNode: TParseTreeNode): Boolean;
 const
   { if there is an if stament with no else case immediately hereunder,
   should find it by this depth }
-  IMMEDIATE_IF_DEPTH = 4;
+  //IMMEDIATE_IF_DEPTH = 4;
   MAX_IF_CLIMB = 5;
 var
   lcParent: TParseTreeNode;

components/jcf2/Ui/Settings/frAsm.pas

@@ -68,7 +68,7 @@ uses
   { jcf }
   JcfSettings, jcfuiconsts,
   { local }
-  Capitalisation, SettingsTypes, SetAsm;
+  SettingsTypes, SetAsm;
 
 procedure TfAsm.FrameResize(Sender:TObject);
 begin

components/jcf2/Ui/Settings/frPreProcessor.pas

@@ -31,8 +31,7 @@ interface
 { preprocessor symbols }
 
 uses
-  Classes, Controls, Forms, StdCtrls,
+  Classes, StdCtrls, IDEOptionsIntf;
-  IDEOptionsIntf;
 
 type
 
@@ -61,7 +60,7 @@ implementation
 {$R *.lfm}
 
 uses 
-  JcfHelp, JcfSettings, jcfuiconsts;
+  JcfSettings, jcfuiconsts;
 
 constructor TfPreProcessor.Create(AOwner: TComponent);
 begin

converter/usedunits.pas

@@ -61,7 +61,7 @@ type
     fUnitsToFixCase: TStringToStringTree;// Like rename but done for every target.
     fUnitsToComment: TStringList;        // List of units to be commented.
     fMissingUnits: TStringList;          // Units not found in search path.
-    function FindMissingUnits(AUnitUpdater: TStringMapUpdater): boolean;
+    function FindMissingUnits: boolean;
     procedure ToBeRenamedOrRemoved(AOldName, ANewName: string);
     procedure FindReplacement(AUnitUpdater: TStringMapUpdater;
                               AMapToEdit: TStringToStringTree);
@@ -210,7 +210,7 @@ begin
   inherited Destroy;
 end;
 
-function TUsedUnits.FindMissingUnits(AUnitUpdater: TStringMapUpdater): boolean;
+function TUsedUnits.FindMissingUnits: boolean;
 var
   UsesNode: TCodeTreeNode;
   InAtom, UnitNameAtom: TAtomPosition;
@@ -595,8 +595,8 @@ begin
     if fCTLink.Settings.UnitsReplaceMode=rlInteractive then
       MapToEdit:=TStringToStringTree.Create(false);
     fCTLink.CodeTool.BuildTree(lsrEnd);
-    if not (fMainUsedUnits.FindMissingUnits(UnitUpdater) and
+    if not (fMainUsedUnits.FindMissingUnits and
-            fImplUsedUnits.FindMissingUnits(UnitUpdater)) then
+            fImplUsedUnits.FindMissingUnits) then
       exit(mrCancel);
 
     // Find replacements for missing units from settings.

debugger/inspectdlg.pas

@@ -104,7 +104,7 @@ type
   protected
     function  ColSizeGetter(AColId: Integer; var ASize: Integer): Boolean;
     procedure ColSizeSetter(AColId: Integer; ASize: Integer);
-    procedure InternalExecute(const AExpression: ansistring; ARepeatCount: Integer = -1);
+    procedure InternalExecute(const AExpression: ansistring);
   public
     constructor Create(AOwner: TComponent); override;
     destructor Destroy; override;
@@ -790,7 +790,7 @@ begin
   inherited Destroy;
 end;
 
-procedure TIDEInspectDlg.InternalExecute(const AExpression: ansistring; ARepeatCount: Integer);
+procedure TIDEInspectDlg.InternalExecute(const AExpression: ansistring);
 begin
   if FHistoryIndex >= FHistory.Count then
     FHistoryIndex := FHistory.Count - 1;

ide/codetemplatesdlg.pas

@@ -208,7 +208,7 @@ begin
 end;
 
 function IsCodeTemplateOk(ASynAutoComplete: TSynEditAutoComplete;
-  const AToken, AComment: string; AIndex: integer): boolean;
+  const AToken: string; AIndex: integer): boolean;
 var
   n: integer;
 begin
@@ -238,8 +238,7 @@ begin
 
   if InputQuery(lisCodeTemplAddCodeTemplate,
     [lisCodeTemplToken, lisCodeTemplComment], Str) then
-    if IsCodeTemplateOk(ASynAutoComplete,
+    if IsCodeTemplateOk(ASynAutoComplete, Str[0], ASynAutoComplete.Completions.Count) then
-         Str[0], Str[1], ASynAutoComplete.Completions.Count) then
       begin
         Result:= mrOk;
         AToken:= Str[0];
@@ -262,8 +261,7 @@ begin
   if not InputQuery(lisCodeTemplEditCodeTemplate,
     [lisCodeTemplToken, lisCodeTemplComment], Str) then exit;
 
-  if not IsCodeTemplateOk(ASynAutoComplete,
+  if not IsCodeTemplateOk(ASynAutoComplete, Str[0], AIndex) then exit;
-    Str[0], Str[1], AIndex) then exit;
 
   ASynAutoComplete.Completions[AIndex]:= Str[0];
   ASynAutoComplete.CompletionComments[AIndex]:= Str[1];

ide/etquickfixes.pas

@@ -351,7 +351,7 @@ begin
   Code:=CodeToolBoss.LoadFile(Msg.GetFullFilename,true,false);
   if Code=nil then exit;
 
-  if QuickFixLocalVarNotInitialized(Code,Msg.Column,Msg.Line,Identifier) then
+  if QuickFixLocalVarNotInitialized(Code, Msg.Column, Msg.Line) then
     Msg.MarkFixed;
 end;
 

ide/mouseactiondialog.pas

@@ -136,7 +136,6 @@ procedure TMouseaActionDialog.FormCreate(Sender: TObject);
 var
   mb: TSynMouseButton;
   cc: TSynMAClickCount;
-  s: string;
 begin
   ButtonName[mbXLeft]:=dlgMouseOptBtnLeft;
   ButtonName[mbXRight]:=dlgMouseOptBtnRight;

ide/qfinitlocalvardlg.pas

@@ -57,13 +57,11 @@ type
     procedure Init(TheStatements: TStrings; TheInsertPositions: TObjectList);
   end;
 
-function QuickFixLocalVarNotInitialized(Code: TCodeBuffer; X, Y: integer;
+function QuickFixLocalVarNotInitialized(Code: TCodeBuffer; X, Y: integer): boolean;
-  Identifier: string): boolean;
 
 implementation
 
-function QuickFixLocalVarNotInitialized(Code: TCodeBuffer; X, Y: integer;
+function QuickFixLocalVarNotInitialized(Code: TCodeBuffer; X, Y: integer): boolean;
-  Identifier: string): boolean;
 var
   Statements: TStrings;
   InsertPositions: TObjectList;