IDE: improved external tool editor dialog layout, bug #28067

git-svn-id: trunk@49001 -

ide/exttooleditdlg.lfm

@@ -12,15 +12,15 @@ object ExternalToolOptionDlg: TExternalToolOptionDlg
   OnCreate = FormCreate
   OnDestroy = FormDestroy
   Position = poScreenCenter
-  LCLVersion = '1.1'
+  LCLVersion = '1.5'
   object TitleLabel: TLabel
     AnchorSideLeft.Control = Owner
     AnchorSideTop.Control = TitleEdit
     AnchorSideTop.Side = asrCenter
     Left = 6
-    Height = 15
+    Height = 13
     Top = 10
-    Width = 59
+    Width = 45
     BorderSpacing.Left = 6
     Caption = 'TitleLabel'
     ParentColor = False
@@ -30,9 +30,9 @@ object ExternalToolOptionDlg: TExternalToolOptionDlg
     AnchorSideTop.Control = FilenameEdit
     AnchorSideTop.Side = asrCenter
     Left = 6
-    Height = 15
-    Top = 39
-    Width = 88
+    Height = 13
+    Top = 37
+    Width = 67
     BorderSpacing.Left = 6
     Caption = 'FilenameLabel'
     ParentColor = False
@@ -42,9 +42,9 @@ object ExternalToolOptionDlg: TExternalToolOptionDlg
     AnchorSideTop.Control = MemoParameters
     AnchorSideTop.Side = asrCenter
     Left = 6
-    Height = 15
-    Top = 102
-    Width = 105
+    Height = 13
+    Top = 99
+    Width = 80
     BorderSpacing.Left = 6
     Caption = 'ParametersLabel'
     ParentColor = False
@@ -54,22 +54,25 @@ object ExternalToolOptionDlg: TExternalToolOptionDlg
     AnchorSideTop.Control = WorkingDirEdit
     AnchorSideTop.Side = asrCenter
     Left = 6
-    Height = 15
-    Top = 164
-    Width = 99
+    Height = 13
+    Top = 160
+    Width = 77
     BorderSpacing.Left = 6
     Caption = 'WorkingDirLabel'
     ParentColor = False
   end
   object TitleEdit: TEdit
+    AnchorSideLeft.Control = FilenameLabel
+    AnchorSideLeft.Side = asrBottom
     AnchorSideTop.Control = Owner
     AnchorSideRight.Control = Owner
     AnchorSideRight.Side = asrBottom
-    Left = 128
-    Height = 23
+    Left = 103
+    Height = 21
     Top = 6
-    Width = 527
+    Width = 552
     Anchors = [akTop, akLeft, akRight]
+    BorderSpacing.Left = 24
     BorderSpacing.Around = 6
     TabOrder = 0
     Text = 'TitleEdit'
@@ -79,10 +82,10 @@ object ExternalToolOptionDlg: TExternalToolOptionDlg
     AnchorSideTop.Control = TitleEdit
     AnchorSideTop.Side = asrBottom
     AnchorSideRight.Control = OpenButton
-    Left = 128
-    Height = 23
-    Top = 35
-    Width = 496
+    Left = 103
+    Height = 21
+    Top = 33
+    Width = 508
     Anchors = [akTop, akLeft, akRight]
     BorderSpacing.Top = 6
     BorderSpacing.Right = 6
@@ -95,10 +98,10 @@ object ExternalToolOptionDlg: TExternalToolOptionDlg
     AnchorSideRight.Side = asrBottom
     AnchorSideBottom.Control = FilenameEdit
     AnchorSideBottom.Side = asrBottom
-    Left = 630
-    Height = 23
-    Top = 35
-    Width = 25
+    Left = 617
+    Height = 21
+    Top = 33
+    Width = 38
     Anchors = [akTop, akRight, akBottom]
     AutoSize = True
     BorderSpacing.Right = 6
@@ -114,10 +117,10 @@ object ExternalToolOptionDlg: TExternalToolOptionDlg
     AnchorSideTop.Side = asrBottom
     AnchorSideRight.Control = Owner
     AnchorSideRight.Side = asrBottom
-    Left = 128
-    Height = 23
-    Top = 160
-    Width = 527
+    Left = 103
+    Height = 21
+    Top = 156
+    Width = 552
     Anchors = [akTop, akLeft, akRight]
     BorderSpacing.Top = 6
     BorderSpacing.Right = 6
@@ -131,8 +134,8 @@ object ExternalToolOptionDlg: TExternalToolOptionDlg
     AnchorSideRight.Control = Owner
     AnchorSideRight.Side = asrBottom
     Left = 6
-    Height = 124
-    Top = 189
+    Height = 105
+    Top = 183
     Width = 649
     Anchors = [akTop, akLeft, akRight]
     AutoSize = True
@@ -140,14 +143,14 @@ object ExternalToolOptionDlg: TExternalToolOptionDlg
     Caption = 'OptionsGroupBox'
     ChildSizing.Layout = cclTopToBottomThenLeftToRight
     ChildSizing.ControlsPerLine = 5
-    ClientHeight = 95
-    ClientWidth = 643
+    ClientHeight = 87
+    ClientWidth = 645
     TabOrder = 4
     object OptionScanOutputForFPCMessagesCheckBox: TCheckBox
       Left = 6
-      Height = 21
+      Height = 17
       Top = 6
-      Width = 316
+      Width = 242
       BorderSpacing.Around = 6
       Caption = 'OptionScanOutputForFPCMessagesCheckBox'
       TabOrder = 0
@@ -156,9 +159,9 @@ object ExternalToolOptionDlg: TExternalToolOptionDlg
       AnchorSideTop.Side = asrBottom
       AnchorSideBottom.Side = asrBottom
       Left = 6
-      Height = 21
-      Top = 33
-      Width = 316
+      Height = 17
+      Top = 29
+      Width = 242
       BorderSpacing.Around = 6
       Caption = 'OptionScanOutputForMakeMessagesCheckBox'
       TabOrder = 1
@@ -169,21 +172,20 @@ object ExternalToolOptionDlg: TExternalToolOptionDlg
       AnchorSideTop.Side = asrBottom
       Left = 6
       Height = 29
-      Top = 60
+      Top = 52
       Width = 323
       BorderSpacing.Around = 6
       Caption = 'ScannersButton'
-      OnClick = ScannersButtonClick
       TabOrder = 2
     end
     object chkHideMainForm: TCheckBox
       AnchorSideLeft.Control = OptionScanOutputForFPCMessagesCheckBox
       AnchorSideLeft.Side = asrBottom
       AnchorSideTop.Control = OptionScanOutputForFPCMessagesCheckBox
-      Left = 328
-      Height = 21
+      Left = 254
+      Height = 17
       Top = 6
-      Width = 135
+      Width = 101
       BorderSpacing.Left = 6
       Caption = 'chkHideMainForm'
       TabOrder = 3
@@ -196,8 +198,8 @@ object ExternalToolOptionDlg: TExternalToolOptionDlg
     AnchorSideRight.Control = OptionsGroupBox
     AnchorSideRight.Side = asrBottom
     Left = 6
-    Height = 78
-    Top = 319
+    Height = 25
+    Top = 294
     Width = 649
     Anchors = [akTop, akLeft, akRight]
     AutoSize = True
@@ -214,14 +216,14 @@ object ExternalToolOptionDlg: TExternalToolOptionDlg
     AnchorSideRight.Side = asrBottom
     AnchorSideBottom.Control = ButtonPanel
     Left = 6
-    Height = 151
-    Top = 403
+    Height = 229
+    Top = 325
     Width = 649
     Anchors = [akTop, akLeft, akRight, akBottom]
     BorderSpacing.Around = 6
     Caption = 'MacrosGroupbox'
-    ClientHeight = 122
-    ClientWidth = 643
+    ClientHeight = 211
+    ClientWidth = 645
     TabOrder = 6
     object MacrosListbox: TListBox
       AnchorSideLeft.Control = MacrosGroupbox
@@ -230,9 +232,9 @@ object ExternalToolOptionDlg: TExternalToolOptionDlg
       AnchorSideBottom.Control = MacrosGroupbox
       AnchorSideBottom.Side = asrBottom
       Left = 6
-      Height = 114
+      Height = 203
       Top = 2
-      Width = 489
+      Width = 506
       Anchors = [akTop, akLeft, akRight, akBottom]
       BorderSpacing.Left = 6
       BorderSpacing.Right = 6
@@ -246,10 +248,10 @@ object ExternalToolOptionDlg: TExternalToolOptionDlg
       AnchorSideTop.Control = MacrosGroupbox
       AnchorSideRight.Control = MacrosGroupbox
       AnchorSideRight.Side = asrBottom
-      Left = 501
-      Height = 24
+      Left = 518
+      Height = 23
       Top = 2
-      Width = 136
+      Width = 121
       Anchors = [akTop, akRight]
       AutoSize = True
       BorderSpacing.Top = 2
@@ -286,10 +288,10 @@ object ExternalToolOptionDlg: TExternalToolOptionDlg
     AnchorSideTop.Side = asrBottom
     AnchorSideRight.Control = Owner
     AnchorSideRight.Side = asrBottom
-    Left = 128
+    Left = 103
     Height = 90
-    Top = 64
-    Width = 527
+    Top = 60
+    Width = 552
     Anchors = [akTop, akLeft, akRight]
     BorderSpacing.Top = 6
     BorderSpacing.Right = 6

ide/exttooleditdlg.pas

@@ -171,7 +171,6 @@ type
     procedure MacrosListboxDblClick(Sender: TObject);
     procedure OKButtonClick(Sender: TObject);
     procedure OpenButtonClick({%H-}sender : TOBject);
-    procedure ScannersButtonClick(Sender: TObject);
   private
     fAllKeys: TKeyCommandRelationList;
     fOptions: TExternalUserTool;
@@ -657,10 +656,6 @@ begin
   if OpenDialog.Execute then FilenameEdit.Text := OpenDialog.FileName;
 End;
 
-procedure TExternalToolOptionDlg.ScannersButtonClick(Sender: TObject);
-begin
-end;
-
 procedure TExternalToolOptionDlg.LoadFromOptions;
 begin
   TitleEdit.Text:=fOptions.Title;