paweld/lazarus
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/lazarus/lazarus.git synced 2025-08-14 17:19:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

IDE: Reserve name "On..." for events. Rename handler methods as "...Handler".

Browse Source 
git-svn-id: trunk@62192 -
This commit is contained in:
juha 2019-11-04 22:37:58 +00:00
parent 7d7fd26ec7
commit 78ec55ea05
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
ide/project.pp
View File

@ -793,11 +793,11 @@ type
function GetUseLegacyLists: Boolean; function GetUseLegacyLists: Boolean;
function JumpHistoryCheckPosition( function JumpHistoryCheckPosition(
APosition:TProjectJumpHistoryPosition): boolean; APosition:TProjectJumpHistoryPosition): boolean;
function OnUnitFileBackup(const Filename: string): TModalResult;
procedure ClearSourceDirectories; procedure ClearSourceDirectories;
procedure EmbeddedObjectModified(Sender: TObject); procedure EmbeddedObjectModified(Sender: TObject);
procedure OnLoadSaveFilename(var AFilename: string; Load: boolean); function FileBackupHandler(const Filename: string): TModalResult;
procedure OnUnitNameChange(AnUnitInfo: TUnitInfo; procedure LoadSaveFilenameHandler(var AFilename: string; Load: boolean);
procedure UnitNameChangeHandler(AnUnitInfo: TUnitInfo;
const OldUnitName, NewUnitName: string; const OldUnitName, NewUnitName: string;
CheckIfAllowed: boolean; var Allowed: boolean); CheckIfAllowed: boolean; var Allowed: boolean);
procedure SetActiveBuildMode(const AValue: TProjectBuildMode); procedure SetActiveBuildMode(const AValue: TProjectBuildMode);
@ -2706,7 +2706,7 @@ begin
FFlags:=DefaultProjectFlags; FFlags:=DefaultProjectFlags;
FJumpHistory:=TProjectJumpHistory.Create; FJumpHistory:=TProjectJumpHistory.Create;
FJumpHistory.OnCheckPosition:=@JumpHistoryCheckPosition; FJumpHistory.OnCheckPosition:=@JumpHistoryCheckPosition;
FJumpHistory.OnLoadSaveFilename:=@OnLoadSaveFilename; FJumpHistory.OnLoadSaveFilename:=@LoadSaveFilenameHandler;
fMainUnitID := -1; fMainUnitID := -1;
fProjectInfoFile := ''; fProjectInfoFile := '';
ProjectSessionFile:=''; ProjectSessionFile:='';
@ -2851,7 +2851,7 @@ begin
for i := 0 to NewUnitCount - 1 do begin for i := 0 to NewUnitCount - 1 do begin
SubPath:=Path+'Units/'+FXMLConfig.GetListItemXPath('Unit', i, LegacyList)+'/'; SubPath:=Path+'Units/'+FXMLConfig.GetListItemXPath('Unit', i, LegacyList)+'/';
NewUnitFilename:=FXMLConfig.GetValue(SubPath+'Filename/Value',''); NewUnitFilename:=FXMLConfig.GetValue(SubPath+'Filename/Value','');
OnLoadSaveFilename(NewUnitFilename,true); LoadSaveFilenameHandler(NewUnitFilename,true);
// load unit and add it // load unit and add it
OldUnitInfo:=UnitInfoWithFilename(NewUnitFilename); OldUnitInfo:=UnitInfoWithFilename(NewUnitFilename);
if OldUnitInfo<>nil then begin if OldUnitInfo<>nil then begin
@ -3598,9 +3598,9 @@ begin
NewIndex:=UnitCount; NewIndex:=UnitCount;
FUnitList.Add(AnUnit); FUnitList.Add(AnUnit);
AnUnit.Project:=Self; AnUnit.Project:=Self;
AnUnit.OnFileBackup:=@OnUnitFileBackup; AnUnit.OnFileBackup:=@FileBackupHandler;
AnUnit.OnLoadSaveFilename:=@OnLoadSaveFilename; AnUnit.OnLoadSaveFilename:=@LoadSaveFilenameHandler;
AnUnit.OnUnitNameChange:=@OnUnitNameChange; AnUnit.OnUnitNameChange:=@UnitNameChangeHandler;
// lock the main unit (when it is changed on disk it must *not* auto revert) // lock the main unit (when it is changed on disk it must *not* auto revert)
if MainUnitID=NewIndex then if MainUnitID=NewIndex then
@ -4120,12 +4120,12 @@ end;
procedure TProject.ConvertToLPIFilename(var AFilename: string); procedure TProject.ConvertToLPIFilename(var AFilename: string);
begin begin
OnLoadSaveFilename(AFilename,false); LoadSaveFilenameHandler(AFilename,false);
end; end;
procedure TProject.ConvertFromLPIFilename(var AFilename: string); procedure TProject.ConvertFromLPIFilename(var AFilename: string);
begin begin
OnLoadSaveFilename(AFilename,true); LoadSaveFilenameHandler(AFilename,true);
end; end;
function TProject.GetMainResourceFilename(AnUnitInfo: TUnitInfo):string; function TProject.GetMainResourceFilename(AnUnitInfo: TUnitInfo):string;
@ -4358,7 +4358,7 @@ begin
UpdateSessionFilename; UpdateSessionFilename;
end; end;
function TProject.OnUnitFileBackup(const Filename: string): TModalResult; function TProject.FileBackupHandler(const Filename: string): TModalResult;
begin begin
if Assigned(fOnFileBackup) then if Assigned(fOnFileBackup) then
Result:=fOnFileBackup(Filename) Result:=fOnFileBackup(Filename)
@ -4366,7 +4366,7 @@ begin
Result:=mrOk; Result:=mrOk;
end; end;
procedure TProject.OnLoadSaveFilename(var AFilename: string; Load:boolean); procedure TProject.LoadSaveFilenameHandler(var AFilename: string; Load:boolean);
{ This function is used after reading a filename from the config { This function is used after reading a filename from the config
and before writing a filename to a config. and before writing a filename to a config.
The config can be the lpi or the session. The config can be the lpi or the session.
@ -5223,7 +5223,7 @@ begin
SessionModified := true; SessionModified := true;
end; end;
procedure TProject.OnUnitNameChange(AnUnitInfo: TUnitInfo; procedure TProject.UnitNameChangeHandler(AnUnitInfo: TUnitInfo;
const OldUnitName, NewUnitName: string; CheckIfAllowed: boolean; const OldUnitName, NewUnitName: string; CheckIfAllowed: boolean;
var Allowed: boolean); var Allowed: boolean);
var var