From 83ef9dce8646d733934475100c529536eae3a3f5 Mon Sep 17 00:00:00 2001
From: Martin <laz.git@mfriebe.de>
Date: Thu, 20 Mar 2025 21:12:00 +0100
Subject: [PATCH] IDE: fix translations for color opts, broken in
 900e58ed4f410693a56897c64baf32f4c5e2a74d by too early init.

---
 .../ideintf/editorsyntaxhighlighterdef.pas    | 26 ++++++++++++++++++-
 components/todolist/todosynmarkup.pas         |  8 +++++-
 ide/editoroptions.pp                          |  3 ++-
 3 files changed, 34 insertions(+), 3 deletions(-)

diff --git a/components/ideintf/editorsyntaxhighlighterdef.pas b/components/ideintf/editorsyntaxhighlighterdef.pas
index 1a275a344b..70115679d3 100644
--- a/components/ideintf/editorsyntaxhighlighterdef.pas
+++ b/components/ideintf/editorsyntaxhighlighterdef.pas
@@ -6,7 +6,7 @@ unit EditorSyntaxHighlighterDef;
 interface
 
 uses
-  Classes, SysUtils;
+  Classes, SysUtils, LazMethodList;
 
 type
   TLazSyntaxHighlighter =
@@ -121,6 +121,10 @@ var
   IdeSyntaxHighlighters: TIdeSyntaxHighlighterList;
   IdeColorSchemeList: IColorSchemeList;
 
+procedure RegisterOnIdeColorSchemeListCreated(AnHandler: TNotifyEvent);
+procedure _IDE_CallOnIdeColorSchemeListCreated;
+
+
 implementation
 
 function GetSyntaxHighlighterCaption(h: TLazSyntaxHighlighter): string;
@@ -133,5 +137,25 @@ begin
   Result := IdeSyntaxHighlighters.GetLazSyntaxHighlighterType(IdeSyntaxHighlighters.GetIdForName(s)){%H-};
 end;
 
+var
+  OnIdeColorSchemeListCreated: TMethodList;
+procedure RegisterOnIdeColorSchemeListCreated(AnHandler: TNotifyEvent);
+begin
+  if IdeColorSchemeList <> nil then begin
+    AnHandler(nil);
+    exit;
+  end;
+
+  if OnIdeColorSchemeListCreated = nil then
+    OnIdeColorSchemeListCreated := TMethodList.Create;
+  OnIdeColorSchemeListCreated.Add(TMethod(AnHandler));
+end;
+
+procedure _IDE_CallOnIdeColorSchemeListCreated;
+begin
+  OnIdeColorSchemeListCreated.CallNotifyEvents(nil);
+  FreeAndNil(OnIdeColorSchemeListCreated);
+end;
+
 end.
 
diff --git a/components/todolist/todosynmarkup.pas b/components/todolist/todosynmarkup.pas
index 15861c8eed..85b94c4034 100644
--- a/components/todolist/todosynmarkup.pas
+++ b/components/todolist/todosynmarkup.pas
@@ -60,6 +60,7 @@ type
   TTodoEditorHandler = class
     procedure DoEditorCreated(Sender: TObject);
     procedure DoColorsChanged(Sender: TObject);
+    procedure DoRegisterAttribs(Sender: TObject);
   end;
 
 var
@@ -131,6 +132,11 @@ begin
   attr.ApplyTo(CommentAttribNote);
 end;
 
+procedure TTodoEditorHandler.DoRegisterAttribs(Sender: TObject);
+begin
+  RegisterAttribs;
+end;
+
 { TSynEditTodoMarkup }
 
 procedure TSynEditTodoMarkup.BeginMarkup;
@@ -536,7 +542,7 @@ begin
 end;
 
 initialization
-  RegisterAttribs;
+  RegisterOnIdeColorSchemeListCreated(@TTodoEditorHandler(nil).DoRegisterAttribs);
 finalization
   FreeAttribs;
 end.
diff --git a/ide/editoroptions.pp b/ide/editoroptions.pp
index 7dfaf230a9..b1fe9556bd 100644
--- a/ide/editoroptions.pp
+++ b/ide/editoroptions.pp
@@ -2947,6 +2947,8 @@ begin
       FileList.Free;
     end;
   end;
+  IdeColorSchemeList := Singleton;
+  _IDE_CallOnIdeColorSchemeListCreated;
   Result := Singleton;
 end;
 
@@ -8436,7 +8438,6 @@ end;
 initialization
   RegisterIDEOptionsGroup(GroupEditor, TEditorOptions);
   IdeSyntaxHighlighters := HighlighterList;
-  IdeColorSchemeList := ColorSchemeFactory;
 
 finalization
   IdeColorSchemeList := nil;