From 906384cc9d0dade1142aead17a5e74b813394f27 Mon Sep 17 00:00:00 2001
From: Martin <laz.git@mfriebe.de>
Date: Mon, 23 Sep 2024 12:37:31 +0200
Subject: [PATCH] Add deprecated for old names. More fixes.

---
 components/ideintf/idewindowintf.pas       | 1 +
 components/synedit/lazsynedittext.pas      | 6 ++++++
 components/synedit/synbeautifierpascal.pas | 2 +-
 components/synedit/synedit.pp              | 2 +-
 components/synedit/syneditfoldedview.pp    | 6 +++---
 components/synedit/synedittextbuffer.pp    | 6 ++++++
 lcl/interfaces/gtk3/gtk3widgets.pas        | 2 +-
 test/lcltests/testpagecontrol.pas          | 2 +-
 8 files changed, 20 insertions(+), 7 deletions(-)

diff --git a/components/ideintf/idewindowintf.pas b/components/ideintf/idewindowintf.pas
index 70ad66dc2b..21b20efa27 100644
--- a/components/ideintf/idewindowintf.pas
+++ b/components/ideintf/idewindowintf.pas
@@ -248,6 +248,7 @@ type
     vmNeverMoveToVisible,
     vmOnlyMoveOffScreenToVisible   // Only make visible, if offscreen (with a threshold)
   );
+  TLayoutMoveToVisbleMode = TLayoutMoveToVisibleMode deprecated 'Use "TLayoutMoveToVisibleMode" / Will be removed in 4.99';
 
   TSimpleWindowLayoutList = class
   private
diff --git a/components/synedit/lazsynedittext.pas b/components/synedit/lazsynedittext.pas
index 1cb1a7a10c..ef90a48a87 100644
--- a/components/synedit/lazsynedittext.pas
+++ b/components/synedit/lazsynedittext.pas
@@ -507,6 +507,7 @@ type
     procedure AddEditHandler(AHandler: TStringListLineEditEvent);
     procedure RemoveEditHandler(AHandler: TStringListLineEditEvent);
 
+    procedure RemoveHanlders(AOwner: TObject); deprecated 'Use "RemoveHandlers" / Will be removed in 4.99';
     procedure RemoveHandlers(AOwner: TObject);
 
     //function GetPhysicalCharWidths(Line: PChar; LineLen, Index: Integer): TPhysicalCharWidths; override;
@@ -1784,6 +1785,11 @@ begin
   RemoveGenericHandler(senrEditAction, TMethod(AHandler));
 end;
 
+procedure TSynEditStringsLinked.RemoveHanlders(AOwner: TObject);
+begin
+  RemoveHandlers(AOwner);
+end;
+
 procedure TSynEditStringsLinked.RemoveHandlers(AOwner: TObject);
 begin
   Manager.RemoveHandlers(AOwner);
diff --git a/components/synedit/synbeautifierpascal.pas b/components/synedit/synbeautifierpascal.pas
index ab56690dd5..e9b322ceac 100644
--- a/components/synedit/synbeautifierpascal.pas
+++ b/components/synedit/synbeautifierpascal.pas
@@ -804,7 +804,7 @@ begin
     CommentStartsAtBOL := GetCommentStartCol = 1 + GetIndentForLine(nil, CurrentLines[ToIdx(GetFirstCommentLine)], False);
 
 
-  // Aply indent before prefix
+  // Apply indent before prefix
   if Matching or (FCommentMode[FoldTyp] = sccPrefixAlways) or (sciApplyIndentForNoMatch in FIndentMode[FoldTyp])
   then begin
     IndentTypeBackup := IndentType;
diff --git a/components/synedit/synedit.pp b/components/synedit/synedit.pp
index 6f9661abef..ccaa903dd7 100644
--- a/components/synedit/synedit.pp
+++ b/components/synedit/synedit.pp
@@ -2050,7 +2050,7 @@ end;
 function TCustomSynEdit.RowToScreenRow(PhysicalRow: integer): integer;
 // returns -1 for lines above visible screen (<TopLine)
 // 0 for the first line
-// 0 to LinesInWindow for visible lines (incl last partial visble line)
+// 0 to LinesInWindow for visible lines (incl last partial visible line)
 // and returns LinesInWindow+1 for lines below visible screen
 begin
   Result := ToPos(FTheLinesView.TextToViewIndex(ToIdx(PhysicalRow))) - TopView;
diff --git a/components/synedit/syneditfoldedview.pp b/components/synedit/syneditfoldedview.pp
index 2f643fe6c0..de600cd594 100644
--- a/components/synedit/syneditfoldedview.pp
+++ b/components/synedit/syneditfoldedview.pp
@@ -3642,7 +3642,7 @@ begin
   if not assigned(hl) then
     exit(0);
   // AStartIndex is 0-based
-  // FoldTree is 1-based AND first line remains visble
+  // FoldTree is 1-based AND first line remains visible
   c := hl.FoldNodeInfo[AStartIndex].CountEx([sfaOpen, sfaFold]);
   if c = 0 then
     exit(-1);
@@ -4001,7 +4001,7 @@ begin
   top := TopTextIndex;
 
   // AStartIndex is 0-based
-  // FoldTree is 1-based AND first line remains visble
+  // FoldTree is 1-based AND first line remains visible
   NodeCount := FoldProvider.FoldOpenCount(AStartIndex);
   if ColCount = 0 then
     ColCount := NodeCount;
@@ -4170,7 +4170,7 @@ begin
       c := hl.FoldBlockOpeningCount(i) -1;
       fldinf := FoldProvider.InfoForFoldAtTextIndex(i, c);
       // i is 0-based
-      // FoldTree is 1-based AND first line remains visble
+      // FoldTree is 1-based AND first line remains visible
       fFoldTree.InsertNewFold(i+2, c, fldinf.Column, fldinf.ColumnLen, fldinf.LineCount, 1,
                               fldinf.Classification, fldinf.FoldTypeCompatible); // TODO: hide too? currently VisibleLines=1
       if IgnoreNested then
diff --git a/components/synedit/synedittextbuffer.pp b/components/synedit/synedittextbuffer.pp
index c43822a6ff..1a827045f0 100644
--- a/components/synedit/synedittextbuffer.pp
+++ b/components/synedit/synedittextbuffer.pp
@@ -241,6 +241,7 @@ type
     procedure DetachSynEdit(AEdit: TSynEditBase);
     function  AttachedSynEditCount: Integer;
     property  AttachedSynEdits[Index: Integer]: TSynEditBase read GetAttachedSynEdits;
+    procedure CopyHanlders(OtherLines: TSynEditStringList; AOwner: TObject = nil); deprecated 'Use "CopyHandlers" / Will be removed in 4.99';
     procedure CopyHandlers(OtherLines: TSynEditStringList; AOwner: TObject = nil);
     procedure SendCachedNotify; // ToDO: review caching versus changes to topline and other values
   public
@@ -1047,6 +1048,11 @@ begin
   Result := FAttachedSynEditList.Count;
 end;
 
+procedure TSynEditStringList.CopyHanlders(OtherLines: TSynEditStringList; AOwner: TObject);
+begin
+  CopyHandlers(OtherLines, AOwner);
+end;
+
 function TSynEditStringList.GetObject(Index: integer): TObject;
 begin
   if (Index >= 0) and (Index < Count) then
diff --git a/lcl/interfaces/gtk3/gtk3widgets.pas b/lcl/interfaces/gtk3/gtk3widgets.pas
index 43c88d2884..2d03c59368 100644
--- a/lcl/interfaces/gtk3/gtk3widgets.pas
+++ b/lcl/interfaces/gtk3/gtk3widgets.pas
@@ -4521,7 +4521,7 @@ begin
   FPageLabel:= TGtkLabel.new(PChar(Params.Caption));
   FPageLabel^.set_use_underline(true);
   Self.FHasPaint:=true;
-  // ref it to save it in case TabVisble is set to false
+  // ref it to save it in case TabVisible is set to false
   FPageLabel^.ref;
   Result := TGtkHBox.new(GTK_ORIENTATION_HORIZONTAL, 0);
   FCentralWidget := TGtkFixed.new;
diff --git a/test/lcltests/testpagecontrol.pas b/test/lcltests/testpagecontrol.pas
index b9c8723a6e..73a0ad0778 100644
--- a/test/lcltests/testpagecontrol.pas
+++ b/test/lcltests/testpagecontrol.pas
@@ -820,7 +820,7 @@ begin
   s3.TabVisible := False;
   Application.ProcessMessages;
 
-  // TabRect takes an indek into VISBLE-only tabs
+  // TabRect takes an indek into VISIBLE-only tabs
   T2Recta := PageControl.TabRect(2); // the old tab 2, since tab3 is hidden
   T2RectaScr.TopLeft := PageControl.ClientToScreen(T2Recta.TopLeft);
   T2RectaScr.BottomRight := PageControl.ClientToScreen(T2Recta.BottomRight);