Packager: Cleaning up unnecessary help button code

This commit is contained in:
n7800 2025-06-22 15:55:15 +05:00 committed by Maxim Ganetsky
parent 9fcc2caf10
commit 975c46a7fa
6 changed files with 5 additions and 32 deletions

View File

@ -45,7 +45,7 @@ uses
// LazUtils
FileUtil, LazFileUtils,
// IdeIntf
IdeIntfStrConsts, IDEWindowIntf, PackageIntf, IDEHelpIntf,
IdeIntfStrConsts, IDEWindowIntf, PackageIntf,
// IDE
LazarusIDEStrConsts, PackageDefs, PackageSystem, EnvironmentOpts;
@ -63,7 +63,6 @@ type
procedure AddFileToAPackageDlgClose(Sender: TObject;
var {%H-}CloseAction: TCloseAction);
procedure FormCreate(Sender: TObject);
procedure HelpButtonClick(Sender: TObject);
procedure OkButtonClick(Sender: TObject);
procedure PackagesGroupBoxResize(Sender: TObject);
procedure ShowAllCheckBoxClick(Sender: TObject);
@ -106,11 +105,6 @@ begin
IDEDialogLayoutList.SaveLayout(Self);
end;
procedure TAddFileToAPackageDialog.HelpButtonClick(Sender: TObject);
begin
LazarusHelp.ShowHelpForIDEControl(Self);
end;
procedure TAddFileToAPackageDialog.OkButtonClick(Sender: TObject);
var
PkgID: TLazPackageID;
@ -185,7 +179,6 @@ begin
BtnPanel.OkButton.Caption:=lisBtnOk;
BtnPanel.OkButton.OnClick:=@OkButtonClick;
BtnPanel.OkButton.ModalResult:=mrNone;
BtnPanel.HelpButton.OnClick:=@HelpButtonClick;
end;
procedure TAddFileToAPackageDialog.SetFilename(const AValue: string);

View File

@ -98,7 +98,6 @@ object InstallPkgSetDialog: TInstallPkgSetDialog
Constraints.MinWidth = 75
Kind = bkHelp
TabOrder = 0
OnClick = HelpButtonClick
end
object CancelButton: TBitBtn
Left = 519

View File

@ -50,7 +50,7 @@ uses
// BuildIntf
PackageIntf, PackageLinkIntf, PackageDependencyIntf,
// IdeIntf
IDEImagesIntf, IdeIntfStrConsts, IDEHelpIntf, IDEDialogs, IDEWindowIntf, InputHistory,
IDEImagesIntf, IdeIntfStrConsts, IDEDialogs, IDEWindowIntf, InputHistory,
// IdeUtils
IdeUtilsPkgStrConsts,
// IdeProject
@ -107,7 +107,6 @@ type
var PaintImages, {%H-}DefaultDraw: Boolean);
procedure AvailableTreeViewSelectionChanged(Sender: TObject);
procedure ExportButtonClick(Sender: TObject);
procedure HelpButtonClick(Sender: TObject);
procedure ImportButtonClick(Sender: TObject);
procedure SaveAndRebuildButtonClick(Sender: TObject);
procedure InstallPkgSetDialogCreate(Sender: TObject);
@ -329,11 +328,6 @@ begin
end;
end;
procedure TInstallPkgSetDialog.HelpButtonClick(Sender: TObject);
begin
LazarusHelp.ShowHelpForIDEControl(Self);
end;
procedure TInstallPkgSetDialog.ImportButtonClick(Sender: TObject);
var
OpenDialog: TOpenDialog;

View File

@ -69,7 +69,6 @@ object OpenLoadedPackagesDlg: TOpenLoadedPackagesDlg
OKButton.OnClick = OpenButtonClick
HelpButton.Name = 'HelpButton'
HelpButton.DefaultCaption = True
HelpButton.OnClick = HelpButtonClick
CloseButton.Name = 'CloseButton'
CloseButton.DefaultCaption = True
CancelButton.Name = 'CancelButton'

View File

@ -39,7 +39,7 @@ uses
// LazControls
ListViewFilterEdit,
// IdeIntf
IDEHelpIntf, IDEWindowIntf, PackageIntf,
IDEWindowIntf, PackageIntf,
// IDE
PackageDefs, LazarusIDEStrConsts, PackageSystem;
@ -55,7 +55,6 @@ type
Splitter1: TSplitter;
procedure FormClose(Sender: TObject; var {%H-}CloseAction: TCloseAction);
procedure FormCreate(Sender: TObject);
procedure HelpButtonClick(Sender: TObject);
procedure OpenButtonClick(Sender: TObject);
procedure PkgListViewDblClick(Sender: TObject);
procedure PkgListViewKeyPress(Sender: TObject; var Key: char);
@ -177,11 +176,6 @@ begin
IDEDialogLayoutList.SaveLayout(Self);
end;
procedure TOpenLoadedPackagesDlg.HelpButtonClick(Sender: TObject);
begin
LazarusHelp.ShowHelpForIDEControl(Self);
end;
function PkgStateToString(APackage: TLazPackage): string;
procedure AddState(const s: string);

View File

@ -47,7 +47,7 @@ uses
ProjectIntf, PackageDependencyIntf, PackageIntf, PackageLinkIntf,
IDEOptionsIntf, NewItemIntf, ComponentReg,
// IDEIntf
IDEImagesIntf, MenuIntf, LazIDEIntf, FormEditingIntf, IDEHelpIntf, InputHistory,
IDEImagesIntf, MenuIntf, LazIDEIntf, FormEditingIntf, InputHistory,
IdeIntfStrConsts, IDEWindowIntf, IDEDialogs, IDEOptEditorIntf, SrcEditorIntf,
// IdeConfig
EnvironmentOpts, SearchPathProcs, ParsedCompilerOpts, CompilerOptions,
@ -235,7 +235,6 @@ type
procedure ItemsTreeViewDblClick(Sender: TObject);
procedure ItemsTreeViewSelectionChanged(Sender: TObject);
procedure FixFilesCaseMenuItemClick(Sender: TObject);
procedure HelpBitBtnClick(Sender: TObject);
procedure InstallClick(Sender: TObject);
procedure MoveDownBtnClick(Sender: TObject);
procedure MoveUpBtnClick(Sender: TObject);
@ -1160,11 +1159,6 @@ begin
UpdateButtons;
end;
procedure TPackageEditorForm.HelpBitBtnClick(Sender: TObject);
begin
LazarusHelp.ShowHelpForIDEControl(Self);
end;
procedure TPackageEditorForm.InstallClick(Sender: TObject);
begin
PackageEditors.InstallPackage(LazPackage);
@ -1981,7 +1975,7 @@ begin
RemoveBitBtn := CreateToolButton('RemoveBitBtn', lisRemove, lisPckEditRemoveSelectedItem, 'laz_delete', @RemoveBitBtnClick);
CreateDivider;
OptionsBitBtn := CreateToolButton('OptionsBitBtn', lisOptions, lisPckEditEditGeneralOptions, 'pkg_properties', @OptionsBitBtnClick);
HelpBitBtn := CreateToolButton('HelpBitBtn', GetButtonCaption(idButtonHelp), lisMenuOnlineHelp, 'btn_help', @HelpBitBtnClick);
HelpBitBtn := CreateToolButton('HelpButton', GetButtonCaption(idButtonHelp), lisMenuOnlineHelp, 'btn_help', nil);
MoreBitBtn := CreateToolButton('MoreBitBtn', lisMoreSub, lisPkgEdMoreFunctionsForThePackage, '', nil);
MoreBitBtn.Style:=tbsButtonDrop;