Cocoa: fix the issue with Flipped Coordinates, Merge branch 'cocoa/flip'

note that on Cocoa:
1. Not Flipped: opposite to win32
2. Flipped: like win32

lcl/interfaces/cocoa/cocoaprivate.pas

@@ -505,9 +505,15 @@ begin
 end;
 
 procedure SetViewDefaults(AView: NSView);
+var
+  mask: NSUInteger;
 begin
   if not Assigned(AView) then Exit;
-  AView.setAutoresizingMask(NSViewMinYMargin or NSViewMaxXMargin);
+  if Assigned(AView.superview) and AView.superview.isFlipped then
+    mask:= NSViewMaxYMargin or NSViewMaxXMargin
+  else
+    mask:= NSViewMinYMargin or NSViewMaxXMargin;
+  AView.setAutoresizingMask(mask);
 end;
 
 function CheckMainThread: Boolean;
@@ -627,6 +633,8 @@ begin
 end;
 
 procedure TCocoaCustomControl.addSubView(aview: NSView);
+var
+  mask: NSUInteger;
 begin
   inherited addSubView(aview);
 
@@ -639,7 +647,11 @@ begin
       {$else}
       setAutoresizesSubviews(true);
       {$endif}
-    aview.setAutoresizingMask(NSViewMaxXMargin or NSViewMinYMargin);
+    if self.isFlipped then
+      mask:= NSViewMaxYMargin or NSViewMaxXMargin
+    else
+      mask:= NSViewMinYMargin or NSViewMaxXMargin;
+    aview.setAutoresizingMask(mask);
   end;
 end;
 
@@ -1360,7 +1372,7 @@ begin
   if (AParams.WndParent <> 0) then
     p := NSView(AParams.WndParent).lclContentView;
 
-  if Assigned(p) then
+  if Assigned(p) and p.isFlipped then
     LCLToNSRect(Types.Bounds(AParams.X, AParams.Y, AParams.Width, AParams.Height),
       p.frame.size.height, ns)
   else

lcl/interfaces/cocoa/cocoascrollers.pas

@@ -619,7 +619,10 @@ begin
            fvscroll.controlSize, fvscroll.preferredScrollerStyle);
     r := NSMakeRect(0, 0, w, Max(f.size.height,w+1)); // height<width to create a vertical scroller
     allocScroller( self, fvscroll, r, avisible);
-    fvscroll.setAutoresizingMask(NSViewHeightSizable or NSViewMinXMargin);
+    if self.isFlipped then
+      fvscroll.setAutoresizingMask(NSViewHeightSizable or NSViewMaxXMargin)
+    else
+      fvscroll.setAutoresizingMask(NSViewHeightSizable or NSViewMinXMargin);
     Result := fvscroll;
   end;
 end;
@@ -697,6 +700,7 @@ procedure TCocoaScrollView.scrollContentViewBoundsChanged(notify: NSNotification
 var
   nw    : NSRect;
   dx,dy : CGFloat;
+  scrollY: CGFloat;
 begin
   if not assigned(documentView) then Exit;
   nw:=documentVisibleRect;
@@ -710,6 +714,11 @@ begin
   if holdscroll>0 then Exit;
   inc(holdscroll);
   try
+    if self.documentView.isFlipped then
+      scrollY:= nw.origin.y
+    else
+      scrollY:= self.documentView.frame.size.height - nw.origin.y - nw.size.height;
+
     // update scrollers (this is required, if scrollWheel was called)
     // so processing LM_xSCROLL will not cause any actually scrolling,
     // as the current position will match!
@@ -718,7 +727,7 @@ begin
       callback.scroll(false, round(nw.origin.x));
 
     if (dy<>0) and assigned(callback) then
-      callback.scroll(true, round(self.documentView.frame.size.height - self.documentVisibleRect.origin.y - self.documentVisibleRect.size.height));
+      callback.scroll(true, round(scrollY));
   finally
     dec(holdscroll);
   end;

lcl/interfaces/cocoa/cocoatextedits.pas

@@ -2117,7 +2117,7 @@ begin
   lRect.Right := lRect.Right - SPINEDIT_DEFAULT_STEPPER_WIDTH;
   lStepperRect.Left := lRect.Right;
   svHeight := GetNSViewSuperViewHeight(Self);
-  if Assigned(superview)  then
+  if Assigned(superview) and NOT superview.isFlipped then
   begin
     LCLToNSRect(lRect, svHeight, ns);
     LCLToNSRect(lStepperRect, svHeight, lStepperNS);

lcl/interfaces/cocoa/cocoawscommon.pas

@@ -1482,7 +1482,8 @@ begin
     if FContext.InitDraw(Round(bounds.size.width), Round(bounds.size.height)) then
     begin
       nsr:=dirty;
-      nsr.origin.y:=bounds.size.height-dirty.origin.y-dirty.size.height;
+      if NOT Owner.isKindOfClass(NSView) or NOT NSView(Owner).isFlipped then
+         nsr.origin.y:=bounds.size.height-dirty.origin.y-dirty.size.height;
 
       if FIsOpaque and (Target.Color<>clDefault) then
       begin
@@ -1507,13 +1508,17 @@ end;
 procedure TLCLCommonCallback.DrawBackground(ctx: NSGraphicsContext; const bounds, dirtyRect: NSRect);
 var
   lTarget: TWinControl;
+  nsr:NSRect;
 begin
   // Implement Color property
   lTarget := TWinControl(GetTarget());
   if (lTarget.Color <> clDefault) and (lTarget.Color <> clBtnFace) then
   begin
     ColorToNSColor(ColorToRGB(lTarget.Color)).set_();
-    NSRectFill(dirtyRect);
+    nsr:=dirtyRect;
+    if NOT Owner.isKindOfClass(NSView) or NOT NSView(Owner).isFlipped then
+       nsr.origin.y:=bounds.size.height-dirtyRect.origin.y-dirtyRect.size.height;
+    NSRectFill(nsr);
   end;
 end;
 
@@ -1534,7 +1539,8 @@ begin
     if FContext.InitDraw(Round(bounds.size.width), Round(bounds.size.height)) then
     begin
       nsr:=dirty;
-      nsr.origin.y:=bounds.size.height-dirty.origin.y-dirty.size.height;
+      if NOT Owner.isKindOfClass(NSView) or NOT NSView(Owner).isFlipped then
+         nsr.origin.y:=bounds.size.height-dirty.origin.y-dirty.size.height;
 
       FillChar(PS, SizeOf(TPaintStruct), 0);
       PS.hdc := HDC(FContext);