From a0e07446183683ad403b8ccfec1ac9b980f79ad0 Mon Sep 17 00:00:00 2001
From: Bart <9132501-flyingsheep@users.noreply.gitlab.com>
Date: Tue, 1 Aug 2023 16:54:50 +0200
Subject: [PATCH] TaskDialog: implement OnHyperlinkClicked and associated
 property URL. Native Vista+ dialog only.

---
 lcl/dialogs.pp                         |  7 ++++++-
 lcl/include/taskdialog.inc             |  7 +++++++
 lcl/interfaces/win32/win32wsdialogs.pp | 13 +++++++++----
 3 files changed, 22 insertions(+), 5 deletions(-)

diff --git a/lcl/dialogs.pp b/lcl/dialogs.pp
index cec4f53662..214ad637d3 100644
--- a/lcl/dialogs.pp
+++ b/lcl/dialogs.pp
@@ -640,6 +640,7 @@ type
     FOnDialogCreated: TNotifyEvent;
     FOnDialogDestroyed: TNotifyEvent;
     FOnExpand: TNotifyEvent;
+    FOnHyperlinkClicked: TNotifyEvent;
     FOnRadioButtonClicked: TNotifyEvent;
     FOnTimer: TTaskDlgTimerEvent;
     FOnVerificationClicked: TNotifyEvent;
@@ -652,6 +653,7 @@ type
     FSimpleQueryPasswordChar: Char;
     FText: TTranslateString;
     FTitle: TTranslateString;
+    FURL: String;
     FVerificationText: TTranslateString;
     FWidth: Integer;
     FOnButtonClicked: TTaskDlgClickEvent;
@@ -671,7 +673,7 @@ type
     procedure DoOnTimer(TickCount: Cardinal; var Reset: Boolean); dynamic;
     procedure DoOnVerificationClicked(Checked: Boolean); dynamic;
     //procedure DoOnHelp; dynamic;
-    //procedure DoOnHyperlinkClicked(const AURL: string); dynamic;
+    procedure DoOnHyperlinkClicked(const AURL: string); dynamic;
     //procedure DoOnNavigated; dynamic;
 
     procedure SetRadioButtonFromRadioIndex(AIndex: Integer);
@@ -704,6 +706,7 @@ type
     property Title: TTranslateString read FTitle write FTitle;
     property VerificationText: TTranslateString read FVerificationText write FVerificationText;
     property Width: Integer read FWidth write FWidth default 0;
+    property URL: String read FURL;
     property OnButtonClicked: TTaskDlgClickEvent read FOnButtonClicked write FOnButtonClicked;
     property OnDialogConstructed: TNotifyEvent read FOnDialogConstructed write FOnDialogConstructed;
     property OnDialogCreated: TNotifyEvent read FOnDialogCreated write FOnDialogCreated;
@@ -712,6 +715,7 @@ type
     property OnExpand: TNotifyEvent read FOnExpand write FOnExpand;
     property OnTimer: TTaskDlgTimerEvent read FOnTimer write FOnTimer;
     property OnRadioButtonClicked: TNotifyEvent read FOnRadioButtonClicked write FOnRadioButtonClicked;
+    property OnHyperlinkClicked: TNotifyEvent read FOnHyperlinkClicked write FOnHyperlinkClicked;
   end;
 
   TTaskDialog = class(TCustomTaskDialog)
@@ -743,6 +747,7 @@ type
     property OnExpand;
     property OnTimer;
     property OnRadioButtonClicked;
+    property OnHyperlinkClicked;
   end;
 
 const
diff --git a/lcl/include/taskdialog.inc b/lcl/include/taskdialog.inc
index 8826e36d22..1fc615bef6 100644
--- a/lcl/include/taskdialog.inc
+++ b/lcl/include/taskdialog.inc
@@ -215,6 +215,13 @@ begin
     FOnVerificationClicked(Self);
 end;
 
+procedure TCustomTaskDialog.DoOnHyperlinkClicked(const AURL: string);
+begin
+  FURL := AURL;
+  if Assigned(FOnHyperlinkClicked) then
+    FOnHyperlinkClicked(Self);
+end;
+
 procedure TCustomTaskDialog.SetRadioButtonFromRadioIndex(AIndex: Integer);
 begin
   if (AIndex >= TaskDialogFirstRadioButtonIndex) and (AIndex-TaskDialogFirstRadioButtonIndex < RadioButtons.Count) then
diff --git a/lcl/interfaces/win32/win32wsdialogs.pp b/lcl/interfaces/win32/win32wsdialogs.pp
index 9f50b5e08a..dec1d5efe0 100644
--- a/lcl/interfaces/win32/win32wsdialogs.pp
+++ b/lcl/interfaces/win32/win32wsdialogs.pp
@@ -1659,8 +1659,10 @@ type
 
 function TaskDialogCallbackProc({%H-}hwnd: HWND; uNotification: UINT;
   wParam: WPARAM; {%H-}lParam: LPARAM; dwRefData: Long_Ptr): HRESULT; stdcall;
-var Dlg: TTaskDialog absolute dwRefData;
-    CanClose, ResetTimer: Boolean;
+var
+  Dlg: TTaskDialog absolute dwRefData;
+  CanClose, ResetTimer: Boolean;
+  AUrl: String;
 begin
   Result := S_OK;
   case uNotification of
@@ -1706,8 +1708,11 @@ begin
       lParam: Pointer to a wide-character string containing the URL of the hyperlink.
       Return value: The return value is ignored.
       }
-      //AUrl := Utf16ToUtf8(PWideChar(lParam));   <== can this be done safely and passed to OnUrlClicked if AUrls is a local variable here??
-      if IsConsole then writeln('ToDo: implement OnHyperlinkClicked');
+      AUrl := Utf16ToUtf8(PWideChar(lParam)); //  <== can this be done safely and passed to OnUrlClicked if AUrls is a local variable here??
+      {$PUSH}
+      {$ObjectChecks OFF}
+      TTaskDialogAccess(Dlg).DoOnHyperlinkClicked(AUrl);
+      {$POP}
     end;
     TDN_NAVIGATED:
     begin