LazDebuggerFp: Cleanup compiler hints

This commit is contained in:
Martin 2021-12-11 00:26:34 +01:00
parent 6e5c00bb59
commit a1c6e559e1
4 changed files with 6 additions and 11 deletions

View File

@ -1322,7 +1322,7 @@ function TFpDwarfInfoSymbolScope.FindExportedSymbolInUnit(
CU: TDwarfCompilationUnit; const ANameInfo: TNameSearchInfo; out CU: TDwarfCompilationUnit; const ANameInfo: TNameSearchInfo; out
AnInfoEntry: TDwarfInformationEntry; out AnIsExternal: Boolean): Boolean; AnInfoEntry: TDwarfInformationEntry; out AnIsExternal: Boolean): Boolean;
var var
i, ExtVal: Integer; ExtVal: Integer;
InfoEntry: TDwarfInformationEntry; InfoEntry: TDwarfInformationEntry;
s: String; s: String;
begin begin
@ -1375,7 +1375,7 @@ var
i, j: Integer; i, j: Integer;
CU: TDwarfCompilationUnit; CU: TDwarfCompilationUnit;
CUList: TDwarfCompilationUnitArray; CUList: TDwarfCompilationUnitArray;
InfoEntry, FoundInfoEntry: TDwarfInformationEntry; FoundInfoEntry: TDwarfInformationEntry;
IsExt: Boolean; IsExt: Boolean;
WorkItem, PrevWorkItem: TFpThreadWorkerFindSymbolInUnits; WorkItem, PrevWorkItem: TFpThreadWorkerFindSymbolInUnits;
begin begin

View File

@ -3762,8 +3762,6 @@ function TFpDwarfInfo.FindProcStartEndPC(const AAddress: TDbgPtr; out AStartPC,
var var
n: Integer; n: Integer;
CU: TDwarfCompilationUnit; CU: TDwarfCompilationUnit;
Iter: TLockedMapIterator;
Info: PDwarfAddressInfo;
MinMaxSet: boolean; MinMaxSet: boolean;
begin begin
for n := 0 to FCompilationUnits.Count - 1 do for n := 0 to FCompilationUnits.Count - 1 do

View File

@ -1650,10 +1650,9 @@ function TFpDbgMemManager.WriteMemory(AReadDataType: TFpDbgMemReadDataType;
const ASourceSize: QWord; AContext: TFpDbgLocationContext; const AFlags: TFpDbgMemManagerFlags const ASourceSize: QWord; AContext: TFpDbgLocationContext; const AFlags: TFpDbgMemManagerFlags
): Boolean; ): Boolean;
var var
WriteData, WriteData2: Pointer;
TmpVal: TDbgPtr; TmpVal: TDbgPtr;
BitOffset, DestExtraSize: Integer; BitOffset: Integer;
DestWriteSize, DestFullSize: QWord; DestWriteSize: QWord;
begin begin
Result := False; Result := False;
DebugLn(FPDBG_VERBOSE_MEM, ['$WriteMem: ', dbgs(AReadDataType),' ', dbgs(ADestLocation), ' ', dbgs(ADestSize), ' Source ', ASource]); DebugLn(FPDBG_VERBOSE_MEM, ['$WriteMem: ', dbgs(AReadDataType),' ', dbgs(ADestLocation), ' ', dbgs(ADestSize), ' Source ', ASource]);
@ -1671,7 +1670,7 @@ begin
// ToDo: Use a TargetMemConverter // ToDo: Use a TargetMemConverter
BitOffset := ADestLocation.BitOffset; BitOffset := ADestLocation.BitOffset;
DestExtraSize := (BitOffset + ADestSize.BitSize + 7) div 8; //DestExtraSize := (BitOffset + ADestSize.BitSize + 7) div 8;
case ADestLocation.MType of case ADestLocation.MType of
// ToDo: Add the ability to write to memory // ToDo: Add the ability to write to memory

View File

@ -2613,7 +2613,6 @@ var
Eax: TDBGPtr; Eax: TDBGPtr;
{$ENDIF} {$ENDIF}
o: Integer; o: Integer;
Frames: TFrameList;
n: String; n: String;
begin begin
case AnEventType of case AnEventType of
@ -2877,6 +2876,7 @@ begin
if assigned(FBreakPoints[bplFpcSpecific]) and FBreakPoints[bplFpcSpecific].HasLocation(PC) then begin if assigned(FBreakPoints[bplFpcSpecific]) and FBreakPoints[bplFpcSpecific].HasLocation(PC) then begin
debugln(FPDBG_COMMANDS, ['@ bplFpcSpecific ', DbgSName(CurrentCommand)]); debugln(FPDBG_COMMANDS, ['@ bplFpcSpecific ', DbgSName(CurrentCommand)]);
AFinishLoopAndSendEvents := False; AFinishLoopAndSendEvents := False;
AnIsFinished := False;
EnableBreaksDirect([bplRtlUnwind]); EnableBreaksDirect([bplRtlUnwind]);
if (FState = esIgnoredRaise) and not(CurrentCommand is TDbgControllerHiddenBreakStepBaseCmd) then if (FState = esIgnoredRaise) and not(CurrentCommand is TDbgControllerHiddenBreakStepBaseCmd) then
@ -2893,14 +2893,12 @@ begin
NumberParameters : DWORD; NumberParameters : DWORD;
ExceptionInformation : array[0..(EXCEPTION_MAXIMUM_PARAMETERS)-1] of ULONG_PTR; ExceptionInformation : array[0..(EXCEPTION_MAXIMUM_PARAMETERS)-1] of ULONG_PTR;
end; *) end; *)
{$PUSH}{$Q-}{$R-}
Rcx := CurrentThread.RegisterValueList.FindRegisterByDwarfIndex(2).NumValue; // rec: TExceptionRecord Rcx := CurrentThread.RegisterValueList.FindRegisterByDwarfIndex(2).NumValue; // rec: TExceptionRecord
{$PUSH}{$Q-}{$R-} {$PUSH}{$Q-}{$R-}
if (not CurrentProcess.ReadData(Rcx + 4, 4, EFlags)) or if (not CurrentProcess.ReadData(Rcx + 4, 4, EFlags)) or
((EFlags and 66) = 0) // rec.ExceptionFlags and EXCEPTION_UNWIND)=0 ((EFlags and 66) = 0) // rec.ExceptionFlags and EXCEPTION_UNWIND)=0
then then
exit; exit;
{$POP}
(* Get FrameBasePointe (RPB) for finally block (passed in R8) *) (* Get FrameBasePointe (RPB) for finally block (passed in R8) *)
R8 := CurrentThread.RegisterValueList.FindRegisterByDwarfIndex(8).NumValue; R8 := CurrentThread.RegisterValueList.FindRegisterByDwarfIndex(8).NumValue;