IDE: quickfixes: auto open changed units, bug #32284

git-svn-id: branches/fixes_1_8@55700 -

ide/etquickfixes.pas

@@ -95,7 +95,7 @@ type
     procedure QuickFix({%H-}Fixes: TMsgQuickFixes; Msg: TMessageLine); override;
   end;
 
-  { TQuickFixUnitNotFound_Remove }
+  { TQuickFixUnitNotFound_Remove, also "unit not used" }
 
   TQuickFixUnitNotFound_Remove = class(TMsgQuickFix)
   public
@@ -327,6 +327,7 @@ var
   Tool: TCodeTool;
   Code: TCodeBuffer;
   Comment: String;
+  OldChange: Boolean;
 begin
   if not IsApplicable(Msg,MsgID,Tool) then exit;
 
@@ -341,6 +342,9 @@ begin
     exit;
   end;
 
+  OldChange:=LazarusIDE.OpenEditorsOnCodeToolChange;
+  LazarusIDE.OpenEditorsOnCodeToolChange:=true;
+  try
     Comment:=' : '+TIDEFPCParser.GetFPCMsgPattern(Msg);
     if not CodeToolBoss.AddUnitWarnDirective(Code,IntToStr(MsgID),Comment,true) then
     begin
@@ -348,6 +352,9 @@ begin
       LazarusIDE.DoJumpToCodeToolBossError;
       exit;
     end;
+  finally
+    LazarusIDE.OpenEditorsOnCodeToolChange:=OldChange;
+  end;
 
   // success
   Msg.MarkFixed;
@@ -626,6 +633,7 @@ procedure TQuickFixLocalVariableNotUsed_Remove.QuickFix(Fixes: TMsgQuickFixes;
 var
   Identifier: String;
   Code: TCodeBuffer;
+  OldChange: Boolean;
 begin
   if not IsApplicable(Msg,Identifier) then exit;
 
@@ -637,12 +645,18 @@ begin
   Code:=CodeToolBoss.LoadFile(Msg.GetFullFilename,true,false);
   if Code=nil then exit;
 
+  OldChange:=LazarusIDE.OpenEditorsOnCodeToolChange;
+  LazarusIDE.OpenEditorsOnCodeToolChange:=true;
+  try
     if not CodeToolBoss.RemoveIdentifierDefinition(Code,Msg.Column,Msg.Line) then
     begin
       DebugLn(['TQuickFixLocalVariableNotUsed_Remove remove failed']);
       LazarusIDE.DoJumpToCodeToolBossError;
       exit;
     end;
+  finally
+    LazarusIDE.OpenEditorsOnCodeToolChange:=OldChange;
+  end;
 
   // message fixed
   Msg.MarkFixed;
@@ -789,6 +803,7 @@ var
   MissingUnitName: string;
   SrcUnitName: string;
   Code: TCodeBuffer;
+  OldChange: Boolean;
 begin
   if not IsApplicable(Msg,MissingUnitName,SrcUnitName) then begin
     debugln(['TQuickFixUnitNotFound_Remove.QuickFix invalid message ',Msg.Msg]);
@@ -803,6 +818,9 @@ begin
   Code:=CodeToolBoss.LoadFile(Msg.GetFullFilename,true,false);
   if Code=nil then exit;
 
+  OldChange:=LazarusIDE.OpenEditorsOnCodeToolChange;
+  LazarusIDE.OpenEditorsOnCodeToolChange:=true;
+  try
     if not CodeToolBoss.RemoveUnitFromAllUsesSections(Code,MissingUnitName) then
     begin
       DebugLn(['TQuickFixUnitNotFound_Remove RemoveUnitFromAllUsesSections failed']);
@@ -812,6 +830,9 @@ begin
 
     // success
     Msg.MarkFixed;
+  finally
+    LazarusIDE.OpenEditorsOnCodeToolChange:=OldChange;
+  end;
 end;
 
 { TQuickFixIdentifierNotFoundAddLocal }
@@ -868,6 +889,7 @@ var
   NewX: integer;
   NewY: integer;
   NewTopLine: integer;
+  OldChange: Boolean;
 begin
   if not IsApplicable(Msg,Identifier) then exit;
 
@@ -879,12 +901,18 @@ begin
   Code:=CodeToolBoss.LoadFile(Msg.GetFullFilename,true,false);
   if Code=nil then exit;
 
+  OldChange:=LazarusIDE.OpenEditorsOnCodeToolChange;
+  LazarusIDE.OpenEditorsOnCodeToolChange:=true;
+  try
     if not CodeToolBoss.CreateVariableForIdentifier(Code,Msg.Column,Msg.Line,-1,
                NewCode,NewX,NewY,NewTopLine,False)
     then begin
       LazarusIDE.DoJumpToCodeToolBossError;
       exit;
     end;
+  finally
+    LazarusIDE.OpenEditorsOnCodeToolChange:=OldChange;
+  end;
 
   // success
   Msg.MarkFixed;
@@ -929,7 +957,10 @@ var
   Tree: TAvlTree;
   Node: TAvlTreeNode;
   i: Integer;
+  OldChange: Boolean;
 begin
+  OldChange:=LazarusIDE.OpenEditorsOnCodeToolChange;
+  LazarusIDE.OpenEditorsOnCodeToolChange:=true;
   Tree:=TAvlTree.Create(@CompareMsgLinesSrcPos);
   try
     // get all messages to hide and sort them for position
@@ -957,6 +988,7 @@ begin
       Node:=Node.Precessor;
     end;
   finally
+    LazarusIDE.OpenEditorsOnCodeToolChange:=OldChange;
     Tree.Free;
   end;
 end;

ide/qfinitlocalvardlg.pas

@@ -120,7 +120,12 @@ begin
 end;
 
 procedure TQFInitLocalVarDialog.ButtonPanel1OKButtonClick(Sender: TObject);
+var
+  OldChange: Boolean;
 begin
+  OldChange:=LazarusIDE.OpenEditorsOnCodeToolChange;
+  LazarusIDE.OpenEditorsOnCodeToolChange:=true;
+  try
     if CodeToolBoss.InsertStatements(
       TInsertStatementPosDescription(InsertPositions[Max(0,WhereRadioGroup.ItemIndex)]),
       Statements[Max(0,ValueRadioGroup.ItemIndex)])
@@ -129,6 +134,9 @@ begin
     end else begin
       ModalResult:=mrAbort;
     end;
+  finally
+    LazarusIDE.OpenEditorsOnCodeToolChange:=OldChange;
+  end;
 end;
 
 procedure TQFInitLocalVarDialog.Init(TheStatements: TStrings;