Initialize variables based on compiler warnings around Lazarus and libs. Contains ToDo items.

git-svn-id: trunk@48481 -

components/PascalScript/Source/uPSDebugger.pas

@@ -461,6 +461,7 @@ begin
   LastCol := 0;
   if fi <> nil then begin
     pt := fi^.FPositionTable;
+    LastFn := '';
     for i := 0 to pt.Count -1 do
     begin
       r := pt[I];

components/ideintf/componenteditors.pas

@@ -953,7 +953,9 @@ var
 begin
   APage:=Page;
   if (APage.Parent<>nil) and (APage.Parent is TCustomTabControl) then
-    Result:=TCustomTabControl(APage.Parent);
+    Result:=TCustomTabControl(APage.Parent)
+  else
+    Result:=nil;
 end;
 
 function TPageComponentEditor.Page: TCustomPage;
@@ -1104,7 +1106,9 @@ var
 begin
   APage:=Page;
   if (APage.Parent<>nil) and (APage.Parent is TNotebook) then
-    Result:=TNotebook(APage.Parent);
+    Result:=TNotebook(APage.Parent)
+  else
+    Result:=nil;
 end;
 
 function TUNBPageComponentEditor.Page: TPage;

components/ideintf/fieldseditor.pas

@@ -485,6 +485,7 @@ function TFieldsComponentEditor.GetVerb(Index: Integer): string;
 begin
   case Index of
     0: Result := fesFeTitle;
+    else Result := '';
   end;
 end;
 

components/ideintf/ideoptionsintf.pas

@@ -362,6 +362,7 @@ begin
   for I := AStartIndex to High(Integer) do
     if IDEEditorGroups.GetByIndex(I) = nil then
       Exit(I);
+  Result := -1;
 end;
 
 function GetFreeIDEOptionsIndex(AGroupIndex: Integer; AStartIndex: Integer): Integer;

components/ideintf/menuintf.pas

@@ -1383,6 +1383,7 @@ procedure TIDEMenuSection.Remove(AnItem: TIDEMenuItem);
 var
   OldVisibleActive: Boolean;
 begin
+  OldVisibleActive:=False;
   if not (imssClearing in FStates) then begin
     OldVisibleActive:=AnItem.VisibleActive;
     FItems.Delete(AnItem.SectionIndex);

components/ideintf/objectinspector.pp

@@ -5458,7 +5458,10 @@ end;
 
 function TCustomPropertiesGrid.GetTIObject: TPersistent;
 begin
-  if PropertyEditorHook<>nil then Result:=PropertyEditorHook.LookupRoot;
+  if PropertyEditorHook<>nil then
+    Result:=PropertyEditorHook.LookupRoot
+  else
+    Result:=Nil;
 end;
 
 procedure TCustomPropertiesGrid.SetAutoFreeHook(const AValue: boolean);

components/ideintf/projectintf.pas

@@ -929,6 +929,7 @@ begin
         Result:='initialization'+LE+'  {$I '+ResourceFilename+'}'+LE+LE;
       end;
     rtRes: Result := '{$R *.lfm}'+LE+LE;
+    else Result:='';
   end;
 end;
 

components/ideintf/propedits.pp

@@ -4416,9 +4416,8 @@ var
   Persistent: TPersistent;
 begin
   if NewValue=GetValue then exit;
-  if (NewValue = '') or (NewValue=oisNone) then
-    Persistent := nil
-  else begin
+  Persistent := nil;
+  if (NewValue <> '') and (NewValue<>oisNone) then begin
     if Assigned(PropertyHook) then begin
       Persistent := PropertyHook.GetComponent(NewValue);
       if not (Persistent is GetTypeData(GetPropType)^.ClassType) then begin
@@ -4590,6 +4589,7 @@ begin
     else
       Intf := nil;
   end;
+  // ToDo: Intf is either Nil or uninitialized. JuMa
   SetIntfValue(Intf);
 end;
 
@@ -5301,6 +5301,7 @@ begin
   case Index of
     0: s := oisSetMaxConstraints;
     1: s := oisSetMinConstraints;
+    else s := '';
   end;
   c := GetComponent(0) as TControl;
   Result := Format(s, [c.Height, c.Width]);

components/lazcontrols/lvlgraphctrl.pas

@@ -2378,7 +2378,7 @@ begin
     for j:=0 to Level.Count-1 do
       if Level[j].Visible then
         LevelTxtWidths[i]:=Max(LevelTxtWidths[i], Canvas.TextWidth(Level[j].Caption));
-
+    p:=0; // Prevent compiler warning.
     if i=0 then begin
       // first level
       case NodeStyle.CaptionPosition of
@@ -3349,6 +3349,7 @@ begin
     Gap:=0;
     DrawHeight:=HardMaxTotal;
     for j:=0 to Level.Count-1 do begin
+      // ToDo: Node is probably uninitialized.
       LvlWeight+=Max(Node.InWeight,Node.OutWeight);
       Gap+=NodeGapAbove+NodeGapBelow;
     end;

components/lazutils/laz2_xpath.pas

@@ -657,6 +657,7 @@ begin
     ATTRIBUTE_NODE, PROCESSING_INSTRUCTION_NODE, COMMENT_NODE, TEXT_NODE,
       CDATA_SECTION_NODE, ENTITY_REFERENCE_NODE:
       Result := Node.NodeValue;
+    else Result := '';
   end;
   // !!!: What to do with 'namespace nodes'?
 end;

lcl/customdrawn_android.pas

@@ -532,6 +532,7 @@ end;
 
 function TCDDrawerAndroid.GetMeasures(AMeasureID: Integer): Integer;
 begin
+  Result := 0;
   case AMeasureID of
 {  TCDEDIT_LEFT_TEXT_SPACING: Result := 4;
   TCDEDIT_RIGHT_TEXT_SPACING: Result := 3;

lcl/customdrawncontrols.pas

@@ -1581,6 +1581,7 @@ begin
   lVisibleStr := LazUTF8.UTF8Copy(lVisibleStr, FEditState.VisibleTextStart.X, Length(lVisibleStr));
   lStrLen := LazUTF8.UTF8Length(lVisibleStr);
   lPos := FDrawer.GetMeasures(TCDEDIT_LEFT_TEXT_SPACING);
+  lBestMatch := 0;
   for i := 0 to lStrLen do
   begin
     lCurDiff := X - lPos;
@@ -2350,6 +2351,7 @@ var
 begin
   inherited KeyDown(Key, Shift);
 
+  NewPosition := 0;
   if (Key = VK_LEFT) or (Key = VK_DOWN) then
     NewPosition := FPosition - FSmallChange;
   if (Key = VK_UP) or (Key = VK_RIGHT) then

lcl/dbgrids.pas

@@ -1331,6 +1331,7 @@ begin
   			[ClassName, SbCodeToStr(Message.ScrollCode), dbgs(Message.Pos), Dbgs(FOldPosition)]);
   {$endif}
 
+  aPos := 0;
   IsSeq := FDatalink.DataSet.IsSequenced and not FDataLink.DataSet.Filtered;
   case Message.ScrollCode of
     SB_TOP:
@@ -2815,11 +2816,11 @@ function TCustomDBGrid.GetEditText(aCol, aRow: Longint): string;
 var
   aField: TField;
 begin
+  Result := '';
   if FDataLink.Active then begin
     aField := GetFieldFromGridColumn(aCol);
-    if aField<>nil then begin
+    if aField<>nil then
       Result := aField.Text;
-    end;
   end;
 end;
 
@@ -3072,15 +3073,18 @@ end;
 procedure TCustomDBGrid.DrawIndicator(ACanvas: TCanvas; R: TRect;
   Opt: TDataSetState; MultiSel: boolean);
 var
-  dx,dy, x, y: Integer;
+  dx, dy, x, y: Integer;
+
   procedure CenterY;
   begin
     y := R.Top + (R.Bottom-R.Top) div 2;
   end;
+
   procedure CenterX;
   begin
     X := R.Left + (R.Right-R.Left) div 2;
   end;
+
   procedure DrawEdit(clr: Tcolor);
   begin
     ACanvas.Pen.Color := clr;
@@ -3093,9 +3097,12 @@ var
     ACanvas.MoveTo(X-2, Y+Dy);
     ACanvas.LineTo(X+3, Y+Dy);
   end;
+
 begin
   dx := 6;
   dy := 6;
+  x := 0;
+  y := 0;
   case Opt of
     dsBrowse:
       begin //
@@ -3558,7 +3565,10 @@ end;
 function TComponentDataLink.GetFields(Index: Integer): TField;
 begin
   {$ifdef dbgGrid}DebugLn('%s.GetFields Index=%d',[ClassName, Index]); {$endif}
-  if (index>=0)and(index<DataSet.FieldCount) then result:=DataSet.Fields[index];
+  if (index>=0) and (index<DataSet.FieldCount) then
+    result:=DataSet.Fields[index]
+  else
+    result:=nil;
 end;
 
 function TComponentDataLink.GetDataSetName: string;

lcl/editbtn.pas

@@ -2445,6 +2445,7 @@ begin
     doYMD : B:=TryEncodeDate(N1,N2,N3,Result);
     doMDY : B:=TryEncodeDate(N3,N1,N2,Result);
     doDMY : B:=TryEncodeDate(N3,N2,N1,Result);
+    else B:=false;
   end;
   If not B then // Not sure if TryEncodeDate touches Result.
     Result:=Def;

lcl/grids.pas

@@ -5967,6 +5967,7 @@ begin
 end;
 
 procedure TCustomGrid.DoOPDeleteColRow(IsColumn: Boolean; index: Integer);
+
   procedure doDeleteColumn;
   var
     tmpIndex: Integer;
@@ -5996,6 +5997,7 @@ procedure TCustomGrid.DoOPDeleteColRow(IsColumn: Boolean; index: Integer);
 
     FixPosition(True, Index);
   end;
+
   procedure doDeleteRow;
   begin
     CheckFixedCount(ColCount, RowCount-1, FFixedCols, FFixedRows);
@@ -6015,6 +6017,7 @@ procedure TCustomGrid.DoOPDeleteColRow(IsColumn: Boolean; index: Integer);
     If FRowAutoInserted And (Index=FixedRows+(RowCount-1)) Then
       FRowAutoInserted := False;
   end;
+
 begin
   CheckIndex(IsColumn,Index);
   if IsColumn then begin
@@ -6032,8 +6035,6 @@ end;
 function TCustomGrid.EditorByStyle(Style: TColumnButtonStyle): TWinControl;
 begin
   case Style of
-    cbsNone, cbsCheckboxColumn, cbsButtonColumn:
-      Result := nil;
     cbsEllipsis:
       Result := FButtonStringEditor;
     cbsButton:
@@ -6041,9 +6042,9 @@ begin
     cbsPicklist:
       Result := FPicklistEditor;
     cbsAuto:
-      begin
-        Result := FStringEditor;
-      end;
+      Result := FStringEditor;
+    else {cbsNone, cbsCheckboxColumn, cbsButtonColumn:}
+      Result := nil;
   end;
 end;
 
@@ -8357,6 +8358,7 @@ var
       (CCol<=ColCount-1)and(CCol>=FixedCols)and
       (CRow<=RowCount-1)and(CRow>=FixedRows);
   end;
+
 begin
   ACol := FCol;
   ARow := FRow;
@@ -8470,7 +8472,9 @@ begin
     ScrollInfo.fMask := SIF_POS;
     GetScrollInfo(Handle, Which, ScrollInfo);
     Result:=ScrollInfo.nPos;
-  end;
+  end
+  else
+    Result:=0;
 end;
 
 function TCustomGrid.GetDefaultColumnWidth(Column: Integer): Integer;

lcl/include/application.inc

@@ -73,7 +73,9 @@ end;
 function GetApplicationName: string;
 begin
   if Assigned(Application) then
-    Result := Application.Title;
+    Result := Application.Title
+  else
+    Result := '';
 end;
 
 {------------------------------------------------------------------------------

lcl/include/control.inc

@@ -3848,15 +3848,14 @@ begin
   if lMode = lapDefault then lMode := Application.LayoutAdjustmentPolicy;
 
   // X-axis adjustment proportion
+  lXProportion := 1.0;
   if lMode = lapAutoAdjustWithoutHorizontalScrolling then
   begin
-    if AOldFormWidth > 0 then lXProportion := ANewFormWidth / AOldFormWidth
-    else lXProportion := 1.0;
+    if AOldFormWidth > 0 then lXProportion := ANewFormWidth / AOldFormWidth;
   end
   else if lMode = lapAutoAdjustForDPI then
   begin
-    if AFromDPI > 0 then lXProportion := AToDPI / AFromDPI
-    else lXProportion := 1.0;
+    if AFromDPI > 0 then lXProportion := AToDPI / AFromDPI;
   end;
 
   // y-axis adjustment proportion
@@ -3864,8 +3863,7 @@ begin
   else lYProportion := 1.0;
 
   // Apply the changes
-  if (lMode = lapAutoAdjustWithoutHorizontalScrolling) or
-   (lMode = lapAutoAdjustForDPI) then
+  if lMode in [lapAutoAdjustWithoutHorizontalScrolling, lapAutoAdjustForDPI] then
   begin
     if ShouldAutoAdjustLeftAndTop then
     begin

lcl/include/controlbar.inc

@@ -375,6 +375,7 @@ begin
   end;
   if i < aCount then begin
     { attempt to stick band by some existing band }
+    k := 0;
     if not bR2L then begin
       aLimit := ClientWidth - aBevel - cFullGrabber;
       j := 0;
@@ -934,6 +935,12 @@ begin
         aLeftMost := Math.min(aLeftMost, FVisiBands[i].Left);
         aRightMost := Math.max(aRightMost, FVisiBands[i].Right);
       end;
+    end
+    else begin
+      aBevel := 0;
+      aBound := 0;
+      aLeftMost := 0;
+      aRightMost := 0;
     end;
     if not bR2L then begin
       if (aRightMost > aBound) and (aLeftMost > aBevel) then begin

lcl/include/coolbar.inc

@@ -553,8 +553,10 @@ begin
   aStartIndex := 0;
   //set all Bands in row to uniform height
   aRowEnd := True;
+  aLeft := aBorderLeft;
   for i := 0 to aCountM1 do begin
-    if aRowEnd or FVisiBands[i].Break then aLeft := aBorderLeft;
+    if aRowEnd or FVisiBands[i].Break then
+      aLeft := aBorderLeft;
     aBandHeight := Max(aBandHeight, FVisiBands[i].CalcPreferredHeight);
     aRowEnd := (i = aCountM1);
     inc(aLeft, FVisiBands[i].Width);
@@ -580,7 +582,8 @@ begin
   aRowEnd := True;
   include(FWinControlFlags, wcfAligningControls);
   for i := 0 to aCountM1 do begin
-    if aRowEnd or FVisiBands[i].Break then aLeft := aBorderLeft;
+    if aRowEnd or FVisiBands[i].Break then
+      aLeft := aBorderLeft;
     if not FRightToLeft or Vertical then
       FVisiBands[i].FLeft := aLeft
     else
@@ -1152,8 +1155,8 @@ begin
   end;
   aCountM1 := length(FVisiBands)-1;
   if aCountM1 >= 0 then begin
-    if FBandBorderStyle = bsSingle then
-      aRaisedBevel := ((EdgeInner = esLowered) and (EdgeOuter = esRaised));
+    aRaisedBevel := (FBandBorderStyle = bsSingle) and
+                    (EdgeInner = esLowered) and (EdgeOuter = esRaised);
     aRowEnd := False;
     aGrabStyle := GrabStyle;
     if Vertical then

lcl/include/customform.inc

@@ -2163,7 +2163,7 @@ begin
   if FormStyle = fsMDIForm then
   begin
     // Query children forms whether we can close
-    if not Check(Self) then exit;
+    if not Check(Self) then exit(False);
     // TODO: mdi logic
   end;
   Result := True;

lcl/include/customtrayicon.inc

@@ -90,7 +90,7 @@ end;
 *******************************************************************}
 function TCustomTrayIcon.Hide: Boolean;
 begin
-  if not FVisible then Exit;
+  if not FVisible then Exit(True);
 
   FVisible := False;
 
@@ -139,10 +139,8 @@ end;
 *******************************************************************}
 function TCustomTrayIcon.Show: Boolean;
 begin
-  if FVisible then Exit;
-
+  if FVisible then Exit(True);
   FVisible := True;
-
   if not(csDesigning in ComponentState) then
     Result := InternalShow
   else

lcl/include/headercontrol.inc

@@ -311,6 +311,7 @@ var
   MaxState: THeaderSectionState;
   P: TPoint;
 begin
+  MaxState := hsNormal;
   Index := -1;
   if Enabled then
     if FDown then

lcl/include/intfbasewinapi.inc

@@ -298,6 +298,7 @@ var
 begin
   if uType = DFC_BUTTON then
   begin
+    ButtonDetail := tbButtonDontCare;
     case (uState and $1F) of
       DFCS_BUTTONCHECK:
         if uState and DFCS_CHECKED <> 0 then

lcl/include/promptdialog.inc

@@ -660,6 +660,7 @@ begin
   reqHeight:= TextBox.Bottom;
   if (FBitmap <> nil) and (FBitmap.Height > reqHeight) then
     reqHeight := FBitmap.Height;
+  // ToDo: CurBtnSize may not be initialized.
   inc(reqHeight, CurBtnSize.Y + 3 * cLabelSpacing);
 
   // calculate the text position

lcl/include/speedbutton.inc

@@ -1051,7 +1051,9 @@ begin
       Result := FGlyph.Draw(ACanvas, AClient, point(AOffset.x + 1, AOffset.y + 1), AState, ATransparent, BiDiFlags)
     else
       Result := FGlyph.Draw(ACanvas, AClient, AOffset, AState, ATransparent, BiDiFlags);
-  end;
+  end
+  else
+    Result := Rect(0,0,0,0);
 end;
 
 {------------------------------------------------------------------------------

lcl/include/toolbutton.inc

@@ -251,10 +251,11 @@ begin
     if Style = tbsDropDown then
     begin
       DropDownButtonRect := ButtonRect;
-      DropDownButtonRect.Left :=
-                        Max(0, DropDownButtonRect.Right - FToolBar.FDropDownWidth);
+      DropDownButtonRect.Left := Max(0, DropDownButtonRect.Right-FToolBar.FDropDownWidth);
       ButtonRect.Right := DropDownButtonRect.Left;
-    end;
+    end
+    else
+      DropDownButtonRect := Rect(0,0,0,0);
 
     // calculate text size
     TextSize.cx:=0;

lcl/include/wincontrol.inc

@@ -461,6 +461,7 @@ type
     if (Side in CurAnchors) then begin
       // this side is anchored
       SiblingData:=ChildData.Sides[Side].CtrlData;
+      NewDist:=0;
       if (SiblingData=nil) or (SiblingData=Self) then begin
         // this side is anchored to parent
         // Note: SiblingData=nil can happen, if the reference control
@@ -583,7 +584,7 @@ type
         end;
         if FoundSides=[] then begin
           ChildData.Sides[Side].DistanceState[Direction]:=assdfUncomputable;
-          exit;
+          exit(crSuccess);
         end;
 
         // this side is anchored to a sibling and some needed sibling sides are valid
@@ -5845,6 +5846,7 @@ function TWinControl.SendDialogChar(var Message : TLMKey): Boolean;
 var
   ParentForm: TCustomForm;
 begin
+  Result := False;
   ParentForm := GetParentForm(Self);
   if ParentForm <> nil then
   begin

lcl/intfgraphics.pas

@@ -5529,6 +5529,7 @@ begin
   Progress(psStarting, 0, False, Rect(0,0,0,0), '', FContinue);
   FImage := TheImage as TLazIntfImage;
   FIgnoreAlpha := True;
+  Depth := 0;
   InternalReadHead;
   
   if FUpdateDescription

lcl/lclproc.pas

@@ -2466,6 +2466,7 @@ begin
   if High(ASkipTo) >= 0
   then begin
     idx := 0;
+    Match := '';
     HasEscape := False;
     if AnIgnoreCase
     then S := UpperCase(Source)

lcl/lcltype.pp

@@ -3211,6 +3211,7 @@ begin
     FCS_ISO_8859_9:       result := 'FCS_ISO_8859_9';
     FCS_ISO_8859_10:      result := 'FCS_ISO_8859_10';
     FCS_ISO_8859_15:      result := 'FCS_ISO_8859_15';
+    else result := '';
   end;
 end;
 

lcl/ldocktree.pas

@@ -311,7 +311,8 @@ begin
   end;
 end;
 
-class function TDockHeader.FindPart(AHeaderRect: TRect; APoint: TPoint; AOrientation: TDockOrientation): TLazDockHeaderPart;
+class function TDockHeader.FindPart(AHeaderRect: TRect; APoint: TPoint;
+  AOrientation: TDockOrientation): TLazDockHeaderPart;
 var
   SubRect: TRect;
 begin
@@ -727,6 +728,7 @@ var
   LeftTopControl: TControl;
 begin
   Result:=TFPList.Create;
+  LeftTopControl:=nil;
 
   // find the Parent
   if (ARect[akLeft]=ARect[akRight]) and (ARect[akLeft] is TWinControl) then

lcl/lresources.pp

@@ -1938,6 +1938,7 @@ function TDelphiReader.ReadString: string;
 var
   L: Integer;
 begin
+  Result := '';
   if NextValue in [dvaWString, dvaUTF8String] then begin
     ReadError('TDelphiReader.ReadString: WideString and UTF8String are not implemented yet');
     //Result := ReadWideString;
@@ -2279,6 +2280,7 @@ procedure LRSObjectBinaryToText(Input, Output: TStream);
           Result := SmallInt(w);
         end;
       vaInt32: Result := ReadLRSInteger(Input);
+      else Result := 0;
     end;
   end;
 
@@ -2536,6 +2538,7 @@ procedure LRSObjectBinaryToText(Input, Output: TStream);
     ObjClassName, ObjName: String;
     ChildPos: LongInt;
   begin
+    ChildPos := 0;
     // Check for FilerFlags
     b := Input.ReadByte;
     if (b and $f0) = $f0 then begin

lcl/postscriptcanvas.pas

@@ -826,7 +826,7 @@ end;
 
 //Init the style of line
 procedure TPostScriptPrinterCanvas.UpdateLineStyle;
-Var st : string;
+Var St : string;
 begin
   if (Pen.Style<>fcPenStyle) and (Pen.Style<>psClear) then
   begin
@@ -836,6 +836,7 @@ begin
       psDot        : St:='[1 3] 0';
       psDashDot    : St:='[5 2 2 2] 0';
       psDashDotDot : St:='[5 2 2 2 2 2] 0';
+      else St:='';
     end;
     
     Write(Format('%s setdash',[St]));
@@ -2659,9 +2660,13 @@ var
       LeftPos: longint;
     begin
       if LeftOffset <> DT_LEFT then
-        Points[0] := TextExtent(theLine);
+        Points[0] := TextExtent(theLine)
+      else begin
+        Points[0].cx := 0;
+        Points[0].cy := 0;
+      end;
 
-       case LeftOffset of
+      case LeftOffset of
         DT_LEFT:
           LeftPos := theRect.Left;
         DT_CENTER:
@@ -2669,6 +2674,8 @@ var
             2 - Points[0].cX div 2;
         DT_RIGHT:
           LeftPos := theRect.Right - Points[0].cX;
+        else
+          LeftPos := 0;
       end;
 
       Pt := Point(0, 0);
@@ -2677,7 +2684,7 @@ var
       begin
         Pt.X := SavedRect.Left;
         Pt.Y := SavedRect.Top;
-         CalculateOffsetWithAngle(Font.Orientation, Pt.X, Pt.Y);
+        CalculateOffsetWithAngle(Font.Orientation, Pt.X, Pt.Y);
       end;
       TextOut(LeftPos + Pt.X, TopPos + Pt.Y, theLine);
     end;
@@ -2700,6 +2707,8 @@ var
             2 - Points[0].cX div 2;
         DT_RIGHT:
           LeftPos := theRect.Right - Points[0].cX;
+        else
+          LeftPos := 0;
       end;
 
       Pt := Point(0, 0);

lcl/translations.pas

@@ -1203,6 +1203,7 @@ begin
   begin
     // for each string in lrt/rst list check if it's already in PO
     // if not add it
+    MultilinedValue := false;
     Value := '';
     Identifier := '';
     i := 0;