paweld/lazarus
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/lazarus/lazarus.git synced 2025-09-07 19:40:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

LCL, don't use dataset.CompareBookmarks as it returns wrong results for some datasets, issue #21476

Browse Source 
git-svn-id: trunk@36080 -
This commit is contained in:
jesus 2012-03-16 09:28:45 +00:00
parent 45e367ea6e
commit b0e26a9051
1 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
lcl/dbgrids.pas
View File

@ -3905,7 +3905,26 @@ begin
end;
end;
function TBookmarkList.Find(const Item: TBookmark; var AIndex: Integer): boolean;
type
TDs=class(TDataset)
end;
function MyCompareBookmarks(ds:Tdataset; b1,b2:TBookmark): Integer;
begin
if b1=b2 then
result := 0
else
if b1=nil then
result := -1
else
if b2=nil then
result := 1
else begin
result := CompareMemRange(b1,b2,Tds(ds).bookmarksize);
end;
end;
function TBookmarkList.Find(const Item: TBookmark; var AIndex: Integer): boolean;
var
L, R, I: Integer;
CompareRes: PtrInt;
@ -3917,7 +3936,8 @@ begin
while (L <= R) do
begin
I := L + (R - L) div 2;
CompareRes := FDataset.CompareBookmarks(Item, TBookmark(FList[I]));
CompareRes := MyCompareBookmarks(FDataset, Item, TBookmark(FList[I]));
//CompareRes := FDataset.CompareBookmarks(Item, TBookmark(FList[I]));
if (CompareRes > 0) then
L := I + 1
else