DebuggerGDBMI: improve checks if gdb is running. Fix crash when gdb can not be launched. Issue #0027003

git-svn-id: trunk@47377 -

components/lazdebuggergdbmi/cmdlinedebugger.pp

@@ -329,26 +329,36 @@ end;
 
 function TCmdLineDebugger.CreateDebugProcess(const AOptions: String): Boolean;
 begin
+  Result := False;
   if FDbgProcess = nil
   then begin
     FDbgProcess := TProcessUTF8.Create(nil);
-    FDbgProcess.CommandLine := ExternalDebugger + ' ' + AOptions;
+    try
-    // TODO: under win9x and winMe should be created with console,
+      FDbgProcess.CommandLine := ExternalDebugger + ' ' + AOptions;
-    // otherwise no break can be sent.
+      // TODO: under win9x and winMe should be created with console,
-    FDbgProcess.Options:= [poUsePipes, poNoConsole, poStdErrToOutPut, poNewProcessGroup];
+      // otherwise no break can be sent.
-    FDbgProcess.ShowWindow := swoNone;
+      FDbgProcess.Options:= [poUsePipes, poNoConsole, poStdErrToOutPut, poNewProcessGroup];
-    FDbgProcess.Environment:=DebuggerEnvironment;
+      FDbgProcess.ShowWindow := swoNone;
+      FDbgProcess.Environment:=DebuggerEnvironment;
+    except
+      FreeAndNil(FDbgProcess);
+    end;
   end;
+  if FDbgProcess = nil then exit;
+
   if not FDbgProcess.Running
   then begin
     try
       FDbgProcess.Execute;
       DebugLn('[TCmdLineDebugger] Debug PID: ', IntToStr(FDbgProcess.Handle));
+      Result := FDbgProcess.Running;
     except
-      on E: Exception do DebugLn('Exeption while executing debugger: ', E.Message);
+      on E: Exception do begin
+        FOutputBuf := E.Message;
+        DebugLn('Exeption while executing debugger: ', FOutputBuf);
+      end;
     end;
   end;
-  Result := FDbgProcess.Running;
 end;
 
 destructor TCmdLineDebugger.Destroy;
@@ -430,6 +440,16 @@ begin
 // TODO: get extra handles to wait for
 // TODO: Fix multiple peeks
   Result := '';
+  if not DebugProcessRunning then begin
+    if FOutputBuf <> '' then begin
+      Result := FOutputBuf;
+      FOutputBuf := '';
+      exit;
+    end;
+    DoReadError;
+    exit;
+  end;
+
   FReadLineTimedOut := False;
   FReadLineWasAbortedByNested := False;
   if FReadLineCallStamp = high(FReadLineCallStamp) then
@@ -469,6 +489,10 @@ begin
 
     if FReadLineTimedOut
     then break;
+    if FDbgProcess.Output = nil then begin
+      DoReadError;
+      break;
+    end;
 
     WaitSet := WaitForHandles([FDbgProcess.Output.Handle], ATimeOut);
 
@@ -490,7 +514,7 @@ begin
     end;
 
     if  ((WaitSet and 1) <> 0)
-    and (FDbgProcess <> nil)
+    and DebugProcessRunning
     and (ReadData(FDbgProcess.Output, FOutputBuf) > 0) 
     then Continue; // start lineend search
 

components/lazdebuggergdbmi/gdbmidebugger.pp

@@ -8622,10 +8622,8 @@ begin
       end;
     end
     else begin
-      if DebugProcess = nil
+      include(FErrorHandlingFlags, ehfDeferReadWriteError);
-      then MessageDlg('Debugger', 'Failed to create debug process for unknown reason', mtError, [mbOK], 0)
+      SetErrorState(gdbmiFailedToLaunchExternalDbg, ReadLine(50));
-      else MessageDlg('Debugger', Format('Failed to create debug process: %s', [ReadLine(50)]), mtError, [mbOK], 0);
-      SetState(dsError);
     end;
 
     FGDBPtrSize := CpuNameToPtrSize(FGDBCPU); // will be set in StartDebugging

components/lazdebuggergdbmi/gdbmistringconstants.pas

@@ -60,6 +60,7 @@ resourcestring
   gdbmiEventLogDebugOutput = 'Debug Output: %s';
   gdbmiEventLogProcessExitNormally = 'Process Exit: normally';
   gdbmiEventLogProcessExitCode = 'Process Exit: %s';
+  gdbmiFailedToLaunchExternalDbg = 'Failed to create process for GDB';
   gdbmiFailedToTerminateGDBTitle = 'GDB did not terminate';
   gdbmiFailedToTerminateGDB = 'The IDE was unable to terminate the GDB process. '
     + 'This process may be left running outside the control of IDE.%0:s'