ide: drop files: invalidate file cache

ide/main.pp

@@ -5890,6 +5890,11 @@ var
 begin
   //DebugLn(['TMainIDE.DoDropFiles: ',length(Filenames), ' files, WindowIndex=', WindowIndex]);
   if Length(FileNames) = 0 then exit;
+
+  // the Drop event comes before the Application activate event or not at all
+  // => invalidate file state
+  InvalidateFileStateCache;
+
   FileList := TStringList.Create;
   FileList.AddStrings(FileNames);
   try

ide/mainbar.pas

@@ -414,7 +414,7 @@ implementation
 procedure TMainIDEBar.MainIDEBarDropFiles(Sender: TObject;
   const FileNames: array of String);
 begin
-  // the Drop event comes before the Application activate event
+  // the Drop event comes before the Application activate event or not at all
   // => invalidate file state
   InvalidateFileStateCache;
   LazarusIDE.DoDropFiles(Sender,FileNames);

ide/projectinspector.pas

@@ -895,6 +895,11 @@ begin
   debugln(['TProjectInspectorForm.FormDropFiles ',length(FileNames)]);
   {$ENDIF}
   if length(FileNames)=0 then exit;
+
+  // the Drop event comes before the Application activate event or not at all
+  // => invalidate file state
+  InvalidateFileStateCache;
+
   BeginUpdate;
   try
     for i:=0 to high(Filenames) do

packager/installpkgsetdlg.pas

@@ -392,6 +392,10 @@ var
 begin
   if length(FileNames) = 1 then // only one file
   begin
+    // the Drop event comes before the Application activate event or not at all
+    // => invalidate file state
+    InvalidateFileStateCache;
+
     lFilename := CleanAndExpandFilename(FileNames[0]);
     LoadPackageListFromFile(lFilename);
   end;

packager/packageeditor.pas

@@ -1505,7 +1505,6 @@ end;
 procedure TPackageEditorForm.FormDropFiles(Sender: TObject;
   const FileNames: array of String);
 var
-  i: Integer;
   Files: TStringList;
 begin
   {$IFDEF VerbosePkgEditDrag}
@@ -1514,13 +1513,13 @@ begin
   if length(FileNames)=0 then exit;
 
   //debugln(['TPackageEditorForm.FormDropFiles ']);
-  // the Drop does not always trigger an application activate event -> invalidate here
+  // the Drop event comes before the Application activate event or not at all
+  // => invalidate file state
   InvalidateFileStateCache;
 
   Files:=TStringList.Create;
   try
-    for i:=0 to high(Filenames) do
+    Files.AddStrings(FileNames);
-      Files.Add(FileNames[i]);
     AddUserFiles(Files);
   finally
     Files.Free;