From ddbcec7bcc83f0e5bf9a6e6a9c5436489a61de3e Mon Sep 17 00:00:00 2001 From: Maxim Ganetsky Date: Fri, 13 Oct 2023 02:28:44 +0300 Subject: [PATCH] LCL, LCLTranslator: Do not check if a property has a setter before even attempting to read what it is and thus ignoring classes (with translatable properties) returned by properties without setters. Check if a property setter is present only just before actually writing to it. Fixes translation of TLabeledEdit.EditLabel.Caption (EditLabel is a property without setter there). It was a regression after commit 36c7ef29edbdeb7d8fea99555e17f33d82fcafc1 which fixed issue #35202. --- lcl/lcltranslator.pas | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lcl/lcltranslator.pas b/lcl/lcltranslator.pas index 30ae272738..71393b519b 100644 --- a/lcl/lcltranslator.pas +++ b/lcl/lcltranslator.pas @@ -347,13 +347,12 @@ begin begin APropInfo:=APropList^[i]; if Assigned(PPropInfo(APropInfo)^.GetProc) and - Assigned(APropInfo^.PropType) and - Assigned(PPropInfo(APropInfo)^.SetProc) then + Assigned(APropInfo^.PropType) then case APropInfo^.PropType^.Kind of tkSString, tkLString, tkAString: - if APropInfo^.PropType=TypeInfo(TTranslateString) then + if (Assigned(PPropInfo(APropInfo)^.SetProc)) and (APropInfo^.PropType=TypeInfo(TTranslateString)) then begin TmpStr := GetStrProp(AnInstance, APropInfo); {$IFDEF VerbosePOTranslator}