Codetool: prevent recursion in ResolveBaseTypeOfIdentifier. Issue 39897

`fdfFunctionResult` will cause `FindExpressionTypeOfTerm` to `ResolveChildren` and recurse forever if the node starts with open brackets. If the cursor is not on an identifier, it should not be a function and the flag is not needed.

components/codetools/finddeclarationtool.pas

@@ -10460,6 +10460,7 @@ var EndPos, SubStartPos: integer;
 
 var
   OldFlags: TFindDeclarationFlags;
+  MaybeFuncAtCursor: Boolean;
 begin
   Result:=CleanExpressionType;
   if AliasType<>nil then
@@ -10473,9 +10474,9 @@ begin
   DebugLn('[TFindDeclarationTool.ReadOperandTypeAtCursor] A Atom=',GetAtom);
   debugln(['TFindDeclarationTool.ReadOperandTypeAtCursor StartContext=',Params.ContextNode.DescAsString,'="',dbgstr(Src,Params.ContextNode.StartPos,15),'"']);
   {$ENDIF}
-  if (AtomIsIdentifier)
+  MaybeFuncAtCursor := AtomIsIdentifier or UpAtomIs('INHERITED');
+  if (MaybeFuncAtCursor)
   or (CurPos.Flag=cafRoundBracketOpen)
-  or UpAtomIs('INHERITED')
   or UpAtomIs('ARRAY')
   then begin
     // read variable
@@ -10484,7 +10485,9 @@ begin
     if EndPos>MaxEndPos then
       EndPos:=MaxEndPos;
     OldFlags:=Params.Flags;
-    Params.Flags:=(Params.Flags*fdfGlobals)+[fdfFunctionResult];
+    Params.Flags:=(Params.Flags*fdfGlobals);
+    if MaybeFuncAtCursor then
+      Params.Flags:=Params.Flags+[fdfFunctionResult];
     Result:=FindExpressionTypeOfTerm(SubStartPos,EndPos,Params,true,AliasType);
     Params.Flags:=OldFlags;
     MoveCursorToCleanPos(EndPos);

components/codetools/tests/laztests/bug39897.pas

@@ -0,0 +1,20 @@
+program bug39897;
+{$mode objfpc}{$H+}
+uses
+  Classes;
+
+const
+  b = $1;
+  a = ((b)+1);
+procedure foo(x,y: byte);
+begin
+end;
+procedure foo(x,y: word);
+begin
+end;
+
+
+begin
+  foo{declaration:foo}(b, a);
+end.
+