Move SkipCheckByKey functions from IdeUtils (IdeIntf) to LazUtilities (LazUtils). No LCL dependency. Add comments in uses section.

This commit is contained in:
Juha 2023-06-09 11:14:23 +03:00
parent eac9c6e5c6
commit e3691f68f6
8 changed files with 56 additions and 36 deletions

View File

@ -27,8 +27,6 @@ type
cstFilename cstFilename
); );
TGetSkipCheckByKey = function(AKey: String): Boolean;
function IndexInStringList(List: TStrings; Cmp: TCmpStrType; s: string): integer; function IndexInStringList(List: TStrings; Cmp: TCmpStrType; s: string): integer;
procedure SetComboBoxText(AComboBox: TComboBox; const AText: String; procedure SetComboBoxText(AComboBox: TComboBox; const AText: String;
Cmp: TCmpStrType; MaxCount: integer = 1000); Cmp: TCmpStrType; MaxCount: integer = 1000);
@ -46,15 +44,9 @@ function GetValidDirectory(const aFileDirStr: string;
function GetValidDirectoryAndFilename(const aFileDirStr: string; function GetValidDirectoryAndFilename(const aFileDirStr: string;
out aoFileName : string): string; out aoFileName : string): string;
function GetSkipCheckByKey(AKey: String): Boolean;
procedure SetSkipCheckByKeyProc(AProc: TGetSkipCheckByKey);
implementation implementation
var
FGetSkipCheckByKeyProc: TGetSkipCheckByKey;
function IndexInStringList(List: TStrings; Cmp: TCmpStrType; s: string): integer; function IndexInStringList(List: TStrings; Cmp: TCmpStrType; s: string): integer;
var var
i: Integer; i: Integer;
@ -179,17 +171,5 @@ begin
aoFileName := lSWPD; aoFileName := lSWPD;
end; end;
function GetSkipCheckByKey(AKey: String): Boolean;
begin
Result := FGetSkipCheckByKeyProc <> nil;
if Result then
Result := FGetSkipCheckByKeyProc(AKey);
end;
procedure SetSkipCheckByKeyProc(AProc: TGetSkipCheckByKey);
begin
FGetSkipCheckByKeyProc := AProc;
end;
end. end.

View File

@ -15,6 +15,12 @@ interface
uses uses
Classes, SysUtils, TypInfo; Classes, SysUtils, TypInfo;
type
TGetSkipCheckByKey = function(AKey: String): Boolean;
function GetSkipCheckByKey(AKey: String): Boolean;
procedure SetSkipCheckByKeyProc(AProc: TGetSkipCheckByKey);
procedure FreeThenNil(var obj); procedure FreeThenNil(var obj);
function ComparePointers(p1, p2: Pointer): integer; inline; function ComparePointers(p1, p2: Pointer): integer; inline;
function CompareBoolean(b1, b2: boolean): integer; function CompareBoolean(b1, b2: boolean): integer;
@ -39,6 +45,21 @@ var
implementation implementation
var
FGetSkipCheckByKeyProc: TGetSkipCheckByKey;
function GetSkipCheckByKey(AKey: String): Boolean;
begin
Result := FGetSkipCheckByKeyProc <> nil;
if Result then
Result := FGetSkipCheckByKeyProc(AKey);
end;
procedure SetSkipCheckByKeyProc(AProc: TGetSkipCheckByKey);
begin
FGetSkipCheckByKeyProc := AProc;
end;
procedure FreeThenNil(var obj); procedure FreeThenNil(var obj);
begin begin
if Pointer(obj) <> nil then if Pointer(obj) <> nil then

View File

@ -8,8 +8,10 @@ uses
Classes, SysUtils, Classes, SysUtils,
// LCL // LCL
Dialogs, Dialogs,
// LazUtils
LazUtilities,
// IdeIntf // IdeIntf
SrcEditorIntf, IDEOptionsIntf, IDEOptEditorIntf, IDEUtils, SrcEditorIntf, IDEOptionsIntf, IDEOptEditorIntf,
// MacroScript // MacroScript
EMScriptMacro, EMSSelfTest, EMSIdeOptions, EMSStrings; EMScriptMacro, EMSSelfTest, EMSIdeOptions, EMSStrings;

View File

@ -52,9 +52,17 @@ interface
*) *)
uses uses
Classes, SysUtils, Controls, Forms, StdCtrls, Buttons, ButtonPanel, Classes, SysUtils,
LCLProc, LCLType, LazConf, LazFileUtils, Laz2_XMLCfg, LazFileCache, // LCL
IDEHelpIntf, IDEImagesIntf, IdeIntfStrConsts, LazarusIDEStrConsts, EnvironmentOpts; Controls, Forms, StdCtrls, Buttons, ButtonPanel, LCLType,
// LazUtils
LazFileUtils, Laz2_XMLCfg, LazFileCache, LazLoggerBase,
// IdeIntf
IDEHelpIntf, IDEImagesIntf, IdeIntfStrConsts,
// IdeConfig
LazConf, EnvironmentOpts,
// IDE
LazarusIDEStrConsts;
type type

View File

@ -33,18 +33,21 @@ interface
uses uses
// RTL // RTL
Classes, SysUtils, strutils, math, Classes, SysUtils, StrUtils, Math,
// CodeTools // CodeTools
KeywordFuncLists, CodeToolsFPCMsgs, CodeCache, FileProcs, CodeToolManager, KeywordFuncLists, CodeToolsFPCMsgs, CodeCache, FileProcs, CodeToolManager,
DirectoryCacher, BasicCodeTools, DefineTemplates, SourceLog, LinkScanner, DirectoryCacher, BasicCodeTools, DefineTemplates, SourceLog, LinkScanner,
// LazUtils // LazUtils
LConvEncoding, LazUTF8, FileUtil, LazFileUtils, LazFileCache, LazUtilities, LConvEncoding, LazUTF8, FileUtil, LazFileUtils, LazFileCache,
AvgLvlTree, LazUtilities, AvgLvlTree,
// BuildIntf
IDEExternToolIntf, PackageIntf, ProjectIntf, MacroIntf,
// IDEIntf // IDEIntf
IDEExternToolIntf, PackageIntf, LazIDEIntf, ProjectIntf, MacroIntf, IDEUtils, LazIDEIntf, IDEUtils,
// IdeConfig
EnvironmentOpts, LazConf,
// IDE // IDE
IDECmdLine, LazarusIDEStrConsts, EnvironmentOpts, LazConf, TransferMacros, IDECmdLine, LazarusIDEStrConsts, TransferMacros, etMakeMsgParser;
etMakeMsgParser;
const const
FPCMsgIDCompiling = 3104; FPCMsgIDCompiling = 3104;

View File

@ -14,9 +14,10 @@ uses
ListFilterEdit, ListFilterEdit,
// CodeTools // CodeTools
CodeToolsFPCMsgs, CodeToolsFPCMsgs,
// BuildIntf
IDEOptionsIntf, IDEExternToolIntf, CompOptsIntf,
// IdeIntf // IdeIntf
IDEOptionsIntf, IDEOptEditorIntf, IDEExternToolIntf, CompOptsIntf, IDEImagesIntf, IDEOptEditorIntf, IDEDialogs,
IDEDialogs,
// IDE // IDE
CompilerOptions, LazarusIDEStrConsts, etFPCMsgParser; CompilerOptions, LazarusIDEStrConsts, etFPCMsgParser;

View File

@ -40,8 +40,8 @@ interface
uses uses
Classes, SysUtils, Classes, SysUtils,
// LazUtils // LazUtils
FileUtil, LazFileUtils, LazStringUtils, LazUTF8, LazLogger, IDEUtils, FileUtil, LazFileUtils, LazStringUtils, LazUtilities, LazUTF8, LazLogger,
// IDE // IdeConfig
LazConf; LazConf;
// Checks at startup that can be skipped // Checks at startup that can be skipped

View File

@ -5,8 +5,13 @@ unit IdeTransferMacros;
interface interface
uses uses
Classes, SysUtils, IDETranslations, EnvironmentOpts, TransferMacros, Classes, SysUtils,
LazarusIDEStrConsts, LazConf, MacroDefIntf; // BuildIntf
MacroDefIntf,
// IdeConfig
EnvironmentOpts, LazConf,
// IDE
LazarusIDEStrConsts, TransferMacros, IDETranslations;
type type