paweld/lazarus
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/lazarus/lazarus.git synced 2025-09-16 14:59:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

TTaskDialog: add a comment why Execute always returns True.

Browse Source
This commit is contained in:
Bart 2023-07-28 17:20:27 +02:00
parent 033512d064
commit f48fe7983e
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lcl/include/taskdialog.inc
View File

@ -147,6 +147,10 @@ begin
FQueryResult := ''; FQueryResult := '';
ButtonID := TWSTaskDialogClass(WidgetSetClass).Execute(Self, ParentWnd, ARadioRes); ButtonID := TWSTaskDialogClass(WidgetSetClass).Execute(Self, ParentWnd, ARadioRes);
FModalResult := ButtonIDToModalResult(ButtonID); FModalResult := ButtonIDToModalResult(ButtonID);
//Note: this behaviour is inconsistent with all other dialogs, where a ModalResult of mrCancel would give a return value of False.
//It also does not conform to Delhi's offial documentation
//(https://docwiki.embarcadero.com/Libraries/Alexandria/en/Vcl.Dialogs.TCustomTaskDialog.Execute)
//But it seems that Delphi in fact does the same: it will always return True, as long as we succeed in showing the dialog.
Result := (ButtonID >= 0); Result := (ButtonID >= 0);
if (ARadioRes >= TaskDialogFirstRadioButtonIndex) and (aRadioRes-TaskDialogFirstRadioButtonIndex < RadioButtons.Count) then if (ARadioRes >= TaskDialogFirstRadioButtonIndex) and (aRadioRes-TaskDialogFirstRadioButtonIndex < RadioButtons.Count) then
FRadioButton := RadioButtons[ARadioRes-TaskDialogFirstRadioButtonIndex] as TTaskDialogRadioButtonItem FRadioButton := RadioButtons[ARadioRes-TaskDialogFirstRadioButtonIndex] as TTaskDialogRadioButtonItem