paweld/lazarus
1
0
Fork 0
mirror of https://gitlab.com/freepascal.org/lazarus/lazarus.git synced 2025-08-15 00:40:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

SynEditExport: only raise an exception (and a make that verbose one) if critical conditions are not met.

Browse Source 
git-svn-id: trunk@62479 -
This commit is contained in:
bart 2020-01-03 15:44:41 +00:00
parent 61ff6d46d1
commit fd263834a1
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
components/synedit/syneditexport.pas
View File

@ -210,6 +210,8 @@ type
property UseBackground: boolean read fUseBackground write fUseBackground; property UseBackground: boolean read fUseBackground write fUseBackground;
end; end;
ESynExport = class(Exception);
implementation implementation
uses uses
@ -309,16 +311,17 @@ var
TheLines: TSynEditStringsBase; TheLines: TSynEditStringsBase;
begin begin
// abort if not all necessary conditions are met // abort if not all necessary conditions are met
if not Assigned(ALines) or not Assigned(Highlighter) or (ALines.Count = 0) if not Assigned(ALines) or not Assigned(Highlighter) then
or (Start.Y > ALines.Count) or (Start.Y > Stop.Y) Raise ESynExport.Create('TSynCustomExporter.ExportAll: no lines or highlighter assigned.');
then
Abort; if (ALines.Count = 0) or (Start.Y > ALines.Count) or (Start.Y > Stop.Y) then
Exit; //simply terminate (and export nothing), no reason to raise an exception here
Stop.Y := Max(1, Min(Stop.Y, ALines.Count)); Stop.Y := Max(1, Min(Stop.Y, ALines.Count));
Stop.X := Max(1, Min(Stop.X, Length(ALines[Stop.Y - 1]) + 1)); Stop.X := Max(1, Min(Stop.X, Length(ALines[Stop.Y - 1]) + 1));
Start.X := Max(1, Min(Start.X, Length(ALines[Start.Y - 1]) + 1)); Start.X := Max(1, Min(Start.X, Length(ALines[Start.Y - 1]) + 1));
if (Start.Y = Stop.Y) and (Start.X >= Stop.X) then if (Start.Y = Stop.Y) and (Start.X >= Stop.X) then
Abort; Exit;
if ALines is TSynEditStringsBase then if ALines is TSynEditStringsBase then
TheLines := TSynEditStringsBase(ALines) TheLines := TSynEditStringsBase(ALines)